From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: gnome-session: remove outdated elogind workaround and fix overwriting lang
Date: Tue, 13 Sep 2022 20:24:40 +0200 [thread overview]
Message-ID: <20220913182440.iLWwsX0nHx1SLmVLhTH7DHq6ryAhpnwSeKA56AlYiU4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39196@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]
There's a closed pull request on the void-packages repository
gnome-session: remove outdated elogind workaround and fix overwriting lang
https://github.com/void-linux/void-packages/pull/39196
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
This removes an outdated workaround for an elogind issue that has been fixed a long time ago.
This also fixes a bug introduced by https://github.com/void-linux/void-packages/pull/9126 which causes the LANG variable written by GDM to be overwritten.
This patch was added as a hacky workaround since as stated here, GDM does not use `/etc/profile` on Wayland:
https://wiki.gnome.org/Initiatives/Wayland/SessionStart
That patch is incorrect since the issue affects all desktops loaded by GDM, not just gnome and results in a horribly broken experience when using `GDM -> <anything other than gnome>`, i.e. `/etc/profile.d/*.sh` not being loaded in terminals, flatpaks not working, etc. Those issues should be fixed properly. (which this PR attempts to do)
Closes: https://github.com/void-linux/void-packages/issues/15292
cc: @paper42
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
prev parent reply other threads:[~2022-09-13 18:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 23:59 [PR PATCH] gnome-session: remove outdated " oreo639
2022-09-10 5:04 ` [PR PATCH] [Updated] " oreo639
2022-09-10 5:05 ` oreo639
2022-09-10 5:06 ` oreo639
2022-09-10 5:59 ` oreo639
2022-09-10 6:02 ` oreo639
2022-09-12 23:03 ` oreo639
2022-09-13 2:09 ` oreo639
2022-09-13 4:09 ` oreo639
2022-09-13 4:13 ` oreo639
2022-09-13 5:27 ` oreo639
2022-09-13 6:06 ` oreo639
2022-09-13 9:10 ` [PR PATCH] [Updated] gnome-session: remove outdated elogind " oreo639
2022-09-13 17:31 ` oreo639
2022-09-13 18:24 ` oreo639 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913182440.iLWwsX0nHx1SLmVLhTH7DHq6ryAhpnwSeKA56AlYiU4@z \
--to=oreo639@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).