Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] [RFC]: vdummy shortcut for transitional packages
@ 2022-09-13 22:10 paper42
  2022-09-13 22:13 ` classabbyamp
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: paper42 @ 2022-09-13 22:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

New issue by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/39272

Description:
Every transitional package has at least these 3 common variables:
* `build_style=meta` - otherwise the build would fail because of an empty package
* `depends=...` - usually `${sourcepkg}>=${version}_${revision}`, but often `${version}_${revision}` is left out or `${sourcepkg}` is replaced by something else, for example `${sourcepkg}-devel` 
* `short_desc+=" transitional package"` or an equivalent, many versions currently exist in packages

a few examples:
```
antimicro_package() {                                                           
	build_style=meta                                                            
	depends="${sourcepkg}"                                                      
	short_desc+=" - transitional dummy package"                                 
}    
```

```
Gifsicle_package() {
	depends="gifsicle"
	short_desc+=" (transitional dummy package)"
	build_style=meta
}
```

This is a proposal for a vdummy function that fills these variables for the packager, for example:

```
antimicro_package() {
	vdummy ${sourcepkg}
}
```

`vdummy` should take one argument - the package name and use it in `$depends` - `depends="$1>=${version}_${revision}"`. `vdummy` will also unify `$short_desc` for transitional packages, I would propose to use the ` - (transitional dummy package)` style.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC]: vdummy shortcut for transitional packages
  2022-09-13 22:10 [ISSUE] [RFC]: vdummy shortcut for transitional packages paper42
@ 2022-09-13 22:13 ` classabbyamp
  2022-09-14 12:29 ` Anachron
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-09-13 22:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/39272#issuecomment-1246003199

Comment:
I like this idea

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC]: vdummy shortcut for transitional packages
  2022-09-13 22:10 [ISSUE] [RFC]: vdummy shortcut for transitional packages paper42
  2022-09-13 22:13 ` classabbyamp
@ 2022-09-14 12:29 ` Anachron
  2022-09-14 22:50 ` paper42
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Anachron @ 2022-09-14 12:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/issues/39272#issuecomment-1246692394

Comment:
I am not against it, but what problem does this actually `solve`?
This looks like a solution to a non-existing problem to me. 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC]: vdummy shortcut for transitional packages
  2022-09-13 22:10 [ISSUE] [RFC]: vdummy shortcut for transitional packages paper42
  2022-09-13 22:13 ` classabbyamp
  2022-09-14 12:29 ` Anachron
@ 2022-09-14 22:50 ` paper42
  2022-09-14 22:52 ` paper42
  2022-12-14  2:01 ` github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-09-14 22:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/39272#issuecomment-1247379266

Comment:
* it's shorter and cleaner
* unifies the short_desc style
* makes sure the $depends version restriction is always the same
* it's a good practice to do things like this - if we for example wanted to add transitional=yes (that would tell xbps to mark this package as automatically installed and mark all $depends as manually installed) to every transitional package, we can easily do it in one place instead of figuring out which packages are transitional and changing it in hundreds of places.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC]: vdummy shortcut for transitional packages
  2022-09-13 22:10 [ISSUE] [RFC]: vdummy shortcut for transitional packages paper42
                   ` (2 preceding siblings ...)
  2022-09-14 22:50 ` paper42
@ 2022-09-14 22:52 ` paper42
  2022-12-14  2:01 ` github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-09-14 22:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/39272#issuecomment-1247379266

Comment:
* it's shorter and cleaner, I don't have to remember all 3 variables and what's usually in them
* unifies the short_desc style
* makes sure the $depends version restriction is always the same
* it's a good practice to do things like this - if we for example wanted to add transitional=yes (that would tell xbps to mark this package as automatically installed and mark all $depends as manually installed) to every transitional package, we can easily do it in one place instead of figuring out which packages are transitional and changing it in hundreds of places.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC]: vdummy shortcut for transitional packages
  2022-09-13 22:10 [ISSUE] [RFC]: vdummy shortcut for transitional packages paper42
                   ` (3 preceding siblings ...)
  2022-09-14 22:52 ` paper42
@ 2022-12-14  2:01 ` github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-12-14  2:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/39272#issuecomment-1350243775

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-12-14  2:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13 22:10 [ISSUE] [RFC]: vdummy shortcut for transitional packages paper42
2022-09-13 22:13 ` classabbyamp
2022-09-14 12:29 ` Anachron
2022-09-14 22:50 ` paper42
2022-09-14 22:52 ` paper42
2022-12-14  2:01 ` github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).