From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: id3lib: patch for c99 bool
Date: Thu, 15 Sep 2022 17:59:33 +0200 [thread overview]
Message-ID: <20220915155933.lyW-ri0AAy_3ydNHjOGVpl14Tq_q1Q_RYO9e5fBRexw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39275@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]
There's a merged pull request on the void-packages repository
id3lib: patch for c99 bool
https://github.com/void-linux/void-packages/pull/39275
Description:
id3/globals.h has a typedef for bool which is incompatible with c99 stdbool.
This is a known issue, but upstream is effectively unmaintained.
See [this thread](https://sourceforege.net/p/id3lib/mailman/message/30500558/) from upstream.
This only seems to be an issue for castget while building, and they have already switched to using taglib for the next release.
Castget [issue](https://github.com/mlj/castget/issues/47).
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
prev parent reply other threads:[~2022-09-15 15:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 4:41 [PR PATCH] " mtboehlke
2022-09-14 4:41 ` [PR PATCH] [Updated] " mtboehlke
2022-09-14 4:44 ` [PR REVIEW] " sgn
2022-09-14 4:45 ` sgn
2022-09-14 4:50 ` [PR PATCH] [Updated] " mtboehlke
2022-09-14 4:51 ` mtboehlke
2022-09-14 4:59 ` [PR PATCH] [Updated] " mtboehlke
2022-09-14 5:00 ` mtboehlke
2022-09-14 5:01 ` mtboehlke
2022-09-15 1:57 ` [PR REVIEW] " sgn
2022-09-15 1:57 ` sgn
2022-09-15 2:13 ` [PR PATCH] [Updated] " sgn
2022-09-15 2:15 ` sgn
2022-09-15 3:40 ` [PR REVIEW] " mtboehlke
2022-09-15 3:48 ` mtboehlke
2022-09-15 4:39 ` mtboehlke
2022-09-15 14:49 ` [PR PATCH] [Updated] " sgn
2022-09-15 14:51 ` sgn
2022-09-15 14:59 ` [PR PATCH] [Updated] " sgn
2022-09-15 15:59 ` sgn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915155933.lyW-ri0AAy_3ydNHjOGVpl14Tq_q1Q_RYO9e5fBRexw@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).