[PR PATCH] New package: cockatrice-2.8.0

[PR PATCH] New package: cockatrice-2.8.0

[NuclearPine]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

There is a new pull request by NuclearPine against master on the void-packages repository

https://github.com/NuclearPine/void-packages cockatrice
https://github.com/void-linux/void-packages/pull/39292

New package: cockatrice-2.8.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64 (glibc) - crossbuild



A patch file from https://github.com/void-linux/void-packages/pull/39292.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cockatrice-39292.patch --]
[-- Type: text/x-diff, Size: 1496 bytes --]

From 3a3cd87ee79fd7e4c5d3fb883b8b0c280e842b04 Mon Sep 17 00:00:00 2001
From: NuclearPine <nuclearpine.h3nbw@aleeas.com>
Date: Tue, 13 Sep 2022 22:21:13 -0600
Subject: [PATCH] New package: cockatrice-2.8.0

---
 srcpkgs/cockatrice/template | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 srcpkgs/cockatrice/template

diff --git a/srcpkgs/cockatrice/template b/srcpkgs/cockatrice/template
new file mode 100644
index 000000000000..909f2b4b65e6
--- /dev/null
+++ b/srcpkgs/cockatrice/template
@@ -0,0 +1,31 @@
+# Template file for 'cockatrice'
+pkgname=cockatrice
+version=2.8.0
+revision=1
+make_use_env=compliant
+hostmakedepends="cmake"
+makedepends="liblzma-devel protobuf protobuf-devel qt5-devel qt5-multimedia-devel qt5-svg-devel qt5-tools-devel qt5-websockets-devel"
+depends="liblzma protobuf qt5 qt5-multimedia qt5-svg qt5-tools qt5-websockets"
+short_desc="Program for playing tabletop card games over a network"
+maintainer="NuclearPine <nuclearpine.h3nbw@aleeas.com>"
+license="GPL-2.0-only"
+homepage="https://cockatrice.github.io"
+distfiles="https://github.com/Cockatrice/Cockatrice/archive/refs/tags/2021-01-26-Release-2.8.0.tar.gz"
+wrksrc="Cockatrice-2021-01-26-Release-2.8.0"
+checksum=fbf908138e40b20529ebdc27b3b37d63891bf6a91f660be694407a8e57471e79
+
+do_configure() {
+	mkdir -p build
+	cd build
+	cmake ..
+}
+
+do_build() {
+	cd build
+	make $makejobs
+}
+
+do_install() {
+	cd build
+	cmake --install . --prefix $PKGDESTDIR/usr
+}

Re: [PR REVIEW] New package: cockatrice-2.8.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#discussion_r971410079

Comment:
this does nothing

Re: [PR REVIEW] New package: cockatrice-2.8.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#discussion_r971410287

Comment:
these are probably not needed, they will be auto-detected

Re: [PR REVIEW] New package: cockatrice-2.8.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#discussion_r971410053

Comment:
use the cmake `build_style`

Re: [PR REVIEW] New package: cockatrice-2.8.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#discussion_r971411281

Comment:
don't hardcode the version here, use `$version`

you might also want to define a `_reldate` variable for that date, to make things easier to update

Re: [PR REVIEW] New package: cockatrice-2.8.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#discussion_r971411507

Comment:
these will go away when you use the build_style

Re: [PR REVIEW] New package: cockatrice-2.8.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#discussion_r971410424

Comment:
protobuf should be a `hostmakedepends`

Re: [PR PATCH] [Updated] New package: cockatrice-2.8.0

[NuclearPine]

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]

There is an updated pull request by NuclearPine against master on the void-packages repository

https://github.com/NuclearPine/void-packages cockatrice
https://github.com/void-linux/void-packages/pull/39292

New package: cockatrice-2.8.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64 (glibc) - crossbuild



A patch file from https://github.com/void-linux/void-packages/pull/39292.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cockatrice-39292.patch --]
[-- Type: text/x-diff, Size: 1236 bytes --]

From 3292edb7c395b7b77f8cc436736324531b924194 Mon Sep 17 00:00:00 2001
From: NuclearPine <nuclearpine.h3nbw@aleeas.com>
Date: Tue, 13 Sep 2022 22:21:13 -0600
Subject: [PATCH] New package: cockatrice-2.8.0

---
 srcpkgs/cockatrice/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/cockatrice/template

diff --git a/srcpkgs/cockatrice/template b/srcpkgs/cockatrice/template
new file mode 100644
index 000000000000..112dba74d758
--- /dev/null
+++ b/srcpkgs/cockatrice/template
@@ -0,0 +1,15 @@
+# Template file for 'cockatrice'
+pkgname=cockatrice
+version=2.8.0
+revision=1
+_reldate=2021-01-26
+build_style=cmake
+hostmakedepends="protobuf protobuf-devel"
+makedepends="liblzma-devel qt5-devel qt5-multimedia-devel qt5-svg-devel qt5-tools-devel qt5-websockets-devel"
+short_desc="Program for playing tabletop card games over a network"
+maintainer="NuclearPine <nuclearpine.h3nbw@aleeas.com>"
+license="GPL-2.0-only"
+homepage="https://cockatrice.github.io"
+distfiles="https://github.com/Cockatrice/Cockatrice/archive/refs/tags/${_reldate}-Release-${version}.tar.gz"
+wrksrc="Cockatrice-${_reldate}-Release-${version}"
+checksum=fbf908138e40b20529ebdc27b3b37d63891bf6a91f660be694407a8e57471e79

Re: New package: cockatrice-2.8.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#issuecomment-1248805524

Comment:
you probably need `qt5-host-tools qt5-qmake` in hostmakedepends for that cross error

Re: [PR REVIEW] New package: cockatrice-2.8.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#discussion_r972531436

Comment:
only `protobuf` should go in hostmakedepends because it needs to run `protoc` from that package, right? `protobuf-devel` needs to go in makedepends because it's for compiling against the protobuf library

Re: New package: cockatrice-2.8.0

[NuclearPine]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

New comment by NuclearPine on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#issuecomment-1248858054

Comment:
> you probably need `qt5-host-tools qt5-qmake` in hostmakedepends for that cross error

Thanks - now builds for armv7l and aarch64 on my local machine.

Re: [PR PATCH] [Updated] New package: cockatrice-2.8.0

[NuclearPine]

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]

There is an updated pull request by NuclearPine against master on the void-packages repository

https://github.com/NuclearPine/void-packages cockatrice
https://github.com/void-linux/void-packages/pull/39292

New package: cockatrice-2.8.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64 (glibc) - crossbuild



A patch file from https://github.com/void-linux/void-packages/pull/39292.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cockatrice-39292.patch --]
[-- Type: text/x-diff, Size: 1261 bytes --]

From 7165578bafdecaab4017a45e1820e398d18dcaba Mon Sep 17 00:00:00 2001
From: NuclearPine <nuclearpine.h3nbw@aleeas.com>
Date: Tue, 13 Sep 2022 22:21:13 -0600
Subject: [PATCH] New package: cockatrice-2.8.0

---
 srcpkgs/cockatrice/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/cockatrice/template

diff --git a/srcpkgs/cockatrice/template b/srcpkgs/cockatrice/template
new file mode 100644
index 000000000000..032c4802e2f7
--- /dev/null
+++ b/srcpkgs/cockatrice/template
@@ -0,0 +1,15 @@
+# Template file for 'cockatrice'
+pkgname=cockatrice
+version=2.8.0
+revision=1
+_reldate=2021-01-26
+wrksrc="Cockatrice-${_reldate}-Release-${version}"
+build_style=cmake
+hostmakedepends="protobuf qt5-host-tools qt5-qmake"
+makedepends="protobuf-devel liblzma-devel qt5-devel qt5-multimedia-devel qt5-svg-devel qt5-tools-devel qt5-websockets-devel"
+short_desc="Program for playing tabletop card games over a network"
+maintainer="NuclearPine <nuclearpine.h3nbw@aleeas.com>"
+license="GPL-2.0-only"
+homepage="https://cockatrice.github.io"
+distfiles="https://github.com/Cockatrice/Cockatrice/archive/refs/tags/${_reldate}-Release-${version}.tar.gz"
+checksum=fbf908138e40b20529ebdc27b3b37d63891bf6a91f660be694407a8e57471e79

Re: New package: cockatrice-2.8.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/39292#issuecomment-1354068129

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: cockatrice-2.8.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

There's a closed pull request on the void-packages repository

New package: cockatrice-2.8.0
https://github.com/void-linux/void-packages/pull/39292

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64 (glibc) - crossbuild