[-- Attachment #1: Type: text/plain, Size: 667 bytes --] There is a new pull request by loreb against master on the void-packages repository https://github.com/loreb/void-packages dma-34431 https://github.com/void-linux/void-packages/pull/34451 dma: fix /etc/dma/*.conf permissions Fixes https://github.com/void-linux/void-packages/issues/34431; solution due to thenktor <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **briefly** #### Local build testing - I built this PR locally for my native architecture, (x86-64-musl) A patch file from https://github.com/void-linux/void-packages/pull/34451.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-dma-34431-34451.patch --] [-- Type: text/x-diff, Size: 1158 bytes --] From 0d69c102fa4ffe349d8574c81d9cee424e6ee0a5 Mon Sep 17 00:00:00 2001 From: Lorenzo Beretta <vc.net.loreb@gmail.com> Date: Thu, 9 Dec 2021 21:46:24 +0100 Subject: [PATCH] dma: fix /etc/dma/*.conf permissions Fixes https://github.com/void-linux/void-packages/issues/34431; solution due to thenktor --- srcpkgs/dma/INSTALL | 1 + srcpkgs/dma/template | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/srcpkgs/dma/INSTALL b/srcpkgs/dma/INSTALL index 88bfc22cca11..e35876f94cf6 100644 --- a/srcpkgs/dma/INSTALL +++ b/srcpkgs/dma/INSTALL @@ -2,6 +2,7 @@ case ${ACTION} in post) # fix permissions and owners chown root:mail usr/bin/dma + chown root:mail etc/dma/auth.conf etc/dma/dma.conf chmod 2755 usr/bin/dma chown root:mail usr/lib/dma-mbox-create chmod 4754 usr/lib/dma-mbox-create diff --git a/srcpkgs/dma/template b/srcpkgs/dma/template index 71892496013f..78c71595ec15 100644 --- a/srcpkgs/dma/template +++ b/srcpkgs/dma/template @@ -1,7 +1,7 @@ # Template file for 'dma' pkgname=dma version=0.13 -revision=3 +revision=4 conf_files="/etc/dma/*.conf" make_dirs="/var/spool/dma 2775 root mail" hostmakedepends="flex"
[-- Attachment #1: Type: text/plain, Size: 1457 bytes --] New comment by loreb on void-packages repository https://github.com/void-linux/void-packages/pull/34451#issuecomment-990259190 Comment: Btw, in case anyone wants to take a look, there were a couple of compilation warnings: ``` net.c: In function 'read_remote.part.0': net.c:159:6: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation] 159 | strncpy(neterr, strerror(errno), sizeof(neterr)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net.c:154:6: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation] 154 | strncpy(neterr, ssl_errstr(), sizeof(neterr)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net.c:168:4: warning: 'strncat' output may be truncated copying between 0 and 1023 bytes from a string of length 2047 [-Wstringop-truncation] 168 | strncat(neterr, buff, copysize); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net.c: In function 'send_remote_command': net.c:104:5: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation] 104 | strncpy(neterr, ssl_errstr(), sizeof(neterr)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` They were fixed upstream in February 2020 (strncpy=>strlcpy), except that it looks to me that the 2047=>1023 is still there (strncat) and replacing it with strlcat would silence the warning without actually fixing the issue.
[-- Attachment #1: Type: text/plain, Size: 280 bytes --] New comment by loreb on void-packages repository https://github.com/void-linux/void-packages/pull/34451#issuecomment-990267930 Comment: Urgh... upstream set -Wno-format-truncation, reenabling it shows some extra snprintf warnings which I'm not looking into, at least right now.
[-- Attachment #1: Type: text/plain, Size: 305 bytes --] New comment by github-actions[bot] on void-packages repository https://github.com/void-linux/void-packages/pull/34451#issuecomment-1159340177 Comment: Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
[-- Attachment #1: Type: text/plain, Size: 144 bytes --] New comment by loreb on void-packages repository https://github.com/void-linux/void-packages/pull/34451#issuecomment-1159454803 Comment: bump
[-- Attachment #1: Type: text/plain, Size: 305 bytes --] New comment by github-actions[bot] on void-packages repository https://github.com/void-linux/void-packages/pull/34451#issuecomment-1250175479 Comment: Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
[-- Attachment #1: Type: text/plain, Size: 144 bytes --] New comment by loreb on void-packages repository https://github.com/void-linux/void-packages/pull/34451#issuecomment-1250359998 Comment: bump
[-- Attachment #1: Type: text/plain, Size: 168 bytes --] New comment by classabbyamp on void-packages repository https://github.com/void-linux/void-packages/pull/34451#issuecomment-1250372313 Comment: can you rebase this?
[-- Attachment #1: Type: text/plain, Size: 672 bytes --] There is an updated pull request by loreb against master on the void-packages repository https://github.com/loreb/void-packages dma-34431 https://github.com/void-linux/void-packages/pull/34451 dma: fix /etc/dma/*.conf permissions Fixes https://github.com/void-linux/void-packages/issues/34431; solution due to thenktor <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **briefly** #### Local build testing - I built this PR locally for my native architecture, (x86-64-musl) A patch file from https://github.com/void-linux/void-packages/pull/34451.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-dma-34431-34451.patch --] [-- Type: text/x-diff, Size: 1158 bytes --] From f0dd1981a9ddd0c0a1c77e0a1e4b16ae26a22e9a Mon Sep 17 00:00:00 2001 From: Lorenzo Beretta <vc.net.loreb@gmail.com> Date: Thu, 9 Dec 2021 21:46:24 +0100 Subject: [PATCH] dma: fix /etc/dma/*.conf permissions Fixes https://github.com/void-linux/void-packages/issues/34431; solution due to thenktor --- srcpkgs/dma/INSTALL | 1 + srcpkgs/dma/template | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/srcpkgs/dma/INSTALL b/srcpkgs/dma/INSTALL index 88bfc22cca11..e35876f94cf6 100644 --- a/srcpkgs/dma/INSTALL +++ b/srcpkgs/dma/INSTALL @@ -2,6 +2,7 @@ case ${ACTION} in post) # fix permissions and owners chown root:mail usr/bin/dma + chown root:mail etc/dma/auth.conf etc/dma/dma.conf chmod 2755 usr/bin/dma chown root:mail usr/lib/dma-mbox-create chmod 4754 usr/lib/dma-mbox-create diff --git a/srcpkgs/dma/template b/srcpkgs/dma/template index 71892496013f..78c71595ec15 100644 --- a/srcpkgs/dma/template +++ b/srcpkgs/dma/template @@ -1,7 +1,7 @@ # Template file for 'dma' pkgname=dma version=0.13 -revision=3 +revision=4 conf_files="/etc/dma/*.conf" make_dirs="/var/spool/dma 2775 root mail" hostmakedepends="flex"
[-- Attachment #1: Type: text/plain, Size: 518 bytes --] There's a merged pull request on the void-packages repository dma: fix /etc/dma/*.conf permissions https://github.com/void-linux/void-packages/pull/34451 Description: Fixes https://github.com/void-linux/void-packages/issues/34431; solution due to thenktor <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **briefly** #### Local build testing - I built this PR locally for my native architecture, (x86-64-musl)