[PR PATCH] gammastep: update to 2.0.9

[PR PATCH] gammastep: update to 2.0.9

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages gammastep
https://github.com/void-linux/void-packages/pull/39306

gammastep: update to 2.0.9
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39306.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gammastep-39306.patch --]
[-- Type: text/x-diff, Size: 1681 bytes --]

From 77bdfa8a86decec19d1a8f02a65e6e8dd112f9cd Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 15 Sep 2022 12:48:48 -0700
Subject: [PATCH] gammastep: update to 2.0.9

---
 srcpkgs/gammastep/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/gammastep/template b/srcpkgs/gammastep/template
index 1f24e8383904..1124198e2cb8 100644
--- a/srcpkgs/gammastep/template
+++ b/srcpkgs/gammastep/template
@@ -1,8 +1,9 @@
 # Template file for 'gammastep'
 pkgname=gammastep
-version=2.0.8
+version=2.0.9
 revision=1
-wrksrc="${pkgname}-v$version"
+_ref="v$version"
+wrksrc="${pkgname}-$_ref"
 build_style=gnu-configure
 configure_args="--enable-gui --enable-drm --enable-vidmode --enable-randr
  --enable-wayland --enable-apparmor --with-systemduserunitdir=no
@@ -12,12 +13,12 @@ hostmakedepends=" tar automake libtool gettext-devel intltool pkg-config
 makedepends=" wayland-devel libXxf86vm-devel libdrm-devel
  $(vopt_if geoclue2 'glib-devel')"
 short_desc="Adjusts the color temperature of your screen to your surroundings"
-maintainer="Cameron Nemo <cnemo@tutanota.com>"
+maintainer="Cameron Nemo <cam@nohom.org>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/chinstrap/gammastep"
 changelog="https://gitlab.com/chinstrap/gammastep/raw/master/NEWS.md"
-distfiles="${homepage}/-/archive/v$version/${pkgname}-v$version.tar.gz"
-checksum=46535cbeba2ec0e6e18a33f7c1bdec3f520230441e7cdff318d3cf612160bd76
+distfiles="${homepage}/-/archive/$_ref/${pkgname}-$_ref.tar.gz"
+checksum=bbb9d90e1cf30920c1017db4ce5c4652e4c7843fd4c4e34164d99ecbc3bbb4c0
 build_options="geoclue2"
 build_options_default="geoclue2"
 

Re: [PR REVIEW] gammastep: update to 2.0.9

[sgn]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39306#discussion_r973723883

Comment:
I don't think introduce `_ref` is good idea.

Re: [PR REVIEW] gammastep: update to 2.0.9

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/39306#discussion_r973778996

Comment:
I would appreciate an explanation as to why. Underscore variables are simple and improve readability. Furthermore this improves my life as a maintainer, because I can easily test an upstream merge request.

Re: [PR REVIEW] gammastep: update to 2.0.9

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/39306#discussion_r973778996

Comment:
I would appreciate an explanation as to why. From my perspective, underscore variables are simple and improve readability. Furthermore this improves my life as a maintainer, because I can easily test an upstream merge request.

Re: [PR REVIEW] gammastep: update to 2.0.9

[sgn]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39306#discussion_r973808119

Comment:
I supposed it's easier for you to test the rc or some arbitrary commit. Then yes, it would help.
However, it would invite other people to make them too. Then it will be a common pattern, which isn't a good idea.

Anyway, for rc release, can you just append into version? for commit, you can't use it with distfiles anyway.

Re: [PR PATCH] [Updated] gammastep: update to 2.0.9

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages gammastep
https://github.com/void-linux/void-packages/pull/39306

gammastep: update to 2.0.9
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39306.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gammastep-39306.patch --]
[-- Type: text/x-diff, Size: 1707 bytes --]

From c74dc6f0b445a4493d9c9d85c51122306afe9aad Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 15 Sep 2022 12:48:48 -0700
Subject: [PATCH] gammastep: update to 2.0.9

---
 srcpkgs/gammastep/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/gammastep/template b/srcpkgs/gammastep/template
index 1f24e8383904..5c3898dc2d38 100644
--- a/srcpkgs/gammastep/template
+++ b/srcpkgs/gammastep/template
@@ -1,8 +1,8 @@
 # Template file for 'gammastep'
 pkgname=gammastep
-version=2.0.8
+version=2.0.9
 revision=1
-wrksrc="${pkgname}-v$version"
+wrksrc="${pkgname}-v${version}"
 build_style=gnu-configure
 configure_args="--enable-gui --enable-drm --enable-vidmode --enable-randr
  --enable-wayland --enable-apparmor --with-systemduserunitdir=no
@@ -12,12 +12,12 @@ hostmakedepends=" tar automake libtool gettext-devel intltool pkg-config
 makedepends=" wayland-devel libXxf86vm-devel libdrm-devel
  $(vopt_if geoclue2 'glib-devel')"
 short_desc="Adjusts the color temperature of your screen to your surroundings"
-maintainer="Cameron Nemo <cnemo@tutanota.com>"
+maintainer="Cameron Nemo <cam@nohom.org>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/chinstrap/gammastep"
 changelog="https://gitlab.com/chinstrap/gammastep/raw/master/NEWS.md"
-distfiles="${homepage}/-/archive/v$version/${pkgname}-v$version.tar.gz"
-checksum=46535cbeba2ec0e6e18a33f7c1bdec3f520230441e7cdff318d3cf612160bd76
+distfiles="https://gitlab.com/chinstrap/gammastep/-/archive/v${version}/${pkgname}-v${version}.tar.gz"
+checksum=bbb9d90e1cf30920c1017db4ce5c4652e4c7843fd4c4e34164d99ecbc3bbb4c0
 build_options="geoclue2"
 build_options_default="geoclue2"
 

Re: [PR REVIEW] gammastep: update to 2.0.9

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/39306#discussion_r975283581

Comment:
>for commit, you can't use it with distfiles anyway

Not sure what you mean, as I am quite sure I have been able to change a single line for any ref (branch, commit, or tag) versus having to edit three different occurrences to `v$version` without the _ref variable (as shown below). Are you saying that the distfiles will be wrong for the version defined? If so, I do acknowledge that, but I have had no trouble running clean, then re-genning the checksum in those cases.

```diff
@@ -2,7 +2,7 @@
 pkgname=gammastep
 version=2.0.9
 revision=1
-wrksrc="${pkgname}-v${version}"
+wrksrc="${pkgname}-eab8be4fc33e4c4b953252e2a4f24e4f5322b0b1"
 build_style=gnu-configure
 configure_args="--enable-gui --enable-drm --enable-vidmode --enable-randr
  --enable-wayland --enable-apparmor --with-systemduserunitdir=no
@@ -16,8 +16,8 @@ maintainer="Cameron Nemo <cam@nohom.org>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/chinstrap/gammastep"
 changelog="https://gitlab.com/chinstrap/gammastep/raw/master/NEWS.md"
-distfiles="https://gitlab.com/chinstrap/gammastep/-/archive/v${version}/${pkgname}-v${version}.tar.gz"
-checksum=bbb9d90e1cf30920c1017db4ce5c4652e4c7843fd4c4e34164d99ecbc3bbb4c0
+distfiles="https://gitlab.com/chinstrap/gammastep/-/archive/eab8be4fc33e4c4b953252e2a4f24e4f5322b0b1/${pkgname}-eab8be4fc33e4c4b953252e2a4f24e4f5322b0b1.tar.gz"
+checksum=b3a2fb29c076d1af9ffbb6ccc2a32667954ea22cdc23a90747b78355225e43c8
 build_options="geoclue2"
 build_options_default="geoclue2"
```

Regardless, I have reverted the change for now so as not to introduce inconsistencies or bad samples into the ports tree.

Re: [PR PATCH] [Merged]: gammastep: update to 2.0.9

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

There's a merged pull request on the void-packages repository

gammastep: update to 2.0.9
https://github.com/void-linux/void-packages/pull/39306

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->