Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] vim: build with +sodium feature
@ 2022-09-11  5:31 atweiden
  2022-09-12  1:58 ` sgn
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: atweiden @ 2022-09-11  5:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

There is a new pull request by atweiden against master on the void-packages repository

https://github.com/atweiden/void-packages vim-libsodium
https://github.com/void-linux/void-packages/pull/39225

vim: build with +sodium feature
    xchacha20  XChaCha20 Cipher with Poly1305 Message Authentication
     Code.  Medium strong till strong encryption.
     Encryption is provided by the libsodium library, it
     requires Vim to be built with |+sodium|.
     It adds a seed and a message authentication code (MAC)
     to the file.  This needs at least a Vim 8.2.3022 to
     read the encrypted file.
     Encryption of swap files is not supported, therefore
     no swap file will be used when xchacha20 encryption is
     enabled.
     Encryption of undo files is not yet supported,
     therefore no undo file will currently be written.
     CURRENTLY EXPERIMENTAL: Files written with this method
     might have to be read back with the same version of
     Vim if the binary format changes later.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39225.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vim-libsodium-39225.patch --]
[-- Type: text/x-diff, Size: 2003 bytes --]

From 1de150f9d14c90ece66cb521af762c33dc55041b Mon Sep 17 00:00:00 2001
From: Andy Weidenbaum <atweiden@ioiojo.com>
Date: Sun, 11 Sep 2022 15:30:24 +1000
Subject: [PATCH] vim: build with +sodium feature

    xchacha20  XChaCha20 Cipher with Poly1305 Message Authentication
     Code.  Medium strong till strong encryption.
     Encryption is provided by the libsodium library, it
     requires Vim to be built with |+sodium|.
     It adds a seed and a message authentication code (MAC)
     to the file.  This needs at least a Vim 8.2.3022 to
     read the encrypted file.
     Encryption of swap files is not supported, therefore
     no swap file will be used when xchacha20 encryption is
     enabled.
     Encryption of undo files is not yet supported,
     therefore no undo file will currently be written.
     CURRENTLY EXPERIMENTAL: Files written with this method
     might have to be read back with the same version of
     Vim if the binary format changes later.
---
 srcpkgs/vim/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/vim/template b/srcpkgs/vim/template
index 4357914ae8e9..aaa5f00aec99 100644
--- a/srcpkgs/vim/template
+++ b/srcpkgs/vim/template
@@ -1,9 +1,9 @@
 # Template file for 'vim'
 pkgname=vim
 version=9.0.0335
-revision=1
+revision=2
 hostmakedepends="gettext glib-devel pkg-config"
-makedepends="acl-devel ncurses-devel
+makedepends="acl-devel libsodium-devel ncurses-devel
  $(vopt_if x11 libXt-devel)
  $(vopt_if gtk3 gtk+3-devel)
  $(vopt_if huge 'lua53-devel perl python3-devel ruby-devel')"
@@ -40,8 +40,8 @@ pre_configure() {
 }
 
 do_configure() {
-	args="--enable-cscope --enable-multibyte --with-tlib=ncursesw
-		--with-ex-name=vim-ex --with-view-name=vim-view"
+	args="--enable-cscope --enable-libsodium --enable-multibyte
+		--with-tlib=ncursesw --with-ex-name=vim-ex --with-view-name=vim-view"
 
 	nohuge_args="--disable-perlinterp --disable-pythoninterp
 		--disable-rubyinterp --disable-netbeans --disable-gpm"

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
@ 2022-09-12  1:58 ` sgn
  2022-09-12 11:36 ` atweiden
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: sgn @ 2022-09-12  1:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1243124537

Comment:
```
CURRENTLY EXPERIMENTAL: Files written with this method
 might have to be read back with the same version of
 Vim if the binary format changes later.
```

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
  2022-09-12  1:58 ` sgn
@ 2022-09-12 11:36 ` atweiden
  2022-09-12 11:36 ` atweiden
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: atweiden @ 2022-09-12 11:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1243611721

Comment:
Experimental status looks ... warranted https://github.com/vim/vim/pull/8394.

I don’t see the problem with including, as this `crypmethod=xchacha0` isn’t done by default. It’s an opt-in setting, and there are several `cryptmethod`s to choose from.

(Are there really no other programsin this repo with experimental opt-in features activated as of the current time?)

I’ll leave the decision to close up to someone else.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
  2022-09-12  1:58 ` sgn
  2022-09-12 11:36 ` atweiden
@ 2022-09-12 11:36 ` atweiden
  2022-09-12 11:37 ` atweiden
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: atweiden @ 2022-09-12 11:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1243611721

Comment:
Experimental status looks ... warranted https://github.com/vim/vim/pull/8394.

I don’t see the problem with including, as this `crypmethod=xchacha20` isn’t done by default. It’s an opt-in setting, and there are several `cryptmethod`s to choose from.

(Are there really no other programsin this repo with experimental opt-in features activated as of the current time?)

I’ll leave the decision to close up to someone else.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
                   ` (2 preceding siblings ...)
  2022-09-12 11:36 ` atweiden
@ 2022-09-12 11:37 ` atweiden
  2022-09-12 11:37 ` atweiden
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: atweiden @ 2022-09-12 11:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1243611721

Comment:
Experimental status looks ... warranted https://github.com/vim/vim/pull/8394.

I don’t see the problem with including, as this `cryptmethod=xchacha20` isn’t done by default. It’s an opt-in setting, and there are several `cryptmethod`s to choose from.

(Are there really no other programsin this repo with experimental opt-in features activated as of the current time?)

I’ll leave the decision to close up to someone else.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
                   ` (3 preceding siblings ...)
  2022-09-12 11:37 ` atweiden
@ 2022-09-12 11:37 ` atweiden
  2022-09-12 11:37 ` atweiden
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: atweiden @ 2022-09-12 11:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1243611721

Comment:
Experimental status looks ... warranted https://github.com/vim/vim/pull/8394.

I don’t see the problem with including, as this `cryptmethod=xchacha20` isn’t done by default. It’s an opt-in setting, and there are several `cryptmethod`s to choose from.

(Are there really no other programs in this repo with experimental opt-in features activated as of the current time?)

I’ll leave the decision to close up to someone else.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
                   ` (4 preceding siblings ...)
  2022-09-12 11:37 ` atweiden
@ 2022-09-12 11:37 ` atweiden
  2022-09-12 13:16 ` sgn
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: atweiden @ 2022-09-12 11:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1243611721

Comment:
Experimental status looks ... warranted https://github.com/vim/vim/pull/8394.

I don’t see the problem with including, as this `cryptmethod=xchacha20` isn’t done by default. It’s an opt-in setting, and there are several `cryptmethod`s to choose from.

(Are there really no other programs in this repo with experimental opt-in features built as part of the software at the current time?)

I’ll leave the decision to close up to someone else.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
                   ` (5 preceding siblings ...)
  2022-09-12 11:37 ` atweiden
@ 2022-09-12 13:16 ` sgn
  2022-09-12 23:26 ` atweiden
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: sgn @ 2022-09-12 13:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1243727276

Comment:
You're trying to enable this experimental feature on for everyone, not an opt-in for someone.
In addition:
```
Files written with this method
 might have to be read back with the same version of
 Vim if the binary format changes later
```

I (personally) don't want to see bug report for vim `x.y.z` can't read some binaries produced by vim `a.b.c`.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
                   ` (6 preceding siblings ...)
  2022-09-12 13:16 ` sgn
@ 2022-09-12 23:26 ` atweiden
  2022-09-20 15:24 ` leahneukirchen
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: atweiden @ 2022-09-12 23:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1244705605

Comment:
> You're trying to enable this experimental feature on for everyone, not an opt-in for someone.

Perhaps I’ve miscommunicated.

`--enable-libsodium` at compile time doesn’t activate `cryptmethod=xchacha20` at runtime.

Vim’s `cryptmethod` is a user setting. This setting is disabled by default.

All `--enable-libsodium` does at compile time is allow users to, at runtime, *opt in* to using xchacha20+poly1305 to encrypt a file via running `:set cryptmethod=xchacha20`. This is as opposed to users being limited to running e.g. `:set cryptmethod=blowfish2`. Neither of these commands is ever run in the course of normal Vim operation.

> I (personally) don't want to see bug report for vim `x.y.z` can't read some binaries produced by vim `a.b.c`.

In the worst case scenario, users can 1) compile a specific version of Vim before compatibility was broken either through `xbps-src` or manually, 2) decrypt the affected files, 3) re-install Vim via `xbps-install` if necessary, and 4) re-encrypt the affected files with the new version of Vim. This is relatively easy to accomplish, and would only affect users who elected to run `:set cryptmethod=xchacha20`.

That may sound like a lot, but Vim compiles relatively quickly and easily, and the feature comes with a clear warning in its documentation. If Vim’s xchacha20 implementation breaks between versions upstream, it wouldn’t be a valid reason to veer from the existing void-packages strategy of steadily updating the Vim template.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
                   ` (7 preceding siblings ...)
  2022-09-12 23:26 ` atweiden
@ 2022-09-20 15:24 ` leahneukirchen
  2022-12-20  1:58 ` github-actions
  2023-01-04  1:59 ` [PR PATCH] [Closed]: " github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: leahneukirchen @ 2022-09-20 15:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1252523337

Comment:
I'm not super against this, but I consider vim-gnupg the better solution.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
                   ` (8 preceding siblings ...)
  2022-09-20 15:24 ` leahneukirchen
@ 2022-12-20  1:58 ` github-actions
  2023-01-04  1:59 ` [PR PATCH] [Closed]: " github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2022-12-20  1:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/39225#issuecomment-1358728635

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Closed]: vim: build with +sodium feature
  2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
                   ` (9 preceding siblings ...)
  2022-12-20  1:58 ` github-actions
@ 2023-01-04  1:59 ` github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2023-01-04  1:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]

There's a closed pull request on the void-packages repository

vim: build with +sodium feature
https://github.com/void-linux/void-packages/pull/39225

Description:
    xchacha20  XChaCha20 Cipher with Poly1305 Message Authentication
     Code.  Medium strong till strong encryption.
     Encryption is provided by the libsodium library, it
     requires Vim to be built with |+sodium|.
     It adds a seed and a message authentication code (MAC)
     to the file.  This needs at least a Vim 8.2.3022 to
     read the encrypted file.
     Encryption of swap files is not supported, therefore
     no swap file will be used when xchacha20 encryption is
     enabled.
     Encryption of undo files is not yet supported,
     therefore no undo file will currently be written.
     CURRENTLY EXPERIMENTAL: Files written with this method
     might have to be read back with the same version of
     Vim if the binary format changes later.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-01-04  1:59 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-11  5:31 [PR PATCH] vim: build with +sodium feature atweiden
2022-09-12  1:58 ` sgn
2022-09-12 11:36 ` atweiden
2022-09-12 11:36 ` atweiden
2022-09-12 11:37 ` atweiden
2022-09-12 11:37 ` atweiden
2022-09-12 11:37 ` atweiden
2022-09-12 13:16 ` sgn
2022-09-12 23:26 ` atweiden
2022-09-20 15:24 ` leahneukirchen
2022-12-20  1:58 ` github-actions
2023-01-04  1:59 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).