Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] fceux: upgrade to version 2.6.4
@ 2022-09-20 22:08 tm512
  2022-09-20 22:11 ` paper42
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: tm512 @ 2022-09-20 22:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

There is a new pull request by tm512 against master on the void-packages repository

https://github.com/tm512/void-packages fceux
https://github.com/void-linux/void-packages/pull/39396

fceux: upgrade to version 2.6.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/39396.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fceux-39396.patch --]
[-- Type: text/x-diff, Size: 960 bytes --]

From 42582660c88d7377a6d18a6ee83951958382acd2 Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Tue, 20 Sep 2022 14:07:33 -0700
Subject: [PATCH] fceux: upgrade to version 2.6.4

---
 srcpkgs/fceux/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/fceux/template b/srcpkgs/fceux/template
index 594db8244772..2ef6d264ee8b 100644
--- a/srcpkgs/fceux/template
+++ b/srcpkgs/fceux/template
@@ -1,6 +1,6 @@
 # Template file for 'fceux'
 pkgname=fceux
-version=2.4.0
+version=2.6.4
 revision=1
 wrksrc="fceux-fceux-$version"
 build_style=cmake
@@ -11,4 +11,4 @@ maintainer="bra1nwave <brainwave@openmailbox.org>"
 license="GPL-2.0-or-later"
 homepage="https://fceux.com/web/home.html"
 distfiles="https://github.com/TASVideos/fceux/archive/fceux-${version}.tar.gz"
-checksum=a5b8749c80aac5a847348992b6a0b1ee964dbc173fe980bb95587d04aca39bc0
+checksum=7211d768b6b973ebb161bffb823b81dad97e96354ee0a61bb69ff33520def87a

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fceux: upgrade to version 2.6.4
  2022-09-20 22:08 [PR PATCH] fceux: upgrade to version 2.6.4 tm512
@ 2022-09-20 22:11 ` paper42
  2022-09-20 22:22 ` tm512
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-09-20 22:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39396#issuecomment-1252969242

Comment:
commit message doesn't follow the style from CONTRIBUTING.md

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fceux: upgrade to version 2.6.4
  2022-09-20 22:08 [PR PATCH] fceux: upgrade to version 2.6.4 tm512
  2022-09-20 22:11 ` paper42
@ 2022-09-20 22:22 ` tm512
  2022-09-20 22:26 ` classabbyamp
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: tm512 @ 2022-09-20 22:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/39396#issuecomment-1252977670

Comment:
Is this really going to be held up over a missing period? I see multiple commits in the log that use exactly the formatting that I've used. Either way, I'm not sure how to revise a commit message after a pull request is already opened. I'm guessing a force push would leave this pull request's ref dangling.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fceux: upgrade to version 2.6.4
  2022-09-20 22:08 [PR PATCH] fceux: upgrade to version 2.6.4 tm512
  2022-09-20 22:11 ` paper42
  2022-09-20 22:22 ` tm512
@ 2022-09-20 22:26 ` classabbyamp
  2022-09-20 22:28 ` tm512
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-09-20 22:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39396#issuecomment-1252979835

Comment:
it's not the missing period, the [format](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes) is `<pkgname>: update to <version>` not `<pkgname>: upgrade to version <version>`

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fceux: upgrade to version 2.6.4
  2022-09-20 22:08 [PR PATCH] fceux: upgrade to version 2.6.4 tm512
                   ` (2 preceding siblings ...)
  2022-09-20 22:26 ` classabbyamp
@ 2022-09-20 22:28 ` tm512
  2022-09-20 22:29 ` classabbyamp
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: tm512 @ 2022-09-20 22:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/39396#issuecomment-1252981346

Comment:
Alright, how can I change that? Do I need to close this and open a new pull request after force-pushing a revision to my fork?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fceux: upgrade to version 2.6.4
  2022-09-20 22:08 [PR PATCH] fceux: upgrade to version 2.6.4 tm512
                   ` (3 preceding siblings ...)
  2022-09-20 22:28 ` tm512
@ 2022-09-20 22:29 ` classabbyamp
  2022-09-20 22:32 ` [PR PATCH] [Updated] " tm512
  2022-09-22  2:45 ` [PR PATCH] [Merged]: " classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-09-20 22:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39396#issuecomment-1252981902

Comment:
just `git commit --amend; git push --force` is enough

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] fceux: upgrade to version 2.6.4
  2022-09-20 22:08 [PR PATCH] fceux: upgrade to version 2.6.4 tm512
                   ` (4 preceding siblings ...)
  2022-09-20 22:29 ` classabbyamp
@ 2022-09-20 22:32 ` tm512
  2022-09-22  2:45 ` [PR PATCH] [Merged]: " classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: tm512 @ 2022-09-20 22:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

There is an updated pull request by tm512 against master on the void-packages repository

https://github.com/tm512/void-packages fceux
https://github.com/void-linux/void-packages/pull/39396

fceux: upgrade to version 2.6.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/39396.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fceux-39396.patch --]
[-- Type: text/x-diff, Size: 952 bytes --]

From 348d88ededfc0c9f06ca99dbe8107fdf3f6a465d Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Tue, 20 Sep 2022 14:07:33 -0700
Subject: [PATCH] fceux: update to 2.6.4.

---
 srcpkgs/fceux/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/fceux/template b/srcpkgs/fceux/template
index 594db8244772..2ef6d264ee8b 100644
--- a/srcpkgs/fceux/template
+++ b/srcpkgs/fceux/template
@@ -1,6 +1,6 @@
 # Template file for 'fceux'
 pkgname=fceux
-version=2.4.0
+version=2.6.4
 revision=1
 wrksrc="fceux-fceux-$version"
 build_style=cmake
@@ -11,4 +11,4 @@ maintainer="bra1nwave <brainwave@openmailbox.org>"
 license="GPL-2.0-or-later"
 homepage="https://fceux.com/web/home.html"
 distfiles="https://github.com/TASVideos/fceux/archive/fceux-${version}.tar.gz"
-checksum=a5b8749c80aac5a847348992b6a0b1ee964dbc173fe980bb95587d04aca39bc0
+checksum=7211d768b6b973ebb161bffb823b81dad97e96354ee0a61bb69ff33520def87a

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: fceux: upgrade to version 2.6.4
  2022-09-20 22:08 [PR PATCH] fceux: upgrade to version 2.6.4 tm512
                   ` (5 preceding siblings ...)
  2022-09-20 22:32 ` [PR PATCH] [Updated] " tm512
@ 2022-09-22  2:45 ` classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-09-22  2:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

There's a merged pull request on the void-packages repository

fceux: upgrade to version 2.6.4
https://github.com/void-linux/void-packages/pull/39396

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-09-22  2:45 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 22:08 [PR PATCH] fceux: upgrade to version 2.6.4 tm512
2022-09-20 22:11 ` paper42
2022-09-20 22:22 ` tm512
2022-09-20 22:26 ` classabbyamp
2022-09-20 22:28 ` tm512
2022-09-20 22:29 ` classabbyamp
2022-09-20 22:32 ` [PR PATCH] [Updated] " tm512
2022-09-22  2:45 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).