[PR PATCH] caffeine-ng: add libappindicator as a runtime dependency.

[PR PATCH] caffeine-ng: add libappindicator as a runtime dependency.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages caffeine-ng
https://github.com/void-linux/void-packages/pull/39334

caffeine-ng: add libappindicator as a runtime dependency.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39334.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-caffeine-ng-39334.patch --]
[-- Type: text/x-diff, Size: 1054 bytes --]

From 377250073417fe61cab4eb0392aac20b384493bf Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 18 Sep 2022 13:16:06 +0300
Subject: [PATCH] caffeine-ng: add libappindicator as a runtime dependency.

---
 srcpkgs/caffeine-ng/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/caffeine-ng/template b/srcpkgs/caffeine-ng/template
index 1c150749e6d8..a1c05470097f 100644
--- a/srcpkgs/caffeine-ng/template
+++ b/srcpkgs/caffeine-ng/template
@@ -1,13 +1,13 @@
 # Template file for 'caffeine-ng'
 pkgname=caffeine-ng
 version=4.0.2
-revision=1
+revision=2
 build_style=python3-module
 hostmakedepends="python3-setuptools_scm"
 depends="desktop-file-utils gtk+3 hicolor-icon-theme libnotify
  python3-dbus python3-click python3-ewmh python3-gobject
  python3-setproctitle python3-setuptools python3-xdg
- python3-pulsectl"
+ python3-pulsectl libappindicator"
 short_desc="Temporarily inhibits the screensaver and sleep mode"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"

Re: caffeine-ng: add libappindicator as a runtime dependency.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/39334#issuecomment-1250263748

Comment:
I refrained from adding it when I last updated this package as it introduces a python2 transitive dependency (makedepends). I saw in the [changelog](https://codeberg.org/WhyNotHugo/caffeine-ng/src/branch/main/CHANGELOG.rst) that in the next version it would use `ayatana-appindicator3` (aka [libindicator](https://github.com/void-linux/void-packages/tree/master/srcpkgs/libindicator)) so decided to wait for it instead.

Re: caffeine-ng: add libappindicator as a runtime dependency.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/39334#issuecomment-1250344942

Comment:
> I refrained from adding it when I last updated this package as it introduces a python2 transitive dependency (makedepends). I saw in the [changelog](https://codeberg.org/WhyNotHugo/caffeine-ng/src/branch/main/CHANGELOG.rst) that in the next version it would use `ayatana-appindicator3` (aka [libindicator](https://github.com/void-linux/void-packages/tree/master/srcpkgs/libindicator)) so decided to wait for it instead.

I am not disputing any of this, but it does not work for me without libappindicator (fresh void install, xfce with status panel plugin) :(

Re: caffeine-ng: add libappindicator as a runtime dependency.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/39334#issuecomment-1250344942

Comment:
> I refrained from adding it when I last updated this package as it introduces a python2 transitive dependency (makedepends). I saw in the [changelog](https://codeberg.org/WhyNotHugo/caffeine-ng/src/branch/main/CHANGELOG.rst) that in the next version it would use `ayatana-appindicator3` (aka [libindicator](https://github.com/void-linux/void-packages/tree/master/srcpkgs/libindicator)) so decided to wait for it instead.

I am not disputing any of this, but it does not work for me without libappindicator (fresh void install, xfce with status panel plugin) :(
Maybe havin an install message will be a better solution?

Re: caffeine-ng: add libappindicator as a runtime dependency.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/39334#issuecomment-1250344942

Comment:
> I refrained from adding it when I last updated this package as it introduces a python2 transitive dependency (makedepends). I saw in the [changelog](https://codeberg.org/WhyNotHugo/caffeine-ng/src/branch/main/CHANGELOG.rst) that in the next version it would use `ayatana-appindicator3` (aka [libindicator](https://github.com/void-linux/void-packages/tree/master/srcpkgs/libindicator)) so decided to wait for it instead.

I am not disputing any of this, but it does not work for me without libappindicator (fresh void install, xfce with status panel plugin) :(
Maybe having an install message will be a better solution?

Re: caffeine-ng: add libappindicator as a runtime dependency.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/39334#issuecomment-1250346334

Comment:
I think fine to add for now, can be replace with `libindicator` for later version updates.

Re: [PR PATCH] [Merged]: caffeine-ng: add libappindicator as a runtime dependency.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

There's a merged pull request on the void-packages repository

caffeine-ng: add libappindicator as a runtime dependency.
https://github.com/void-linux/void-packages/pull/39334

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->