From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] kore: fix build for Python 3.11 (not ready yet)
Date: Thu, 22 Sep 2022 15:49:40 +0200 [thread overview]
Message-ID: <20220922134940.frSSbD-87SK6ErCQ3_dI-asFGakVwv79UYc7fCvMpXg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39413@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/39413#discussion_r977681846
Comment:
It turns out that my previous recommendation for strictly less than is irrelevant because the release version will be `0x030B0F00` and the current RC should be `0x030B0C02`, so both are greater than the cutoff anyway. I misread the explanation of the hex versioning scheme and expected the release to be 0x30B00000`.
I'd say make this strictly less than for consistency and mathematical correctness.
next prev parent reply other threads:[~2022-09-22 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 1:06 [PR PATCH] " sgn
2022-09-22 1:08 ` [PR PATCH] [Updated] " sgn
2022-09-22 8:24 ` sgn
2022-09-22 10:20 ` sgn
2022-09-22 10:51 ` [PR REVIEW] " ahesford
2022-09-22 10:55 ` [PR PATCH] [Updated] " sgn
2022-09-22 11:02 ` sgn
2022-09-22 13:49 ` ahesford [this message]
2022-09-26 14:18 ` sgn
2022-09-26 14:18 ` [PR PATCH] [Closed]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922134940.frSSbD-87SK6ErCQ3_dI-asFGakVwv79UYc7fCvMpXg@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).