Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: Compile terminfo description when building
Date: Sat, 01 Oct 2022 23:51:29 +0200	[thread overview]
Message-ID: <20221001215129.xag-zHxUS8exkkkskXjpvzCbb4mWH_ZhL9TI6xuHipA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38179@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

There's a merged pull request on the void-packages repository

Compile terminfo description when building
https://github.com/void-linux/void-packages/pull/38179

Description:
Some `*-terminfo` packages do not actually provide compiled terminal descriptions, but only the source file. They then have to compile it with `tic` in `INSTALL` and then remove in in `REMOVE`. This approach is more complicated, adds `ncurses` (the provider of `tic`) as a runtime dependency of these packages and it has to explicitly specify completions to remove from `/usr/share/terminfo` (I've already had to add missing ones to `st-terminfo` in #33116 because some were missing).

As far as I know this approach doesn't have any advantages over just compiling the terminfo files and then shipping them in the package. If compiling these files "locally" has some purpose than please comment here and explain.

The presence of terminfo files that haven't been compiled in `/usr/share/terminfo` can also confuse some programs. For example when I install all packages which this PR modifies and then run `toe > /dev/null`, it shows:
```
toe: couldn't open terminfo file xst.terminfo.
toe: couldn't open terminfo file st.terminfo.
toe: couldn't open terminfo file rxvt-unicode.terminfo.
toe: couldn't open terminfo file mtm.ti.
toe: couldn't open terminfo file dvtm.info.
toe: couldn't open terminfo file alacritty.info.
```

I've also tried to simplify the templates I've been working with and I've adopted `st` because I'm an active user of it. And does `st` really depend on `ncurses`? I didn't want to mess with this but it could be possible that this dependency was added because of terminfo generation before `st` and `st-terminfo` were separate packages.

Ping @thypon (maintainer of `alacritty`)
Ping @travankor (maintainer of `mtm`)
Ping @leahneukirchen (maintainer of `rxvt-unicode`)
Ping @ndowens (maintainer of `xst`)
Ping @erwin

#### Testing the changes
- I tested the changes in this PR: **briefly**

closes #34392

      parent reply	other threads:[~2022-10-01 21:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 22:04 [PR PATCH] " meator
2022-07-21 22:11 ` [PR PATCH] [Updated] " meator
2022-07-22  5:27 ` meator
2022-07-22  5:47 ` meator
2022-07-22  5:51 ` classabbyamp
2022-07-22  7:25 ` meator
2022-07-22 13:53 ` paper42
2022-07-22 13:54 ` paper42
2022-07-22 17:39 ` [PR PATCH] [Updated] " meator
2022-07-22 17:41 ` meator
2022-07-22 17:41 ` meator
2022-07-22 17:48 ` meator
2022-07-22 17:57 ` [PR PATCH] [Updated] " meator
2022-07-22 17:59 ` meator
2022-07-23 15:08 ` sgn
2022-07-23 21:02 ` [PR PATCH] [Updated] " meator
2022-09-30  0:28 ` classabbyamp
2022-09-30 17:20 ` meator
2022-09-30 17:21 ` [PR PATCH] [Updated] " meator
2022-09-30 20:12 ` classabbyamp
2022-09-30 20:14 ` classabbyamp
2022-10-01 13:08 ` [PR PATCH] [Updated] " meator
2022-10-01 16:21 ` classabbyamp
2022-10-01 16:45 ` [PR PATCH] [Updated] " meator
2022-10-01 16:48 ` meator
2022-10-01 21:51 ` classabbyamp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221001215129.xag-zHxUS8exkkkskXjpvzCbb4mWH_ZhL9TI6xuHipA@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).