From: dmarto <dmarto@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: libfido2: switch udev rules back to 'plugdev', revbump
Date: Tue, 04 Oct 2022 15:12:58 +0200 [thread overview]
Message-ID: <20221004131258._zXywghFawBcY7U-ReX2hCRDw3O_0IlVkMY3kCHAoRI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39688@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266927505
Comment:
Ok, I tried my best, this is what I figured:
- we want to keep the old rules file, for people that have it
- the new one should NOT overwrite it
```diff
diff --git a/srcpkgs/libfido2/template b/srcpkgs/libfido2/template
index a5127f2ea6..7472dc44ab 100644
--- a/srcpkgs/libfido2/template
+++ b/srcpkgs/libfido2/template
@@ -14,14 +14,16 @@ changelog="https://raw.githubusercontent.com/Yubico/libfido2/main/NEWS"
distfiles="https://github.com/Yubico/libfido2/archive/${version}.tar.gz"
checksum=813d6d25116143d16d2e96791718a74825da16b774a8d093d96f06ae1730d9c5
# udev rules used to be shipped by libu2f-host
-conf_files="/usr/lib/udev/rules.d/70-u2f.rules"
conflicts="libu2f-host<=1.1.10_3"
+# keep the old 70-u2f.rules
+preserve=yes
post_extract() {
vsed -i -e '/add_compile_options(-Werror)/d' CMakeLists.txt
}
post_install() {
+ mv ${DESTDIR}/usr/lib/udev/rules.d/{70-u2f.rules,69-u2f-plugdev.rules}
vlicense LICENSE
}
```
I am not sure if this is a good solution or not; I would love any help or suggestions you may have.
next prev parent reply other threads:[~2022-10-04 13:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 0:48 [PR PATCH] " dmarto
2022-10-04 0:55 ` classabbyamp
2022-10-04 1:11 ` dmarto
2022-10-04 1:12 ` dmarto
2022-10-04 2:07 ` 0x5c
2022-10-04 12:35 ` dmarto
2022-10-04 12:52 ` leahneukirchen
2022-10-04 13:12 ` dmarto [this message]
2022-10-04 15:16 ` classabbyamp
2022-10-04 15:56 ` dmarto
2022-10-04 16:14 ` dmarto
2022-10-05 14:47 ` CameronNemo
2022-10-08 22:54 ` dmarto
2022-10-08 22:57 ` dmarto
2022-10-08 23:16 ` [PR PATCH] [Updated] " dmarto
2022-10-08 23:19 ` dmarto
2022-10-09 6:08 ` libfido2: add INSTALL.msg, revbump 0x5c
2022-10-09 6:09 ` classabbyamp
2022-10-09 11:30 ` leahneukirchen
2022-11-13 0:30 ` dmarto
2022-11-13 3:46 ` libfido2: switch udev rules to the `plugdev` group 0x5c
2022-11-13 15:38 ` CameronNemo
2023-02-12 2:01 ` github-actions
2023-02-26 2:06 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004131258._zXywghFawBcY7U-ReX2hCRDw3O_0IlVkMY3kCHAoRI@z \
--to=dmarto@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).