Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Python3 keyring
@ 2022-09-28 10:10 icp1994
  2022-10-04 14:32 ` [PR REVIEW] python3-keyring: update to 23.9.3 ahesford
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: icp1994 @ 2022-09-28 10:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-keyring
https://github.com/void-linux/void-packages/pull/39502

Python3 keyring
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Rev dep checks
- [x] Komikku
- [x] backintime
- [x] coursera-dl
- [x] cura
- [x] gajim
- [x] hatch
- [x] jrnl
- [x] mcg
- [x] nagstamon
- [x] pantalaimon
- [x] python3-keyrings-alt
- [x] urlwatch

A patch file from https://github.com/void-linux/void-packages/pull/39502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-keyring-39502.patch --]
[-- Type: text/x-diff, Size: 6082 bytes --]

From e8ed6d7e081572726e80a1413d494e9dc1b61b99 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 22 Sep 2022 01:29:51 +0530
Subject: [PATCH 1/3] python3-keyring: update to 23.9.3.

Adopt.
---
 srcpkgs/python3-keyring/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/python3-keyring/template b/srcpkgs/python3-keyring/template
index 35b44a7380a2..908e160000ec 100644
--- a/srcpkgs/python3-keyring/template
+++ b/srcpkgs/python3-keyring/template
@@ -1,20 +1,19 @@
 # Template file for 'python3-keyring'
 pkgname=python3-keyring
-version=23.7.0
+version=23.9.3
 revision=1
 wrksrc="keyring-${version}"
 build_style=python3-pep517
 hostmakedepends="python3-wheel python3-setuptools_scm"
-depends="python3-SecretStorage"
-checkdepends="python3-pytest
- python3-pytest-flake8 python3-pytest-cov"
+depends="python3-SecretStorage python3-jeepney python3-jaraco.classes"
+checkdepends="${depends} python3-pytest-xdist"
 short_desc="Python interface to the system keyring service"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="icp <pangolin@vivaldi.net>"
 license="MIT"
 homepage="https://github.com/jaraco/keyring"
 changelog="https://raw.githubusercontent.com/jaraco/keyring/master/CHANGES.rst"
 distfiles="${PYPI_SITE}/k/keyring/keyring-${version}.tar.gz"
-checksum=782e1cd1132e91bf459fcd243bcf25b326015c1ac0b198e4408f91fa6791062b
+checksum=69b01dd83c42f590250fe7a1f503fc229b14de83857314b1933a3ddbf595c4a5
 
 post_install() {
 	vlicense LICENSE

From c91c06bcde1859c7a44a65af6af0fa9cd9b0cd5d Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 24 Sep 2022 01:08:00 +0530
Subject: [PATCH 2/3] Komikku: fix appdata file

---
 srcpkgs/Komikku/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index 0b66eb387e75..42d2b1ec2854 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -1,7 +1,7 @@
 # Template file for 'Komikku'
 pkgname=Komikku
 version=0.40.0
-revision=1
+revision=2
 wrksrc=Komikku-v${version}
 build_style=meson
 hostmakedepends="gettext glib-devel gobject-introspection pkg-config"
@@ -14,6 +14,10 @@ checkdepends="appstream-glib desktop-file-utils"
 short_desc="Online/offline manga reader for GNOME"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
-homepage="https://gitlab.com/valos/Komikku"
+homepage="https://valos.gitlab.io/Komikku/"
 distfiles="https://gitlab.com/valos/Komikku/-/archive/v${version}/Komikku-v${version}.tar.gz"
 checksum=66ed0aa3f4a7bcf049d2263befda42d3740a24662c40c56eeda5c8a06a043534
+
+post_extract() { # should be removed when updating to version>=1.0.0
+	vsed -e "s|Komikku/raw/master/|Komikku/raw/main/|g" -i data/info.febvre.Komikku.appdata.xml.in
+}

From f3168efb5740077b5777c60f1c61319585dc453f Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 24 Sep 2022 01:34:48 +0530
Subject: [PATCH 3/3] coursera-dl: patch for python3>=3.9

---
 .../patches/fix-upstream-issue-778.patch      | 48 +++++++++++++++++++
 srcpkgs/coursera-dl/template                  |  8 ++--
 2 files changed, 52 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch

diff --git a/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch b/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch
new file mode 100644
index 000000000000..659d936a9c43
--- /dev/null
+++ b/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch
@@ -0,0 +1,48 @@
+From c8796e567698be166cb15f54e095140c1a9b567e Mon Sep 17 00:00:00 2001
+From: "Heino H. Gehlsen" <heino@gehlsen.dk>
+Date: Sun, 27 Dec 2020 13:28:35 +0100
+Subject: [PATCH] Fix AttributeError: 'HTMLParser' object has no attribute
+ 'unescape'
+
+https://github.com/coursera-dl/coursera-dl/pull/789
+---
+ coursera/utils.py | 12 +++++++-----
+ 1 file changed, 7 insertions(+), 5 deletions(-)
+
+diff --git a/coursera/utils.py b/coursera/utils.py
+index 9ba577af..f271bb9f 100644
+--- a/coursera/utils.py
++++ b/coursera/utils.py
+@@ -21,7 +21,11 @@
+ 
+ import six
+ from six import iteritems
+-from six.moves import html_parser
++if six.PY34:
++    import html
++else:
++    from six.moves import html_parser
++    html = html_parser.HTMLParser()
+ from six.moves.urllib.parse import ParseResult
+ from six.moves.urllib_parse import unquote_plus
+ 
+@@ -98,8 +102,7 @@ def random_string(length):
+ 
+ 
+ def unescape_html(s):
+-    h = html_parser.HTMLParser()
+-    s = h.unescape(s)
++    s = html.unescape(s)
+     s = unquote_plus(s)
+     return unescape(s, HTML_UNESCAPE_TABLE)
+ 
+@@ -114,8 +117,7 @@ def clean_filename(s, minimal_change=False):
+     """
+ 
+     # First, deal with URL encoded strings
+-    h = html_parser.HTMLParser()
+-    s = h.unescape(s)
++    s = html.unescape(s)
+     s = unquote_plus(s)
+ 
+     # Strip forbidden characters
diff --git a/srcpkgs/coursera-dl/template b/srcpkgs/coursera-dl/template
index 9c569678e49c..a79cecd680d1 100644
--- a/srcpkgs/coursera-dl/template
+++ b/srcpkgs/coursera-dl/template
@@ -1,16 +1,16 @@
 # Template file for 'coursera-dl'
 pkgname=coursera-dl
 version=0.11.5
-revision=3
+revision=4
 build_style=python3-module
-pycompile_module="coursera"
 hostmakedepends="python3-setuptools"
 depends="python3-attrs python3-setuptools python3-pyasn1 python3-ConfigArgParse
  python3-BeautifulSoup4 python3-requests python3-six python3-keyring
  python3-urllib3"
+checkdepends="${depends} python3-keyrings-alt python3-mock python3-pytest-xdist"
 short_desc="Script for downloading Coursera.org videos and naming them"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-3.0-or-later"
 homepage="https://github.com/coursera-dl/coursera-dl"
-distfiles="${PYPI_SITE}/c/coursera-dl/coursera-dl-${version}.tar.gz"
-checksum=66a84558dfcfcbdc487dcabcfc0d7c4a8569cc604b051b1d51bc95d52a369745
+distfiles="https://github.com/coursera-dl/coursera-dl/archive/refs/tags/${version}.tar.gz"
+checksum=27e382435084ec91ef89ab6c1d46f4756b708e4badf5307a8f18b9ad31971014

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
@ 2022-10-04 14:32 ` ahesford
  2022-10-04 14:32 ` ahesford
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ahesford @ 2022-10-04 14:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39502#discussion_r986945804

Comment:
Please make this a proper patch so it will fail to apply when it shoudl be removed.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
  2022-10-04 14:32 ` [PR REVIEW] python3-keyring: update to 23.9.3 ahesford
@ 2022-10-04 14:32 ` ahesford
  2022-10-04 14:58 ` [PR PATCH] [Updated] " icp1994
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ahesford @ 2022-10-04 14:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39502#discussion_r986946895

Comment:
Why change the distfiles? We generally prefer fetching from `$PYPI_SITE`.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
  2022-10-04 14:32 ` [PR REVIEW] python3-keyring: update to 23.9.3 ahesford
  2022-10-04 14:32 ` ahesford
@ 2022-10-04 14:58 ` icp1994
  2022-10-04 15:00 ` [PR REVIEW] " icp1994
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: icp1994 @ 2022-10-04 14:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-keyring
https://github.com/void-linux/void-packages/pull/39502

python3-keyring: update to 23.9.3.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Rev dep checks
- [x] Komikku
- [x] backintime
- [x] coursera-dl
- [x] cura
- [x] gajim
- [x] hatch
- [x] jrnl
- [x] mcg
- [x] nagstamon
- [x] pantalaimon
- [x] python3-keyrings-alt
- [x] urlwatch

A patch file from https://github.com/void-linux/void-packages/pull/39502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-keyring-39502.patch --]
[-- Type: text/x-diff, Size: 8004 bytes --]

From 3d2a81da9a615b2226c4dfb22ec0027a460d2a06 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 22 Sep 2022 01:29:51 +0530
Subject: [PATCH 1/3] python3-keyring: update to 23.9.3.

Adopt.
---
 srcpkgs/python3-keyring/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/python3-keyring/template b/srcpkgs/python3-keyring/template
index 35b44a7380a2..908e160000ec 100644
--- a/srcpkgs/python3-keyring/template
+++ b/srcpkgs/python3-keyring/template
@@ -1,20 +1,19 @@
 # Template file for 'python3-keyring'
 pkgname=python3-keyring
-version=23.7.0
+version=23.9.3
 revision=1
 wrksrc="keyring-${version}"
 build_style=python3-pep517
 hostmakedepends="python3-wheel python3-setuptools_scm"
-depends="python3-SecretStorage"
-checkdepends="python3-pytest
- python3-pytest-flake8 python3-pytest-cov"
+depends="python3-SecretStorage python3-jeepney python3-jaraco.classes"
+checkdepends="${depends} python3-pytest-xdist"
 short_desc="Python interface to the system keyring service"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="icp <pangolin@vivaldi.net>"
 license="MIT"
 homepage="https://github.com/jaraco/keyring"
 changelog="https://raw.githubusercontent.com/jaraco/keyring/master/CHANGES.rst"
 distfiles="${PYPI_SITE}/k/keyring/keyring-${version}.tar.gz"
-checksum=782e1cd1132e91bf459fcd243bcf25b326015c1ac0b198e4408f91fa6791062b
+checksum=69b01dd83c42f590250fe7a1f503fc229b14de83857314b1933a3ddbf595c4a5
 
 post_install() {
 	vlicense LICENSE

From 3feb277f3c8c4c0a8c3503724fb6f95750fa06fa Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 24 Sep 2022 01:34:48 +0530
Subject: [PATCH 2/3] coursera-dl: patch for python3>=3.9

---
 .../patches/fix-upstream-issue-778.patch      | 48 +++++++++++++++++++
 srcpkgs/coursera-dl/template                  |  8 ++--
 2 files changed, 52 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch

diff --git a/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch b/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch
new file mode 100644
index 000000000000..659d936a9c43
--- /dev/null
+++ b/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch
@@ -0,0 +1,48 @@
+From c8796e567698be166cb15f54e095140c1a9b567e Mon Sep 17 00:00:00 2001
+From: "Heino H. Gehlsen" <heino@gehlsen.dk>
+Date: Sun, 27 Dec 2020 13:28:35 +0100
+Subject: [PATCH] Fix AttributeError: 'HTMLParser' object has no attribute
+ 'unescape'
+
+https://github.com/coursera-dl/coursera-dl/pull/789
+---
+ coursera/utils.py | 12 +++++++-----
+ 1 file changed, 7 insertions(+), 5 deletions(-)
+
+diff --git a/coursera/utils.py b/coursera/utils.py
+index 9ba577af..f271bb9f 100644
+--- a/coursera/utils.py
++++ b/coursera/utils.py
+@@ -21,7 +21,11 @@
+ 
+ import six
+ from six import iteritems
+-from six.moves import html_parser
++if six.PY34:
++    import html
++else:
++    from six.moves import html_parser
++    html = html_parser.HTMLParser()
+ from six.moves.urllib.parse import ParseResult
+ from six.moves.urllib_parse import unquote_plus
+ 
+@@ -98,8 +102,7 @@ def random_string(length):
+ 
+ 
+ def unescape_html(s):
+-    h = html_parser.HTMLParser()
+-    s = h.unescape(s)
++    s = html.unescape(s)
+     s = unquote_plus(s)
+     return unescape(s, HTML_UNESCAPE_TABLE)
+ 
+@@ -114,8 +117,7 @@ def clean_filename(s, minimal_change=False):
+     """
+ 
+     # First, deal with URL encoded strings
+-    h = html_parser.HTMLParser()
+-    s = h.unescape(s)
++    s = html.unescape(s)
+     s = unquote_plus(s)
+ 
+     # Strip forbidden characters
diff --git a/srcpkgs/coursera-dl/template b/srcpkgs/coursera-dl/template
index 9c569678e49c..a79cecd680d1 100644
--- a/srcpkgs/coursera-dl/template
+++ b/srcpkgs/coursera-dl/template
@@ -1,16 +1,16 @@
 # Template file for 'coursera-dl'
 pkgname=coursera-dl
 version=0.11.5
-revision=3
+revision=4
 build_style=python3-module
-pycompile_module="coursera"
 hostmakedepends="python3-setuptools"
 depends="python3-attrs python3-setuptools python3-pyasn1 python3-ConfigArgParse
  python3-BeautifulSoup4 python3-requests python3-six python3-keyring
  python3-urllib3"
+checkdepends="${depends} python3-keyrings-alt python3-mock python3-pytest-xdist"
 short_desc="Script for downloading Coursera.org videos and naming them"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-3.0-or-later"
 homepage="https://github.com/coursera-dl/coursera-dl"
-distfiles="${PYPI_SITE}/c/coursera-dl/coursera-dl-${version}.tar.gz"
-checksum=66a84558dfcfcbdc487dcabcfc0d7c4a8569cc604b051b1d51bc95d52a369745
+distfiles="https://github.com/coursera-dl/coursera-dl/archive/refs/tags/${version}.tar.gz"
+checksum=27e382435084ec91ef89ab6c1d46f4756b708e4badf5307a8f18b9ad31971014

From 21b3884140524103963d610dcbc14b85c8040bc0 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 4 Oct 2022 20:26:47 +0530
Subject: [PATCH 3/3] Komikku: fix appdata file

---
 .../Komikku/patches/fix-appdata-file.patch    | 39 +++++++++++++++++++
 srcpkgs/Komikku/template                      |  2 +-
 2 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/Komikku/patches/fix-appdata-file.patch

diff --git a/srcpkgs/Komikku/patches/fix-appdata-file.patch b/srcpkgs/Komikku/patches/fix-appdata-file.patch
new file mode 100644
index 000000000000..05c1fb3d59cd
--- /dev/null
+++ b/srcpkgs/Komikku/patches/fix-appdata-file.patch
@@ -0,0 +1,39 @@
+--- info.febvre.Komikku.appdata.xml.in
++++ info.febvre.Komikku.appdata.xml.in
+@@ -49,28 +49,28 @@
+ 
+     <screenshots>
+         <screenshot type="default">
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/library.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/library.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/library-with-categories.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/library-with-categories.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/preferences.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/preferences.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/explorer.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/explorer.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/categories-editor.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/categories-editor.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/card-info.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/card-info.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/card-chapters.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/card-chapters.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/reader.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/reader.png</image>
+         </screenshot>
+     </screenshots>
+ 
diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index 0b66eb387e75..0fd7cdf7d015 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -1,7 +1,7 @@
 # Template file for 'Komikku'
 pkgname=Komikku
 version=0.40.0
-revision=1
+revision=2
 wrksrc=Komikku-v${version}
 build_style=meson
 hostmakedepends="gettext glib-devel gobject-introspection pkg-config"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
                   ` (2 preceding siblings ...)
  2022-10-04 14:58 ` [PR PATCH] [Updated] " icp1994
@ 2022-10-04 15:00 ` icp1994
  2022-10-04 15:02 ` ahesford
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: icp1994 @ 2022-10-04 15:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/39502#discussion_r986987520

Comment:
That's because pypi didn't provide the tests. This package has been broken since python3>=3.9 but since no test ran, it "passed" all the revbumps.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
                   ` (3 preceding siblings ...)
  2022-10-04 15:00 ` [PR REVIEW] " icp1994
@ 2022-10-04 15:02 ` ahesford
  2022-10-04 15:09 ` [PR PATCH] [Updated] " icp1994
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ahesford @ 2022-10-04 15:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39502#discussion_r986991271

Comment:
That's a good reason.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
                   ` (4 preceding siblings ...)
  2022-10-04 15:02 ` ahesford
@ 2022-10-04 15:09 ` icp1994
  2022-10-04 15:12 ` [PR REVIEW] " icp1994
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: icp1994 @ 2022-10-04 15:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-keyring
https://github.com/void-linux/void-packages/pull/39502

python3-keyring: update to 23.9.3.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Rev dep checks
- [x] Komikku
- [x] backintime
- [x] coursera-dl
- [x] cura
- [x] gajim
- [x] hatch
- [x] jrnl
- [x] mcg
- [x] nagstamon
- [x] pantalaimon
- [x] python3-keyrings-alt
- [x] urlwatch

A patch file from https://github.com/void-linux/void-packages/pull/39502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-keyring-39502.patch --]
[-- Type: text/x-diff, Size: 8018 bytes --]

From 3d2a81da9a615b2226c4dfb22ec0027a460d2a06 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 22 Sep 2022 01:29:51 +0530
Subject: [PATCH 1/3] python3-keyring: update to 23.9.3.

Adopt.
---
 srcpkgs/python3-keyring/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/python3-keyring/template b/srcpkgs/python3-keyring/template
index 35b44a7380a2..908e160000ec 100644
--- a/srcpkgs/python3-keyring/template
+++ b/srcpkgs/python3-keyring/template
@@ -1,20 +1,19 @@
 # Template file for 'python3-keyring'
 pkgname=python3-keyring
-version=23.7.0
+version=23.9.3
 revision=1
 wrksrc="keyring-${version}"
 build_style=python3-pep517
 hostmakedepends="python3-wheel python3-setuptools_scm"
-depends="python3-SecretStorage"
-checkdepends="python3-pytest
- python3-pytest-flake8 python3-pytest-cov"
+depends="python3-SecretStorage python3-jeepney python3-jaraco.classes"
+checkdepends="${depends} python3-pytest-xdist"
 short_desc="Python interface to the system keyring service"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="icp <pangolin@vivaldi.net>"
 license="MIT"
 homepage="https://github.com/jaraco/keyring"
 changelog="https://raw.githubusercontent.com/jaraco/keyring/master/CHANGES.rst"
 distfiles="${PYPI_SITE}/k/keyring/keyring-${version}.tar.gz"
-checksum=782e1cd1132e91bf459fcd243bcf25b326015c1ac0b198e4408f91fa6791062b
+checksum=69b01dd83c42f590250fe7a1f503fc229b14de83857314b1933a3ddbf595c4a5
 
 post_install() {
 	vlicense LICENSE

From 3feb277f3c8c4c0a8c3503724fb6f95750fa06fa Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 24 Sep 2022 01:34:48 +0530
Subject: [PATCH 2/3] coursera-dl: patch for python3>=3.9

---
 .../patches/fix-upstream-issue-778.patch      | 48 +++++++++++++++++++
 srcpkgs/coursera-dl/template                  |  8 ++--
 2 files changed, 52 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch

diff --git a/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch b/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch
new file mode 100644
index 000000000000..659d936a9c43
--- /dev/null
+++ b/srcpkgs/coursera-dl/patches/fix-upstream-issue-778.patch
@@ -0,0 +1,48 @@
+From c8796e567698be166cb15f54e095140c1a9b567e Mon Sep 17 00:00:00 2001
+From: "Heino H. Gehlsen" <heino@gehlsen.dk>
+Date: Sun, 27 Dec 2020 13:28:35 +0100
+Subject: [PATCH] Fix AttributeError: 'HTMLParser' object has no attribute
+ 'unescape'
+
+https://github.com/coursera-dl/coursera-dl/pull/789
+---
+ coursera/utils.py | 12 +++++++-----
+ 1 file changed, 7 insertions(+), 5 deletions(-)
+
+diff --git a/coursera/utils.py b/coursera/utils.py
+index 9ba577af..f271bb9f 100644
+--- a/coursera/utils.py
++++ b/coursera/utils.py
+@@ -21,7 +21,11 @@
+ 
+ import six
+ from six import iteritems
+-from six.moves import html_parser
++if six.PY34:
++    import html
++else:
++    from six.moves import html_parser
++    html = html_parser.HTMLParser()
+ from six.moves.urllib.parse import ParseResult
+ from six.moves.urllib_parse import unquote_plus
+ 
+@@ -98,8 +102,7 @@ def random_string(length):
+ 
+ 
+ def unescape_html(s):
+-    h = html_parser.HTMLParser()
+-    s = h.unescape(s)
++    s = html.unescape(s)
+     s = unquote_plus(s)
+     return unescape(s, HTML_UNESCAPE_TABLE)
+ 
+@@ -114,8 +117,7 @@ def clean_filename(s, minimal_change=False):
+     """
+ 
+     # First, deal with URL encoded strings
+-    h = html_parser.HTMLParser()
+-    s = h.unescape(s)
++    s = html.unescape(s)
+     s = unquote_plus(s)
+ 
+     # Strip forbidden characters
diff --git a/srcpkgs/coursera-dl/template b/srcpkgs/coursera-dl/template
index 9c569678e49c..a79cecd680d1 100644
--- a/srcpkgs/coursera-dl/template
+++ b/srcpkgs/coursera-dl/template
@@ -1,16 +1,16 @@
 # Template file for 'coursera-dl'
 pkgname=coursera-dl
 version=0.11.5
-revision=3
+revision=4
 build_style=python3-module
-pycompile_module="coursera"
 hostmakedepends="python3-setuptools"
 depends="python3-attrs python3-setuptools python3-pyasn1 python3-ConfigArgParse
  python3-BeautifulSoup4 python3-requests python3-six python3-keyring
  python3-urllib3"
+checkdepends="${depends} python3-keyrings-alt python3-mock python3-pytest-xdist"
 short_desc="Script for downloading Coursera.org videos and naming them"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-3.0-or-later"
 homepage="https://github.com/coursera-dl/coursera-dl"
-distfiles="${PYPI_SITE}/c/coursera-dl/coursera-dl-${version}.tar.gz"
-checksum=66a84558dfcfcbdc487dcabcfc0d7c4a8569cc604b051b1d51bc95d52a369745
+distfiles="https://github.com/coursera-dl/coursera-dl/archive/refs/tags/${version}.tar.gz"
+checksum=27e382435084ec91ef89ab6c1d46f4756b708e4badf5307a8f18b9ad31971014

From 9f7924281e5d6750fdf74285917f827d3dabc6d1 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 4 Oct 2022 20:26:47 +0530
Subject: [PATCH 3/3] Komikku: fix appdata file

---
 .../Komikku/patches/fix-appdata-file.patch    | 39 +++++++++++++++++++
 srcpkgs/Komikku/template                      |  2 +-
 2 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/Komikku/patches/fix-appdata-file.patch

diff --git a/srcpkgs/Komikku/patches/fix-appdata-file.patch b/srcpkgs/Komikku/patches/fix-appdata-file.patch
new file mode 100644
index 000000000000..f43a189bef7d
--- /dev/null
+++ b/srcpkgs/Komikku/patches/fix-appdata-file.patch
@@ -0,0 +1,39 @@
+--- a/data/info.febvre.Komikku.appdata.xml.in
++++ b/data/info.febvre.Komikku.appdata.xml.in
+@@ -49,28 +49,28 @@
+ 
+     <screenshots>
+         <screenshot type="default">
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/library.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/library.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/library-with-categories.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/library-with-categories.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/preferences.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/preferences.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/explorer.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/explorer.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/categories-editor.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/categories-editor.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/card-info.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/card-info.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/card-chapters.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/card-chapters.png</image>
+         </screenshot>
+         <screenshot>
+-            <image>https://gitlab.com/valos/Komikku/raw/master/screenshots/reader.png</image>
++            <image>https://gitlab.com/valos/Komikku/raw/main/screenshots/reader.png</image>
+         </screenshot>
+     </screenshots>
+ 
diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index 0b66eb387e75..0fd7cdf7d015 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -1,7 +1,7 @@
 # Template file for 'Komikku'
 pkgname=Komikku
 version=0.40.0
-revision=1
+revision=2
 wrksrc=Komikku-v${version}
 build_style=meson
 hostmakedepends="gettext glib-devel gobject-introspection pkg-config"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
                   ` (5 preceding siblings ...)
  2022-10-04 15:09 ` [PR PATCH] [Updated] " icp1994
@ 2022-10-04 15:12 ` icp1994
  2022-10-04 15:12 ` icp1994
  2022-10-04 15:16 ` [PR PATCH] [Merged]: " ahesford
  8 siblings, 0 replies; 10+ messages in thread
From: icp1994 @ 2022-10-04 15:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/39502#discussion_r987007235

Comment:
Kinda off-topic, but I wish more and more packages would provide tests in their pypi, caro etc tarballs. That would save us so many of those github rate-limit hits in the auto-updater.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
                   ` (6 preceding siblings ...)
  2022-10-04 15:12 ` [PR REVIEW] " icp1994
@ 2022-10-04 15:12 ` icp1994
  2022-10-04 15:16 ` [PR PATCH] [Merged]: " ahesford
  8 siblings, 0 replies; 10+ messages in thread
From: icp1994 @ 2022-10-04 15:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/39502#discussion_r987007235

Comment:
Kinda off-topic, but I wish more and more packages would provide tests in their pypi, cargo-static etc tarballs. That would save us so many of those github rate-limit hits in the auto-updater.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Merged]: python3-keyring: update to 23.9.3.
  2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
                   ` (7 preceding siblings ...)
  2022-10-04 15:12 ` icp1994
@ 2022-10-04 15:16 ` ahesford
  8 siblings, 0 replies; 10+ messages in thread
From: ahesford @ 2022-10-04 15:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

There's a merged pull request on the void-packages repository

python3-keyring: update to 23.9.3.
https://github.com/void-linux/void-packages/pull/39502

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Rev dep checks
- [x] Komikku
- [x] backintime
- [x] coursera-dl
- [x] cura
- [x] gajim
- [x] hatch
- [x] jrnl
- [x] mcg
- [x] nagstamon
- [x] pantalaimon
- [x] python3-keyrings-alt
- [x] urlwatch

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-10-04 15:16 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 10:10 [PR PATCH] Python3 keyring icp1994
2022-10-04 14:32 ` [PR REVIEW] python3-keyring: update to 23.9.3 ahesford
2022-10-04 14:32 ` ahesford
2022-10-04 14:58 ` [PR PATCH] [Updated] " icp1994
2022-10-04 15:00 ` [PR REVIEW] " icp1994
2022-10-04 15:02 ` ahesford
2022-10-04 15:09 ` [PR PATCH] [Updated] " icp1994
2022-10-04 15:12 ` [PR REVIEW] " icp1994
2022-10-04 15:12 ` icp1994
2022-10-04 15:16 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).