Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: wired-notify-0.10.2
Date: Thu, 06 Oct 2022 00:47:50 +0200	[thread overview]
Message-ID: <20221005224750.Y2lqndEH475rWLbXNi1ILlacYD-EvVCZ0v4t48KBkrM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39738@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39738#issuecomment-1269070921

Comment:
many other distros don't support the architectures void supports.

the build only failed on 32-bit architectures (i686, armv6l, and armv7l).

[the error](https://github.com/void-linux/void-packages/actions/runs/3191379385/jobs/5210738618#step:7:406) was caused by the upstream not ensuring their types matched, i.e. they were not checking if [this `u64`](https://github.com/Toqozz/wired-notify/blob/4bb3dfff38934c47be818f497af65d1e3a01311c/src/config.rs#L120) and [this `c_ulong`](https://docs.rs/x11/2.20.0/x11/xss/struct.XScreenSaverInfo.html#structfield.idle) could actually be compared ([`c_ulong`](https://doc.rust-lang.org/nightly/std/os/raw/type.c_ulong.html) can be `u32` or `u64`). there may be other errors (because the devs obviously aren't testing anything on 32-bit systems), but this one can be fixed by (or something similar):

```diff
- if info.idle / 1000 >= threshold {
+ if (info.idle as u64) / 1000 >= threshold {
```

  parent reply	other threads:[~2022-10-05 22:47 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 12:29 [PR PATCH] " fccapria
2022-10-05 12:33 ` abenson
2022-10-05 12:34 ` [PR REVIEW] " abenson
2022-10-05 12:35 ` abenson
2022-10-05 12:35 ` abenson
2022-10-05 12:36 ` abenson
2022-10-05 12:37 ` abenson
2022-10-05 12:40 ` fccapria
2022-10-05 12:42 ` fccapria
2022-10-05 14:04 ` [PR PATCH] [Updated] " fccapria
2022-10-05 14:34 ` fccapria
2022-10-05 14:43 ` fccapria
2022-10-05 14:56 ` CameronNemo
2022-10-05 15:31 ` [PR PATCH] [Updated] " fccapria
2022-10-05 15:52 ` fccapria
2022-10-05 16:51 ` CameronNemo
2022-10-05 17:16 ` [PR PATCH] [Updated] " fccapria
2022-10-05 17:20 ` fccapria
2022-10-05 17:24 ` fccapria
2022-10-05 21:27 ` [PR REVIEW] " classabbyamp
2022-10-05 21:47 ` [PR PATCH] [Updated] " fccapria
2022-10-05 21:59 ` fccapria
2022-10-05 22:00 ` fccapria
2022-10-05 22:02 ` classabbyamp
2022-10-05 22:02 ` classabbyamp
2022-10-05 22:10 ` fccapria
2022-10-05 22:47 ` classabbyamp [this message]
2022-10-05 23:07 ` fccapria
2022-10-05 23:10 ` classabbyamp
2022-10-05 23:14 ` fccapria
2022-10-05 23:22 ` classabbyamp
2022-10-06  1:52 ` CameronNemo
2022-10-06 10:35 ` [PR PATCH] [Updated] " fccapria
2022-10-06 10:39 ` fccapria
2022-10-06 10:41 ` fccapria
2022-10-06 10:45 ` fccapria
2022-10-08  1:50 ` classabbyamp
2022-10-08 10:20 ` [PR PATCH] [Updated] " fccapria
2022-10-08 10:21 ` fccapria
2022-10-08 10:24 ` fccapria
2022-10-08 10:29 ` fccapria
2022-10-08 14:05 ` [PR PATCH] [Updated] " fccapria
2022-10-08 14:09 ` fccapria
2022-10-08 19:11 ` [PR REVIEW] " classabbyamp
2022-10-08 19:29 ` fccapria
2022-10-08 19:37 ` fccapria
2022-10-08 19:46 ` classabbyamp
2022-10-08 19:53 ` fccapria
2022-10-08 19:53 ` [PR PATCH] [Updated] " fccapria
2022-10-08 19:54 ` fccapria
2022-10-08 20:00 ` [PR REVIEW] " classabbyamp
2022-10-08 20:09 ` fccapria
2022-10-08 20:14 ` [PR PATCH] [Updated] " fccapria
2022-10-08 20:14 ` fccapria
2022-10-08 20:31 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221005224750.Y2lqndEH475rWLbXNi1ILlacYD-EvVCZ0v4t48KBkrM@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).