[PR PATCH] python3-redis: update to 4.3.4

[PR PATCH] python3-redis: update to 4.3.4

[StaticVoidMoon]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

There is a new pull request by StaticVoidMoon against master on the void-packages repository

https://github.com/StaticVoidMoon/void-packages python3-redis
https://github.com/void-linux/void-packages/pull/39730

python3-redis: update to 4.3.4
#### Testing the changes
- I tested the changes in this PR: **briefly**
-- DB Connect
-- Set
-- Get
-- Dump
-- Restore
-- Expire
-- Exists
#### Note: 
- I add 'python3-packaging' dependency due to `import redis` error during test.
- I also presume that I need to change maintainer value from 'orphaned' to 'myself'. 

#### Local build testing
- I built this PR locally for my native architecture, (x86-64)



A patch file from https://github.com/void-linux/void-packages/pull/39730.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-redis-39730.patch --]
[-- Type: text/x-diff, Size: 1238 bytes --]

From 96034e5ba228939099bb34df62d68d16ffbd772b Mon Sep 17 00:00:00 2001
From: StaticVoidMoon <mem+dev@lnthle.com>
Date: Wed, 5 Oct 2022 09:15:54 +0700
Subject: [PATCH] python3-redis: update to 4.3.4

---
 srcpkgs/python3-redis/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-redis/template b/srcpkgs/python3-redis/template
index f228a1c88df3..104542c7c7bf 100644
--- a/srcpkgs/python3-redis/template
+++ b/srcpkgs/python3-redis/template
@@ -1,17 +1,17 @@
 # Template file for 'python3-redis'
 pkgname=python3-redis
-version=3.5.3
-revision=4
+version=4.3.4
+revision=1
 wrksrc="redis-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3 python3-packaging"
 short_desc="Python3 client for Redis key-value store"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="StaticVoidMoon <mem+dev@lnthle.com>"
 license="MIT"
 homepage="https://github.com/andymccurdy/redis-py"
 distfiles="${PYPI_SITE}/r/redis/redis-${version}.tar.gz"
-checksum=0e7e0cfca8660dea8b7d5cd8c4f6c5e29e11f31158c0b0ae91a397f00e5a05a2
+checksum=ddf27071df4adf3821c4f2ca59d67525c3a82e5f268bed97b813cb4fabf87880
 
 post_install() {
 	vlicense LICENSE

Re: python3-redis: update to 4.3.4

[StaticVoidMoon]

[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]

New comment by StaticVoidMoon on void-packages repository

https://github.com/void-linux/void-packages/pull/39730#issuecomment-1268351886

Comment:
Hi. Based on my understanding and after digging around, I found that in the check phase it will try to connect to redis for testing as copied below.
```
=> python3-redis-4.3.4_1: running do_check ...
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/connection.py", line 611, in connect
INTERNALERROR>     sock = self.retry.call_with_retry(
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/retry.py", line 46, in call_with_retry
INTERNALERROR>     return do()
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/connection.py", line 612, in <lambda>
INTERNALERROR>     lambda: self._connect(), lambda error: self.disconnect(error)
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/connection.py", line 677, in _connect
INTERNALERROR>     raise err
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/connection.py", line 665, in _connect
INTERNALERROR>     sock.connect(socket_address)
INTERNALERROR> ConnectionRefusedError: [Errno 111] Connection refused
```
In this case, should I try to add redis as a `checkdepend` or should I just set `make_check=no`. Sorry for the trouble.

Re: [PR PATCH] [Updated] python3-redis: update to 4.3.4

[StaticVoidMoon]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

There is an updated pull request by StaticVoidMoon against master on the void-packages repository

https://github.com/StaticVoidMoon/void-packages python3-redis
https://github.com/void-linux/void-packages/pull/39730

python3-redis: update to 4.3.4
#### Testing the changes
- I tested the changes in this PR: **briefly**
-- DB Connect
-- Set
-- Get
-- Dump
-- Restore
-- Expire
-- Exists
#### Note: 
- I add 'python3-packaging' dependency due to `import redis` error during test.
- I also presume that I need to change maintainer value from 'orphaned' to 'myself'. 

#### Local build testing
- I built this PR locally for my native architecture, (x86-64)



A patch file from https://github.com/void-linux/void-packages/pull/39730.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-redis-39730.patch --]
[-- Type: text/x-diff, Size: 1292 bytes --]

From b3130a2e3bf710020162dff96bfa59d422a3c863 Mon Sep 17 00:00:00 2001
From: StaticVoidMoon <mem+dev@lnthle.com>
Date: Wed, 5 Oct 2022 09:15:54 +0700
Subject: [PATCH] python3-redis: update to 4.3.4

---
 srcpkgs/python3-redis/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-redis/template b/srcpkgs/python3-redis/template
index f228a1c88df3..4daa2098bb81 100644
--- a/srcpkgs/python3-redis/template
+++ b/srcpkgs/python3-redis/template
@@ -1,17 +1,18 @@
 # Template file for 'python3-redis'
 pkgname=python3-redis
-version=3.5.3
-revision=4
+version=4.3.4
+revision=1
 wrksrc="redis-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3 python3-packaging"
 short_desc="Python3 client for Redis key-value store"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="StaticVoidMoon <mem+dev@lnthle.com>"
 license="MIT"
 homepage="https://github.com/andymccurdy/redis-py"
 distfiles="${PYPI_SITE}/r/redis/redis-${version}.tar.gz"
-checksum=0e7e0cfca8660dea8b7d5cd8c4f6c5e29e11f31158c0b0ae91a397f00e5a05a2
+checksum=ddf27071df4adf3821c4f2ca59d67525c3a82e5f268bed97b813cb4fabf87880
+make_check="no" # Check need running redis instance
 
 post_install() {
 	vlicense LICENSE

Re: python3-redis: update to 4.3.4

[StaticVoidMoon]

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

New comment by StaticVoidMoon on void-packages repository

https://github.com/void-linux/void-packages/pull/39730#issuecomment-1268351886

Comment:
Hi. Based on my understanding and after digging around, I found that in the check phase it will try to connect to redis for testing as copied below.
```
=> python3-redis-4.3.4_1: running do_check ...
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/connection.py", line 611, in connect
INTERNALERROR>     sock = self.retry.call_with_retry(
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/retry.py", line 46, in call_with_retry
INTERNALERROR>     return do()
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/connection.py", line 612, in <lambda>
INTERNALERROR>     lambda: self._connect(), lambda error: self.disconnect(error)
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/connection.py", line 677, in _connect
INTERNALERROR>     raise err
INTERNALERROR>   File "/builddir/redis-4.3.4/redis/connection.py", line 665, in _connect
INTERNALERROR>     sock.connect(socket_address)
INTERNALERROR> ConnectionRefusedError: [Errno 111] Connection refused
```
In this case, should I try to add redis as a `checkdepend` or should I just set `make_check=no`. Sorry for the trouble.

*Edited* : After, looking at other library seem like many library related to DB need `make_check="no"` otherwise will failed at test. So, I decide to proceed with `make_check="no"`.

Re: python3-redis: update to 4.3.4

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/39730#issuecomment-1371652189

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: python3-redis: update to 4.3.4

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

There's a closed pull request on the void-packages repository

python3-redis: update to 4.3.4
https://github.com/void-linux/void-packages/pull/39730

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**
-- DB Connect
-- Set
-- Get
-- Dump
-- Restore
-- Expire
-- Exists
#### Note: 
- I add 'python3-packaging' dependency due to `import redis` error during test.
- I also presume that I need to change maintainer value from 'orphaned' to 'myself'. 

#### Local build testing
- I built this PR locally for my native architecture, (x86-64)

Re: [PR PATCH] [Updated] python3-redis: update to 4.3.4

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

There is an updated pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages python3-redis-4.3.4
https://github.com/void-linux/void-packages/pull/39904

python3-redis: update to 4.3.4
@abenson I see no reference to `redis` anywhere in the `ytmdl` repository. Please confirm that removing this dependency is OK.

A patch file from https://github.com/void-linux/void-packages/pull/39904.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-redis-4.3.4-39904.patch --]
[-- Type: text/x-diff, Size: 6741 bytes --]

From da0377ffeb5cefe1613dc66b95c4b0be986cff23 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Tue, 11 Oct 2022 21:51:55 -0400
Subject: [PATCH 1/5] New package: python3-deprecated-1.2.13

---
 srcpkgs/python3-deprecated/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/python3-deprecated/template

diff --git a/srcpkgs/python3-deprecated/template b/srcpkgs/python3-deprecated/template
new file mode 100644
index 000000000000..4eb400ffd0dd
--- /dev/null
+++ b/srcpkgs/python3-deprecated/template
@@ -0,0 +1,20 @@
+# Template file for 'python3-deprecated'
+pkgname=python3-deprecated
+version=1.2.13
+revision=1
+wrksrc="deprecated-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-wrapt"
+checkdepends="python3-pytest-xdist python3-wrapt"
+short_desc="Python decorator to deprecate old clases, functions or methods"
+maintainer="Andrew J. Hesford <ajh@sideband.org>"
+license="MIT"
+homepage="https://github.com/tantale/deprecated"
+changelog="https://raw.githubusercontent.com/tantale/deprecated/master/CHANGELOG.rst"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=771e20e93bb4bc497bd9955829d36074dd7608962846c0b34a92ff68ed7ebad9
+
+post_install() {
+	vlicense LICENSE.rst
+}

From 277dad5284bcbb5161b48563f178998bd90c96c3 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Tue, 11 Oct 2022 21:57:18 -0400
Subject: [PATCH 2/5] python3-redis: update to 4.3.4.

---
 srcpkgs/python3-redis/template | 15 +++++++++------
 srcpkgs/python3-redis/update   |  1 +
 2 files changed, 10 insertions(+), 6 deletions(-)
 create mode 100644 srcpkgs/python3-redis/update

diff --git a/srcpkgs/python3-redis/template b/srcpkgs/python3-redis/template
index f228a1c88df3..86d803932946 100644
--- a/srcpkgs/python3-redis/template
+++ b/srcpkgs/python3-redis/template
@@ -1,17 +1,20 @@
 # Template file for 'python3-redis'
 pkgname=python3-redis
-version=3.5.3
-revision=4
+version=4.3.4
+revision=1
 wrksrc="redis-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3-deprecated python3-async-timeout python3-packaging"
 short_desc="Python3 client for Redis key-value store"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="MIT"
-homepage="https://github.com/andymccurdy/redis-py"
+homepage="https://github.com/redis/redis-py"
+changelog="https://raw.githubusercontent.com/redis/redis-py/master/CHANGES"
 distfiles="${PYPI_SITE}/r/redis/redis-${version}.tar.gz"
-checksum=0e7e0cfca8660dea8b7d5cd8c4f6c5e29e11f31158c0b0ae91a397f00e5a05a2
+checksum=ddf27071df4adf3821c4f2ca59d67525c3a82e5f268bed97b813cb4fabf87880
+replaces="python3-aioredis<=2.0.1_1"
+make_check=no # tests require a running redis server
 
 post_install() {
 	vlicense LICENSE
diff --git a/srcpkgs/python3-redis/update b/srcpkgs/python3-redis/update
new file mode 100644
index 000000000000..e299d00ea67c
--- /dev/null
+++ b/srcpkgs/python3-redis/update
@@ -0,0 +1 @@
+ignore="*rc*"

From 214f97305954c6246feff63d94864eee267f8b9c Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Tue, 11 Oct 2022 21:57:43 -0400
Subject: [PATCH 3/5] python3-aioredis: remove package

This package has been superseded by python3-redis>=4.2.0, see

    https://raw.githubusercontent.com/aio-libs/aioredis-py/master/README.md
---
 srcpkgs/python3-aioredis/template | 20 --------------------
 1 file changed, 20 deletions(-)
 delete mode 100644 srcpkgs/python3-aioredis/template

diff --git a/srcpkgs/python3-aioredis/template b/srcpkgs/python3-aioredis/template
deleted file mode 100644
index fee5bba3139b..000000000000
--- a/srcpkgs/python3-aioredis/template
+++ /dev/null
@@ -1,20 +0,0 @@
-# Template file for 'python3-aioredis'
-pkgname=python3-aioredis
-version=2.0.1
-revision=1
-wrksrc="aioredis-py-${version}"
-build_style=python3-module
-hostmakedepends="python3-setuptools"
-depends="python3-async-timeout python3-typing_extensions python3-hiredis"
-short_desc="Asynchronous Redis client for Python"
-maintainer="Andrew J. Hesford <ajh@sideband.org>"
-license="MIT"
-homepage="https://github.com/aio-libs/aioredis"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=ee647e340c5436f2e5a07f2369fdb164abc2714c7ab3561c544015d974021b57
-# checks require a locally running redis server
-make_check="no"
-
-post_install() {
-	vlicense LICENSE
-}

From b503a7634b77385af90a3ca3177ad7d2fad1b40a Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Tue, 11 Oct 2022 21:59:42 -0400
Subject: [PATCH 4/5] ytmdl: remove unnecessary python3-redis dependency

---
 srcpkgs/ytmdl/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ytmdl/template b/srcpkgs/ytmdl/template
index 2575c3ee61d1..52a118f2dfd6 100644
--- a/srcpkgs/ytmdl/template
+++ b/srcpkgs/ytmdl/template
@@ -1,7 +1,7 @@
 # Template file for 'ytmdl'
 pkgname=ytmdl
 version=2022.03.16
-revision=2
+revision=3
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="ffmpeg youtube-dl python3-mutagen python3-requests python3-colorama
@@ -10,7 +10,7 @@ depends="ffmpeg youtube-dl python3-mutagen python3-requests python3-colorama
  python3-Unidecode python3-urllib3 python3-youtube-search
  python3-pyDes python3-simber python3-rich python3-musicbrainzngs
  python3-typing_extensions python3-ytmusicapi python3-youtubesearch
- python3-spotipy python3-redis"
+ python3-spotipy"
 short_desc="Get songs from youtube in mp3 format with all tags from itunes"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="MIT"

From e59b654b5ae253e3d66f4a378449981ab325ce0e Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Wed, 12 Oct 2022 09:28:06 -0400
Subject: [PATCH 5/5] python3-spotipy: add missing python3-redis dependency

---
 srcpkgs/python3-spotipy/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-spotipy/template b/srcpkgs/python3-spotipy/template
index 6ea9e629df06..1132f7ca36ae 100644
--- a/srcpkgs/python3-spotipy/template
+++ b/srcpkgs/python3-spotipy/template
@@ -1,12 +1,12 @@
 # Template file for 'python3-spotipy'
 pkgname=python3-spotipy
 version=2.20.0
-revision=1
+revision=2
 wrksrc="spotipy-${version}"
 build_style=python3-module
 hostmakedepends="pkg-config python3-setuptools"
 makedepends="python3-devel"
-depends="python3-requests python3-six python3-urllib3"
+depends="python3-requests python3-six python3-urllib3 python3-redis"
 short_desc="Light weight Python library for the Spotify Web API"
 maintainer="Eloi Torrents <eloitor@disroot.org>"
 license="MIT"