Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] fsearch: update to 0.1.4 & fix unresolvable shlib
@ 2022-07-09  9:52 ScrelliCopter
  2022-07-09  9:57 ` paper42
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: ScrelliCopter @ 2022-07-09  9:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

There is a new pull request by ScrelliCopter against master on the void-packages repository

https://github.com/ScrelliCopter/void-packages fsearch-0.1.4
https://github.com/void-linux/void-packages/pull/37935

fsearch: update to 0.1.4 & fix unresolvable shlib
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


Also fixed me not being able to update due to ```fsearch-0.1.2_2: broken, unresolvable shlib `libicuuc.so.70'``` introduced since last revbump.

A patch file from https://github.com/void-linux/void-packages/pull/37935.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fsearch-0.1.4-37935.patch --]
[-- Type: text/x-diff, Size: 2125 bytes --]

From 7ec18dbd999ec0d622f69c8f0757e1ed1af41e3b Mon Sep 17 00:00:00 2001
From: a dinosaur <nick@a-dinosaur.com>
Date: Sat, 9 Jul 2022 19:43:43 +1000
Subject: [PATCH] fsearch: update to 0.1.4

---
 .../fsearch/patches/musl-no-malloc_trim.diff    | 13 -------------
 srcpkgs/fsearch/template                        | 17 ++++++-----------
 2 files changed, 6 insertions(+), 24 deletions(-)
 delete mode 100644 srcpkgs/fsearch/patches/musl-no-malloc_trim.diff

diff --git a/srcpkgs/fsearch/patches/musl-no-malloc_trim.diff b/srcpkgs/fsearch/patches/musl-no-malloc_trim.diff
deleted file mode 100644
index fd6c7304fc32..000000000000
--- a/srcpkgs/fsearch/patches/musl-no-malloc_trim.diff
+++ /dev/null
@@ -1,13 +0,0 @@
-diff -ruN fsearch-0.1/src/fsearch_database.c fsearch-0.1-musl/src/fsearch_database.c
---- fsearch-0.1/src/fsearch_database.c	2021-09-25 02:41:49.000000000 +1000
-+++ fsearch-0.1-musl/src/fsearch_database.c	2021-09-25 21:42:00.187684634 +1000
-@@ -1454,7 +1454,9 @@
- 
-     g_clear_pointer(&db, free);
- 
-+#ifdef __GLIBC__
-     malloc_trim(0);
-+#endif
- 
-     g_debug("[db_free] freed");
- }
diff --git a/srcpkgs/fsearch/template b/srcpkgs/fsearch/template
index cdf4e8056ec4..32d5cb6b4bc0 100644
--- a/srcpkgs/fsearch/template
+++ b/srcpkgs/fsearch/template
@@ -1,18 +1,13 @@
 # Template file for 'fsearch'
 pkgname=fsearch
-version=0.1.2
-revision=2
-build_style=gnu-configure
-hostmakedepends="autogen automake libtool pkg-config autoconf-archive
- gettext-devel glib-devel"
+version=0.1.4
+revision=1
+build_style=meson
+hostmakedepends="libtool pkg-config glib-devel gettext-devel"
 makedepends="gtk+3-devel"
 short_desc="Fast file search utility based on GTK+3"
-maintainer="a dinosaur <nick@a-dinosaur.com>"
+maintainer="a dinosaur <dino@a-dinosaur.com>"
 license="GPL-2.0-or-later"
 homepage="https://cboxdoerfer.github.io/fsearch/"
 distfiles="https://github.com/cboxdoerfer/fsearch/archive/${version}.tar.gz"
-checksum=f80e10922812169e8437476d5fbe6d05249997c49b98f991d382a6d5566551b4
-
-pre_configure() {
-	./autogen.sh
-}
+checksum=289c19136f89712100ff8f6ad4e7cbbdfbd2938a7c076c85c45658f5c36fc7fd

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fsearch: update to 0.1.4 & fix unresolvable shlib
  2022-07-09  9:52 [PR PATCH] fsearch: update to 0.1.4 & fix unresolvable shlib ScrelliCopter
@ 2022-07-09  9:57 ` paper42
  2022-07-09  9:57 ` paper42
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2022-07-09  9:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37935#issuecomment-1179515973

Comment:
> Also fixed me not being able to update due to `` fsearch-0.1.2_2: broken, unresolvable shlib `libicuuc.so.70' `` introduced since last revbump.

This can not happen with this package from the binary repository. You had to manually increase the revision to 2 when icu-libs was at 70, build it and install it, that's why you didn't get the update that rebuilt fsearch for icu-libs 71. 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fsearch: update to 0.1.4 & fix unresolvable shlib
  2022-07-09  9:52 [PR PATCH] fsearch: update to 0.1.4 & fix unresolvable shlib ScrelliCopter
  2022-07-09  9:57 ` paper42
@ 2022-07-09  9:57 ` paper42
  2022-07-09 10:48 ` [PR PATCH] [Updated] " ScrelliCopter
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2022-07-09  9:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37935#issuecomment-1179515973

Comment:
> Also fixed me not being able to update due to `` fsearch-0.1.2_2: broken, unresolvable shlib `libicuuc.so.70' `` introduced since last revbump.

This can not happen with this package from the binary repository. You had to manually increase the revision to 2 when icu-libs was at 70, build it and install it, that's why you didn't get the update that rebuilt fsearch for icu-libs 71. `xbps-install -f fsearch` would fix it.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] fsearch: update to 0.1.4 & fix unresolvable shlib
  2022-07-09  9:52 [PR PATCH] fsearch: update to 0.1.4 & fix unresolvable shlib ScrelliCopter
  2022-07-09  9:57 ` paper42
  2022-07-09  9:57 ` paper42
@ 2022-07-09 10:48 ` ScrelliCopter
  2022-07-09 10:49 ` ScrelliCopter
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ScrelliCopter @ 2022-07-09 10:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

There is an updated pull request by ScrelliCopter against master on the void-packages repository

https://github.com/ScrelliCopter/void-packages fsearch-0.1.4
https://github.com/void-linux/void-packages/pull/37935

fsearch: update to 0.1.4 & fix unresolvable shlib
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


Also fixed me not being able to update due to ```fsearch-0.1.2_2: broken, unresolvable shlib `libicuuc.so.70'``` introduced since last revbump.

A patch file from https://github.com/void-linux/void-packages/pull/37935.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fsearch-0.1.4-37935.patch --]
[-- Type: text/x-diff, Size: 3006 bytes --]

From d71f18f5841f7d5814b09ad19efa55f6e7360ff2 Mon Sep 17 00:00:00 2001
From: a dinosaur <nick@a-dinosaur.com>
Date: Sat, 9 Jul 2022 19:43:43 +1000
Subject: [PATCH] fsearch: update to 0.1.4

---
 .../fsearch/patches/musl-no-malloc_trim.diff  | 38 ++++++++++++++++---
 srcpkgs/fsearch/template                      | 17 +++------
 2 files changed, 39 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/fsearch/patches/musl-no-malloc_trim.diff b/srcpkgs/fsearch/patches/musl-no-malloc_trim.diff
index fd6c7304fc32..49403a2c5f79 100644
--- a/srcpkgs/fsearch/patches/musl-no-malloc_trim.diff
+++ b/srcpkgs/fsearch/patches/musl-no-malloc_trim.diff
@@ -1,11 +1,39 @@
-diff -ruN fsearch-0.1/src/fsearch_database.c fsearch-0.1-musl/src/fsearch_database.c
---- fsearch-0.1/src/fsearch_database.c	2021-09-25 02:41:49.000000000 +1000
-+++ fsearch-0.1-musl/src/fsearch_database.c	2021-09-25 21:42:00.187684634 +1000
-@@ -1454,7 +1454,9 @@
+diff --git a/meson.build b/meson.build
+index 0e26bf5..9114af6 100644
+--- a/meson.build
++++ b/meson.build
+@@ -12,7 +12,10 @@ cc = meson.get_compiler('c')
+ gnome = import('gnome')
+ i18n = import('i18n')
+ 
++have_malloc_trim = cc.has_function('malloc_trim')
++
+ config_h = configuration_data()
++config_h.set('HAVE_MALLOC_TRIM', have_malloc_trim)
+ config_h.set_quoted('APP_ID', app_id)
+ config_h.set_quoted('PACKAGE_VERSION', meson.project_version())
+ config_h.set_quoted('VERSION', meson.project_version())
+diff --git a/src/fsearch_database.c b/src/fsearch_database.c
+index 8dcc9d0..80518b7 100644
+--- a/src/fsearch_database.c
++++ b/src/fsearch_database.c
+@@ -25,7 +25,11 @@
+ #include <fcntl.h>
+ #include <fnmatch.h>
+ #include <glib/gi18n.h>
++
++#ifdef HAVE_MALLOC_TRIM
+ #include <malloc.h>
++#endif
++
+ #include <stdbool.h>
+ #include <stdio.h>
+ #include <string.h>
+@@ -1459,7 +1463,9 @@ db_free(FsearchDatabase *db) {
  
      g_clear_pointer(&db, free);
  
-+#ifdef __GLIBC__
++#ifdef HAVE_MALLOC_TRIM
      malloc_trim(0);
 +#endif
  
diff --git a/srcpkgs/fsearch/template b/srcpkgs/fsearch/template
index cdf4e8056ec4..32d5cb6b4bc0 100644
--- a/srcpkgs/fsearch/template
+++ b/srcpkgs/fsearch/template
@@ -1,18 +1,13 @@
 # Template file for 'fsearch'
 pkgname=fsearch
-version=0.1.2
-revision=2
-build_style=gnu-configure
-hostmakedepends="autogen automake libtool pkg-config autoconf-archive
- gettext-devel glib-devel"
+version=0.1.4
+revision=1
+build_style=meson
+hostmakedepends="libtool pkg-config glib-devel gettext-devel"
 makedepends="gtk+3-devel"
 short_desc="Fast file search utility based on GTK+3"
-maintainer="a dinosaur <nick@a-dinosaur.com>"
+maintainer="a dinosaur <dino@a-dinosaur.com>"
 license="GPL-2.0-or-later"
 homepage="https://cboxdoerfer.github.io/fsearch/"
 distfiles="https://github.com/cboxdoerfer/fsearch/archive/${version}.tar.gz"
-checksum=f80e10922812169e8437476d5fbe6d05249997c49b98f991d382a6d5566551b4
-
-pre_configure() {
-	./autogen.sh
-}
+checksum=289c19136f89712100ff8f6ad4e7cbbdfbd2938a7c076c85c45658f5c36fc7fd

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fsearch: update to 0.1.4 & fix unresolvable shlib
  2022-07-09  9:52 [PR PATCH] fsearch: update to 0.1.4 & fix unresolvable shlib ScrelliCopter
                   ` (2 preceding siblings ...)
  2022-07-09 10:48 ` [PR PATCH] [Updated] " ScrelliCopter
@ 2022-07-09 10:49 ` ScrelliCopter
  2022-10-08  2:13 ` fsearch: update to 0.1.4 github-actions
  2022-10-08  3:48 ` [PR PATCH] [Closed]: " ScrelliCopter
  5 siblings, 0 replies; 7+ messages in thread
From: ScrelliCopter @ 2022-07-09 10:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by ScrelliCopter on void-packages repository

https://github.com/void-linux/void-packages/pull/37935#issuecomment-1179522856

Comment:
Weird, well anyway musl builds should be working again.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fsearch: update to 0.1.4
  2022-07-09  9:52 [PR PATCH] fsearch: update to 0.1.4 & fix unresolvable shlib ScrelliCopter
                   ` (3 preceding siblings ...)
  2022-07-09 10:49 ` ScrelliCopter
@ 2022-10-08  2:13 ` github-actions
  2022-10-08  3:48 ` [PR PATCH] [Closed]: " ScrelliCopter
  5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2022-10-08  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37935#issuecomment-1272198261

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: fsearch: update to 0.1.4
  2022-07-09  9:52 [PR PATCH] fsearch: update to 0.1.4 & fix unresolvable shlib ScrelliCopter
                   ` (4 preceding siblings ...)
  2022-10-08  2:13 ` fsearch: update to 0.1.4 github-actions
@ 2022-10-08  3:48 ` ScrelliCopter
  5 siblings, 0 replies; 7+ messages in thread
From: ScrelliCopter @ 2022-10-08  3:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

There's a closed pull request on the void-packages repository

fsearch: update to 0.1.4
https://github.com/void-linux/void-packages/pull/37935

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


Also fixed me not being able to update due to ```fsearch-0.1.2_2: broken, unresolvable shlib `libicuuc.so.70'``` introduced since last revbump.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-10-08  3:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09  9:52 [PR PATCH] fsearch: update to 0.1.4 & fix unresolvable shlib ScrelliCopter
2022-07-09  9:57 ` paper42
2022-07-09  9:57 ` paper42
2022-07-09 10:48 ` [PR PATCH] [Updated] " ScrelliCopter
2022-07-09 10:49 ` ScrelliCopter
2022-10-08  2:13 ` fsearch: update to 0.1.4 github-actions
2022-10-08  3:48 ` [PR PATCH] [Closed]: " ScrelliCopter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).