Github messages for voidlinux
 help / color / mirror / Atom feed
From: motorto <motorto@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] xmoto: fix musl build
Date: Sun, 09 Oct 2022 18:21:17 +0200	[thread overview]
Message-ID: <20221009162117.rH0IccR4muvVfAGtWGnsZMbJBUOEMbq9QpdRl922bs0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39836@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages xmoto
https://github.com/void-linux/void-packages/pull/39836

xmoto: fix musl build
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **Yes** , opened the app on the glibc , didn't test on musl


#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-glibc
  - armv6l * 


A patch file from https://github.com/void-linux/void-packages/pull/39836.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xmoto-39836.patch --]
[-- Type: text/x-diff, Size: 1501 bytes --]

From 32b4f6f41f4c9e47f4a174bfd0bbfa01466a0a30 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 9 Oct 2022 14:29:04 +0100
Subject: [PATCH] xmoto: fix musl build

---
 .../patches/fix_gettext_GNU-isms_musl.patch   | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 srcpkgs/xmoto/patches/fix_gettext_GNU-isms_musl.patch

diff --git a/srcpkgs/xmoto/patches/fix_gettext_GNU-isms_musl.patch b/srcpkgs/xmoto/patches/fix_gettext_GNU-isms_musl.patch
new file mode 100644
index 000000000000..f714af9e6fd7
--- /dev/null
+++ b/srcpkgs/xmoto/patches/fix_gettext_GNU-isms_musl.patch
@@ -0,0 +1,27 @@
+From 7ce512bf0242182306ceb75d7dbe2370aab838f8 Mon Sep 17 00:00:00 2001
+From: _yui <imbatman0xff@gmail.com>
+Date: Sun, 9 Oct 2022 14:48:05 +0300
+Subject: [PATCH] i18n: Don't use gettext GNU-isms with musl
+
+---
+ src/common/Locales.cpp | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/common/Locales.cpp b/src/common/Locales.cpp
+index 5ee395bd..680da00c 100644
+--- a/src/common/Locales.cpp
++++ b/src/common/Locales.cpp
+@@ -66,11 +66,13 @@ std::pair<std::string, std::string> Locales::changeLocale(
+           setlocale(LC_MESSAGES, NULL));
+ #endif
+ 
++#ifdef __GLIBC__
+   /* Make change known.  */
+   {
+     extern int _nl_msg_cat_cntr;
+     ++_nl_msg_cat_cntr;
+   }
++#endif
+ 
+   std::pair<std::string, std::string> locale_str(
+     locale.first == NULL ? std::string("") : std::string(locale.first),

  parent reply	other threads:[~2022-10-09 16:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 13:33 [PR PATCH] " motorto
2022-10-09 14:39 ` [PR REVIEW] " paper42
2022-10-09 15:25 ` motorto
2022-10-09 16:02 ` classabbyamp
2022-10-09 16:21 ` motorto [this message]
2022-10-09 16:21 ` motorto
2022-10-09 21:24 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221009162117.rH0IccR4muvVfAGtWGnsZMbJBUOEMbq9QpdRl922bs0@z \
    --to=motorto@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).