Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
Date: Mon, 10 Oct 2022 16:28:34 +0200	[thread overview]
Message-ID: <20221010142834.ALWnX0fgDzpzkr0aUpD2E3fpjLJ8RrzgNCDVEsh4v_k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39814@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273403437

Comment:
I don't understand why adding more dependencies to the build of `base-minimal` is a concern. We don't use it for bootstrapping; that's what `base-chroot` is for, and that's still a separate template. Maybe it adds a little more time to the build, but:
1. As far as CI and official builds are concerned, we ought to keep these dependencies in sync anyway, so any update to `base-minimal` ought to include corresponding updates to `-voidstrap` and `-system`; in that case, the build time is actually *reduced* by avoiding triple package installations.
2. Are people really building custom `base-minimal` on their own enough that we should be concerned that sombody winds up fetching the Linux kernel when building the package from the merged template? Meh.

Regarding the dependency chain: I recognize the potential for confusion or annoyance when trying to understand the full list of dependencies of the more featureful bases, but I'm not sure whether that's offset by the fact that chained dependencies makes it more obvious how the packages are related. We've seen a few questions asking for clarity about the differences, and `run_depends: base-minimal [...]` is pretty obvious in that regard. Either way, I can switch to the alternative approach (common variables in a common template to satisfy DRY while avoiding nested dependencies) if there is strong support there.

  parent reply	other threads:[~2022-10-10 14:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-08 15:09 [PR PATCH] " ahesford
2022-10-08 15:11 ` ahesford
2022-10-08 15:28 ` classabbyamp
2022-10-10 10:03 ` Duncaen
2022-10-10 10:03 ` Duncaen
2022-10-10 10:11 ` Duncaen
2022-10-10 10:12 ` Duncaen
2022-10-10 14:02 ` classabbyamp
2022-10-10 14:11 ` sgn
2022-10-10 14:28 ` ahesford [this message]
2022-10-10 14:47 ` Duncaen
2022-10-11 17:46 ` [PR PATCH] [Closed]: " ahesford
2022-10-11 17:47 ` ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221010142834.ALWnX0fgDzpzkr0aUpD2E3fpjLJ8RrzgNCDVEsh4v_k@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).