From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: singular: update to 4.3.1p2 (fix gcc 12 build)
Date: Mon, 10 Oct 2022 23:23:19 +0200 [thread overview]
Message-ID: <20221010212319.8n91OqgMvFGgNpwjbCloWqxxYqQOhcZUiRaVzzY4-sA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39866@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/39866#issuecomment-1273832793
Comment:
BTW, you could do something like this:
```diff
diff --git a/srcpkgs/singular/template b/srcpkgs/singular/template
index 441a5ba561..824345b27f 100644
--- a/srcpkgs/singular/template
+++ b/srcpkgs/singular/template
@@ -1,9 +1,8 @@
# Template file for 'singular'
pkgname=singular
-_patchver=p2
-_majver=4.3.1
-version=${_majver}${_patchver}
+version=4.3.1p2
revision=1
+_majver=${version%p*}
wrksrc=singular-${_majver}
build_style=gnu-configure
configure_args="--with-readline=ncurses
```
to avoid the xlint complain. I believe it is mandatory to have the full expanded version string in 'version=...' so that it can be easily parsed with grep and sed from templates (just grep "^version=", etc.). The `${version%p*}` thing should work ok for versions with a patchlevel as for versions without it.
next prev parent reply other threads:[~2022-10-10 21:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 14:47 [PR PATCH] " dkwo
2022-10-10 18:08 ` [PR PATCH] [Updated] " dkwo
2022-10-10 19:01 ` tornaria
2022-10-10 19:47 ` dkwo
2022-10-10 20:31 ` tornaria
2022-10-10 20:37 ` dkwo
2022-10-10 21:23 ` tornaria [this message]
2022-10-10 21:28 ` [PR PATCH] [Updated] " dkwo
2022-10-10 21:37 ` tornaria
2022-10-10 21:43 ` [PR PATCH] [Updated] " dkwo
2022-10-10 21:50 ` tornaria
2022-10-11 13:47 ` dkwo
2022-10-12 11:27 ` leahneukirchen
2022-10-12 12:08 ` tornaria
2022-10-12 12:16 ` leahneukirchen
2022-10-12 14:50 ` dkwo
2022-10-12 14:50 ` [PR PATCH] [Closed]: " dkwo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010212319.8n91OqgMvFGgNpwjbCloWqxxYqQOhcZUiRaVzzY4-sA@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).