* [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend
@ 2022-10-14 17:28 nyanpasu64
2022-10-14 21:05 ` paper42
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: nyanpasu64 @ 2022-10-14 17:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
There is a new pull request by nyanpasu64 against master on the void-packages repository
https://github.com/nyanpasu64/void-packages godot-update-pulse
https://github.com/void-linux/void-packages/pull/39957
godot: update to 3.5.1 and enable PulseAudio backend
Enabling Godot's PulseAudio driver fixes audio playback on PipeWire. Previously, the package's only enabled audio driver was ALSA, but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices prevents PipeWire apps from playing audio.
#### Testing the changes
- I tested the changes in this PR: **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- none, `./xbps-src -a armv6l pkg godot` claims godot can't cross-compile and I didn't try native building
Fixes #39936.
A patch file from https://github.com/void-linux/void-packages/pull/39957.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-update-pulse-39957.patch --]
[-- Type: text/x-diff, Size: 2832 bytes --]
From e3271e86c7a83675f13387e2535576c0e936c34e Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Fri, 14 Oct 2022 05:30:24 -0700
Subject: [PATCH 1/2] godot: enable PulseAudio backend
Enabling Godot's PulseAudio driver fixes audio playback on PipeWire.
Previously, the package's only enabled audio driver was ALSA, but Godot
on alsa-pipewire stutters, and Godot on HW ALSA devices prevents
PipeWire apps from playing audio.
---
srcpkgs/godot/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index 67f591a4924b..43c6619f0995 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -10,7 +10,7 @@ build_style=scons
# Use builtin bullet for now as it's too old in repos (needs 2.89)
# Toggle to not use builtin once bullet has been updated
make_build_args="platform=x11 tools=yes target=release_debug dev=no progress=no
- pulseaudio=no builtin_bullet=false builtin_libpng=false builtin_libvpx=false
+ builtin_bullet=false builtin_libpng=false builtin_libvpx=false
builtin_libwebp=false builtin_libogg=false builtin_libtheora=false
builtin_opus=false builtin_libvorbis=false builtin_enet=false
builtin_zlib=false builtin_freetype=false builtin_mbedtls=false
@@ -21,7 +21,7 @@ makedepends="
libXinerama-devel libXrender-devel libXrandr-devel libX11-devel
bullet-devel libpng-devel libvpx-devel libwebp-devel libogg-devel libtheora-devel
opus-devel opusfile-devel libvorbis-devel libenet-devel zlib-devel mbedtls-devel
- miniupnpc-devel pcre2-devel"
+ miniupnpc-devel pcre2-devel pulseaudio-devel"
short_desc="Multiplatform 2D and 3D engine"
maintainer="Nick Hahn <nick.hahn@hotmail.de>"
license="MIT"
From 3117970bb33691fdecbb786fa77aa31d9cb70b6f Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Fri, 14 Oct 2022 06:02:23 -0700
Subject: [PATCH 2/2] godot: update to 3.5.1.
---
srcpkgs/godot/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index 43c6619f0995..82309ba0d234 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,6 +1,6 @@
# Template file for 'godot'
pkgname=godot
-version=3.5
+version=3.5.1
revision=1
archs="x86_64* i686* aarch64* armv7* ppc64*"
wrksrc="${pkgname}-${version}-stable"
@@ -27,7 +27,7 @@ maintainer="Nick Hahn <nick.hahn@hotmail.de>"
license="MIT"
homepage="https://www.godotengine.org/"
distfiles="https://github.com/godotengine/${pkgname}/archive/${version}-stable.tar.gz"
-checksum=c65425e1d56a7097990f231c27c9271b7159f763dc59f0eaba9273633e59da36
+checksum=164523c1c8aef0b69b135645794f5bece3f63788556a56aa293c118cde457023
nocross=https://build.voidlinux.org/builders/armv7l_builder/builds/6342/steps/shell_3/logs/stdio
CFLAGS+=" -fPIE -fPIC"
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
@ 2022-10-14 21:05 ` paper42
2022-10-14 21:06 ` [PR REVIEW] " paper42
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-10-14 21:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#issuecomment-1279464399
Comment:
squash the commits to one and mention enabling the pulseaudio backend in the commit message body
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
2022-10-14 21:05 ` paper42
@ 2022-10-14 21:06 ` paper42
2022-10-14 21:07 ` paper42
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-10-14 21:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#discussion_r996154324
Comment:
I wouldn't delete this and just change it to yes. This PR doesn't make godot link libpulse, so I think there is a mistake that will become a failure if you change this to yes.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
2022-10-14 21:05 ` paper42
2022-10-14 21:06 ` [PR REVIEW] " paper42
@ 2022-10-14 21:07 ` paper42
2022-10-14 21:23 ` nyanpasu64
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-10-14 21:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#discussion_r996154596
Comment:
just a lint suggestion
```suggestion
distfiles="https://github.com/godotengine/godot/archive/${version}-stable.tar.gz"
```
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (2 preceding siblings ...)
2022-10-14 21:07 ` paper42
@ 2022-10-14 21:23 ` nyanpasu64
2022-10-14 21:42 ` paper42
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: nyanpasu64 @ 2022-10-14 21:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
New review comment by nyanpasu64 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#discussion_r996168736
Comment:
I can try setting `pulseaudio=yes` and rebuilding, when I have a chance. Though I don't think Godot with Pulse has a hard dependency on having libpulseaudio installed, since if I `sudo mv /usr/lib/libpulse.so.0.24.0{,~}` then try running `godot` in a terminal, I see output:
```
libpulse.so.0: cannot open shared object file: No such file or directory
libpulse.so.0: cannot open shared object file: No such file or directory
```
followed by opening an ALSA audio stream instead (alsa-pipewire which constantly `ALSA lib pcm.c:8568:(snd_pcm_recover) underrun occurred`, presumably a bug but I didn't investigate what's wrong yet).
What's the best approach for declaring in a package that it needs either libpulse or libalsa, or it can't output audio (but still runs)?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (3 preceding siblings ...)
2022-10-14 21:23 ` nyanpasu64
@ 2022-10-14 21:42 ` paper42
2022-10-14 21:47 ` paper42
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-10-14 21:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#discussion_r996177860
Comment:
Setting pulseaudio=yes builds it with pulseaudio unconditionally enabled which is what we want. It's possible it dlopens libpulse in which case the dependency wouldn't be detected automatically.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (4 preceding siblings ...)
2022-10-14 21:42 ` paper42
@ 2022-10-14 21:47 ` paper42
2022-10-14 21:49 ` nyanpasu64
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-10-14 21:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#discussion_r996180013
Comment:
I checked the source code and yes, they are dlopening it, that means it will use libpulse if you have it on your system, use alsa if you don't and the missing dependency is fine.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (5 preceding siblings ...)
2022-10-14 21:47 ` paper42
@ 2022-10-14 21:49 ` nyanpasu64
2022-10-14 22:08 ` paper42
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: nyanpasu64 @ 2022-10-14 21:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
New review comment by nyanpasu64 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#discussion_r996180797
Comment:
Godot has multiple audio drivers selected at runtime, and `pulseaudio=yes` *enables* the Pulse backend as a runtime *option* without turning off ALSA as an option if Pulse is absent:
```
godot --audio-driver test
Unknown audio driver 'test', aborting.
Valid options are 'PulseAudio', 'ALSA' and 'Dummy'.
```
And I think `pulseaudio=yes` is set by default: https://github.com/godotengine/godot/blob/3.5.1-stable/platform/x11/detect.py#L77
Should I add `pulseaudio=yes` or omit it altogether (which the flatpak build does, and enables PulseAudio)?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (6 preceding siblings ...)
2022-10-14 21:49 ` nyanpasu64
@ 2022-10-14 22:08 ` paper42
2022-10-14 22:11 ` [PR PATCH] [Updated] " nyanpasu64
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-10-14 22:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#discussion_r996189057
Comment:
I don't really have a preference
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (7 preceding siblings ...)
2022-10-14 22:08 ` paper42
@ 2022-10-14 22:11 ` nyanpasu64
2022-10-15 6:53 ` nyanpasu64
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: nyanpasu64 @ 2022-10-14 22:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
There is an updated pull request by nyanpasu64 against master on the void-packages repository
https://github.com/nyanpasu64/void-packages godot-update-pulse
https://github.com/void-linux/void-packages/pull/39957
godot: update to 3.5.1 and enable PulseAudio backend
Enabling Godot's PulseAudio driver fixes audio playback on PipeWire. Previously, the package's only enabled audio driver was ALSA, but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices prevents PipeWire apps from playing audio.
#### Testing the changes
- I tested the changes in this PR: **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- none, `./xbps-src -a armv6l pkg godot` claims godot can't cross-compile and I didn't try native building
Fixes #39936.
A patch file from https://github.com/void-linux/void-packages/pull/39957.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-update-pulse-39957.patch --]
[-- Type: text/x-diff, Size: 2399 bytes --]
From 2f11cd73c4dcd8f18ee1da4e544aece0f3e36e92 Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Fri, 14 Oct 2022 05:30:24 -0700
Subject: [PATCH] godot: update to 3.5.1.
Also enable the PulseAudio audio backend to fix audio playback on
PipeWire. Previously, the package's only enabled audio driver was ALSA,
but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices
prevents PipeWire apps from playing audio.
---
srcpkgs/godot/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index 67f591a4924b..c7d7640a1894 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,6 +1,6 @@
# Template file for 'godot'
pkgname=godot
-version=3.5
+version=3.5.1
revision=1
archs="x86_64* i686* aarch64* armv7* ppc64*"
wrksrc="${pkgname}-${version}-stable"
@@ -10,7 +10,7 @@ build_style=scons
# Use builtin bullet for now as it's too old in repos (needs 2.89)
# Toggle to not use builtin once bullet has been updated
make_build_args="platform=x11 tools=yes target=release_debug dev=no progress=no
- pulseaudio=no builtin_bullet=false builtin_libpng=false builtin_libvpx=false
+ builtin_bullet=false builtin_libpng=false builtin_libvpx=false
builtin_libwebp=false builtin_libogg=false builtin_libtheora=false
builtin_opus=false builtin_libvorbis=false builtin_enet=false
builtin_zlib=false builtin_freetype=false builtin_mbedtls=false
@@ -21,13 +21,13 @@ makedepends="
libXinerama-devel libXrender-devel libXrandr-devel libX11-devel
bullet-devel libpng-devel libvpx-devel libwebp-devel libogg-devel libtheora-devel
opus-devel opusfile-devel libvorbis-devel libenet-devel zlib-devel mbedtls-devel
- miniupnpc-devel pcre2-devel"
+ miniupnpc-devel pcre2-devel pulseaudio-devel"
short_desc="Multiplatform 2D and 3D engine"
maintainer="Nick Hahn <nick.hahn@hotmail.de>"
license="MIT"
homepage="https://www.godotengine.org/"
-distfiles="https://github.com/godotengine/${pkgname}/archive/${version}-stable.tar.gz"
-checksum=c65425e1d56a7097990f231c27c9271b7159f763dc59f0eaba9273633e59da36
+distfiles="https://github.com/godotengine/godot/archive/${version}-stable.tar.gz"
+checksum=164523c1c8aef0b69b135645794f5bece3f63788556a56aa293c118cde457023
nocross=https://build.voidlinux.org/builders/armv7l_builder/builds/6342/steps/shell_3/logs/stdio
CFLAGS+=" -fPIE -fPIC"
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (8 preceding siblings ...)
2022-10-14 22:11 ` [PR PATCH] [Updated] " nyanpasu64
@ 2022-10-15 6:53 ` nyanpasu64
2022-11-06 20:14 ` nyanpasu64
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: nyanpasu64 @ 2022-10-15 6:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by nyanpasu64 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#issuecomment-1279678157
Comment:
(I did not test the Void-specific patches on PPC or musl.)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (9 preceding siblings ...)
2022-10-15 6:53 ` nyanpasu64
@ 2022-11-06 20:14 ` nyanpasu64
2022-11-10 19:41 ` paper42
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: nyanpasu64 @ 2022-11-06 20:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New comment by nyanpasu64 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#issuecomment-1304884341
Comment:
bump
Is there anything blocking merging? I didn't test on PPC or musl, but the CI musl builds seem to work, is that enough?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (10 preceding siblings ...)
2022-11-06 20:14 ` nyanpasu64
@ 2022-11-10 19:41 ` paper42
2022-11-13 14:20 ` [PR PATCH] [Updated] " nyanpasu64
2022-11-13 15:54 ` [PR PATCH] [Merged]: " Johnnynator
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-11-10 19:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 176 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#issuecomment-1310809169
Comment:
could you rebase on top of master?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (11 preceding siblings ...)
2022-11-10 19:41 ` paper42
@ 2022-11-13 14:20 ` nyanpasu64
2022-11-13 15:54 ` [PR PATCH] [Merged]: " Johnnynator
13 siblings, 0 replies; 15+ messages in thread
From: nyanpasu64 @ 2022-11-13 14:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
There is an updated pull request by nyanpasu64 against master on the void-packages repository
https://github.com/nyanpasu64/void-packages godot-update-pulse
https://github.com/void-linux/void-packages/pull/39957
godot: update to 3.5.1 and enable PulseAudio backend
Enabling Godot's PulseAudio driver fixes audio playback on PipeWire. Previously, the package's only enabled audio driver was ALSA, but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices prevents PipeWire apps from playing audio.
#### Testing the changes
- I tested the changes in this PR: **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- none, `./xbps-src -a armv6l pkg godot` claims godot can't cross-compile and I didn't try native building
Fixes #39936.
A patch file from https://github.com/void-linux/void-packages/pull/39957.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-update-pulse-39957.patch --]
[-- Type: text/x-diff, Size: 2377 bytes --]
From 70fefa58a845485ae7b484cccbdad9ddea85715d Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Fri, 14 Oct 2022 05:30:24 -0700
Subject: [PATCH] godot: update to 3.5.1.
Also enable the PulseAudio audio backend to fix audio playback on
PipeWire. Previously, the package's only enabled audio driver was ALSA,
but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices
prevents PipeWire apps from playing audio.
---
srcpkgs/godot/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index df3ccd8ae3f6..aa4fb90e11fc 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,6 +1,6 @@
# Template file for 'godot'
pkgname=godot
-version=3.5
+version=3.5.1
revision=1
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
@@ -9,7 +9,7 @@ build_style=scons
# Use builtin bullet for now as it's too old in repos (needs 2.89)
# Toggle to not use builtin once bullet has been updated
make_build_args="platform=x11 tools=yes target=release_debug dev=no progress=no
- pulseaudio=no builtin_bullet=false builtin_libpng=false builtin_libvpx=false
+ builtin_bullet=false builtin_libpng=false builtin_libvpx=false
builtin_libwebp=false builtin_libogg=false builtin_libtheora=false
builtin_opus=false builtin_libvorbis=false builtin_enet=false
builtin_zlib=false builtin_freetype=false builtin_mbedtls=false
@@ -20,13 +20,13 @@ makedepends="
libXinerama-devel libXrender-devel libXrandr-devel libX11-devel
bullet-devel libpng-devel libvpx-devel libwebp-devel libogg-devel libtheora-devel
opus-devel opusfile-devel libvorbis-devel libenet-devel zlib-devel mbedtls-devel
- miniupnpc-devel pcre2-devel"
+ miniupnpc-devel pcre2-devel pulseaudio-devel"
short_desc="Multiplatform 2D and 3D engine"
maintainer="Nick Hahn <nick.hahn@hotmail.de>"
license="MIT"
homepage="https://www.godotengine.org/"
-distfiles="https://github.com/godotengine/${pkgname}/archive/${version}-stable.tar.gz"
-checksum=c65425e1d56a7097990f231c27c9271b7159f763dc59f0eaba9273633e59da36
+distfiles="https://github.com/godotengine/godot/archive/${version}-stable.tar.gz"
+checksum=164523c1c8aef0b69b135645794f5bece3f63788556a56aa293c118cde457023
nocross=https://build.voidlinux.org/builders/armv7l_builder/builds/6342/steps/shell_3/logs/stdio
CFLAGS+=" -fPIE -fPIC"
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Merged]: godot: update to 3.5.1 and enable PulseAudio backend
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
` (12 preceding siblings ...)
2022-11-13 14:20 ` [PR PATCH] [Updated] " nyanpasu64
@ 2022-11-13 15:54 ` Johnnynator
13 siblings, 0 replies; 15+ messages in thread
From: Johnnynator @ 2022-11-13 15:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]
There's a merged pull request on the void-packages repository
godot: update to 3.5.1 and enable PulseAudio backend
https://github.com/void-linux/void-packages/pull/39957
Description:
Enabling Godot's PulseAudio driver fixes audio playback on PipeWire. Previously, the package's only enabled audio driver was ALSA, but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices prevents PipeWire apps from playing audio.
#### Testing the changes
- I tested the changes in this PR: **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- none, `./xbps-src -a armv6l pkg godot` claims godot can't cross-compile and I didn't try native building
Fixes #39936.
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-11-13 15:54 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-14 17:28 [PR PATCH] godot: update to 3.5.1 and enable PulseAudio backend nyanpasu64
2022-10-14 21:05 ` paper42
2022-10-14 21:06 ` [PR REVIEW] " paper42
2022-10-14 21:07 ` paper42
2022-10-14 21:23 ` nyanpasu64
2022-10-14 21:42 ` paper42
2022-10-14 21:47 ` paper42
2022-10-14 21:49 ` nyanpasu64
2022-10-14 22:08 ` paper42
2022-10-14 22:11 ` [PR PATCH] [Updated] " nyanpasu64
2022-10-15 6:53 ` nyanpasu64
2022-11-06 20:14 ` nyanpasu64
2022-11-10 19:41 ` paper42
2022-11-13 14:20 ` [PR PATCH] [Updated] " nyanpasu64
2022-11-13 15:54 ` [PR PATCH] [Merged]: " Johnnynator
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).