[PR PATCH] New package: qodem-1.0.1

[PR PATCH] New package: qodem-1.0.1

[drichline]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

There is a new pull request by drichline against master on the void-packages repository

https://github.com/drichline/void-packages qodem-branch
https://github.com/void-linux/void-packages/pull/39922

New package: qodem-1.0.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
I apologize for the second pull-request; this is my first time contributing to Void

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/39922.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qodem-branch-39922.patch --]
[-- Type: text/x-diff, Size: 1200 bytes --]

From 9938b26ff39a5aa897a271e0db1f51e5e37efc48 Mon Sep 17 00:00:00 2001
From: Dakota Richline <43507179+drichline@users.noreply.github.com>
Date: Wed, 12 Oct 2022 22:41:02 -0400
Subject: [PATCH] New package: qodem-1.0.1

---
 srcpkgs/qodem/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/qodem/template

diff --git a/srcpkgs/qodem/template b/srcpkgs/qodem/template
new file mode 100644
index 000000000000..9507db5377bb
--- /dev/null
+++ b/srcpkgs/qodem/template
@@ -0,0 +1,19 @@
+# Template file for 'qodem'
+pkgname=qodem
+version=1.0.1
+revision=1
+build_style=gnu-makefile
+make_build_args="-f ./build/Makefile.generic"
+make_build_target="clean qodem"
+makedepends="ncurses-devel gpm-devel"
+short_desc="Qodem is a re-implementation of the Qmodem serial communication package"
+maintainer="Dakota Richline <drichline@protonmail.com>"
+license="Public Domain"
+homepage=https://qodem.sourceforge.net/
+distfiles=https://sourceforge.net/projects/qodem/files/qodem/${version}/qodem-${version}.tar.gz
+checksum=dedc73bfa73ced5c6193f1baf1ffe91f7accaad55a749240db326cebb9323359
+
+do_install(){
+	vbin ${wrksrc}/bin/qodem
+	vman ${wrksrc}/docs/qodem.1
+}

Re: [PR REVIEW] New package: qodem-1.0.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r994674400

Comment:
s/Qodem is a r/R/

Re: [PR REVIEW] New package: qodem-1.0.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r994675072

Comment:
As `xlint` says, just add the space between the function and the brace.

Re: [PR REVIEW] New package: qodem-1.0.1

[drichline]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by drichline on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r994881843

Comment:
> s/Qodem is a r/R/

Sorry, I'm not sure what you mean by this

Re: [PR PATCH] [Updated] New package: qodem-1.0.1

[drichline]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

There is an updated pull request by drichline against master on the void-packages repository

https://github.com/drichline/void-packages qodem-branch
https://github.com/void-linux/void-packages/pull/39922

New package: qodem-1.0.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
I apologize for the second pull-request; this is my first time contributing to Void

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/39922.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qodem-branch-39922.patch --]
[-- Type: text/x-diff, Size: 1200 bytes --]

From 6cef05fc6cf8613a97354b146e3088760776d22f Mon Sep 17 00:00:00 2001
From: Dakota Richline <43507179+drichline@users.noreply.github.com>
Date: Wed, 12 Oct 2022 22:41:02 -0400
Subject: [PATCH] New package: qodem-1.0.1

---
 srcpkgs/qodem/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/qodem/template

diff --git a/srcpkgs/qodem/template b/srcpkgs/qodem/template
new file mode 100644
index 000000000000..9507db5377bb
--- /dev/null
+++ b/srcpkgs/qodem/template
@@ -0,0 +1,19 @@
+# Template file for 'qodem'
+pkgname=qodem
+version=1.0.1
+revision=1
+build_style=gnu-makefile
+make_build_args="-f ./build/Makefile.generic"
+make_build_target="clean qodem"
+makedepends="ncurses-devel gpm-devel"
+short_desc="Qodem is a re-implementation of the Qmodem serial communication package"
+maintainer="Dakota Richline <drichline@protonmail.com>"
+license="Public Domain"
+homepage=https://qodem.sourceforge.net/
+distfiles=https://sourceforge.net/projects/qodem/files/qodem/${version}/qodem-${version}.tar.gz
+checksum=dedc73bfa73ced5c6193f1baf1ffe91f7accaad55a749240db326cebb9323359
+
+do_install(){
+	vbin ${wrksrc}/bin/qodem
+	vman ${wrksrc}/docs/qodem.1
+}

Re: [PR PATCH] [Updated] New package: qodem-1.0.1

[drichline]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

There is an updated pull request by drichline against master on the void-packages repository

https://github.com/drichline/void-packages qodem-branch
https://github.com/void-linux/void-packages/pull/39922

New package: qodem-1.0.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
I apologize for the second pull-request; this is my first time contributing to Void

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/39922.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qodem-branch-39922.patch --]
[-- Type: text/x-diff, Size: 1215 bytes --]

From 19f4cec3f9b57d10b1965300b5b624b3051f10c5 Mon Sep 17 00:00:00 2001
From: Dakota Richline <43507179+drichline@users.noreply.github.com>
Date: Wed, 12 Oct 2022 22:41:02 -0400
Subject: [PATCH] New package: qodem-1.0.1

---
 srcpkgs/qodem/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/qodem/template

diff --git a/srcpkgs/qodem/template b/srcpkgs/qodem/template
new file mode 100644
index 000000000000..83b7405dad69
--- /dev/null
+++ b/srcpkgs/qodem/template
@@ -0,0 +1,21 @@
+# Template file for 'qodem'
+pkgname=qodem
+version=1.0.1
+revision=1
+build_style=gnu-makefile
+make_build_args="-f ./build/Makefile.generic"
+make_build_target="clean qodem"
+makedepends="ncurses-devel gpm-devel"
+short_desc="Qodem is a re-implementation of the Qmodem serial communication package"
+maintainer="Dakota Richline <drichline@protonmail.com>"
+license="CC0-1.0"
+homepage=https://qodem.sourceforge.net/
+distfiles=https://sourceforge.net/projects/qodem/files/qodem/${version}/qodem-${version}.tar.gz
+checksum=dedc73bfa73ced5c6193f1baf1ffe91f7accaad55a749240db326cebb9323359
+
+do_install() {
+	vbin bin/qodem
+	vman docs/qodem.1
+	vlicense COPYING
+	vlicense CREDITS
+}

Re: [PR REVIEW] New package: qodem-1.0.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r995038216

Comment:
remove the "Qodem is a" from the line (it's written as a sed substitution)

Re: [PR REVIEW] New package: qodem-1.0.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r995044435

Comment:
this allows for setting the mirror and some other things
```suggestion
distfiles="${SOURCEFORGE_SITE}/qodem/qodem-${version}.tar.gz"
```

Re: [PR REVIEW] New package: qodem-1.0.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r995050829

Comment:
```suggestion
makedepends="ncurses-devel gpm-devel miniupnpc-devel SDL-devel"
```
based on the output of the configure stage

Re: [PR REVIEW] New package: qodem-1.0.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r995051034

Comment:
now that we're using the proper build style, we shouldn't override `do_install` and we don't need to install the bin/man manually
```suggestion
post_install() {
```

Re: [PR REVIEW] New package: qodem-1.0.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r995050558

Comment:
the source has a configure script in it, so we can use the `gnu-configure` build style instead
```suggestion
build_style=gnu-configure
```

Re: [PR REVIEW] New package: qodem-1.0.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r995251222

Comment:
Sorry, right.  It should read as "Re-implementation of the Qmodem serial communication package".

Re: [PR PATCH] [Updated] New package: qodem-1.0.1

[drichline]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

There is an updated pull request by drichline against master on the void-packages repository

https://github.com/drichline/void-packages qodem-branch
https://github.com/void-linux/void-packages/pull/39922

New package: qodem-1.0.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
I apologize for the second pull-request; this is my first time contributing to Void

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/39922.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qodem-branch-39922.patch --]
[-- Type: text/x-diff, Size: 1099 bytes --]

From 913bc65a94eefc6d1049ba16a94d30c3d68348ff Mon Sep 17 00:00:00 2001
From: Dakota Richline <43507179+drichline@users.noreply.github.com>
Date: Wed, 12 Oct 2022 22:41:02 -0400
Subject: [PATCH] New package: qodem-1.0.1

---
 srcpkgs/qodem/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/qodem/template

diff --git a/srcpkgs/qodem/template b/srcpkgs/qodem/template
new file mode 100644
index 000000000000..e1527db506a6
--- /dev/null
+++ b/srcpkgs/qodem/template
@@ -0,0 +1,18 @@
+# Template file for 'qodem'
+pkgname=qodem
+version=1.0.1
+revision=1
+build_style=gnu-configure
+makedepends="ncurses-devel gpm-devel miniupnpc-devel SDL-devel"
+short_desc="Re-implementation of the Qmodem serial communication package"
+maintainer="Dakota Richline <drichline@protonmail.com>"
+license="CC0-1.0"
+homepage=https://qodem.sourceforge.net/
+distfiles="${SOURCEFORGE_SITE}/qodem/qodem-${version}.tar.gz"
+checksum=dedc73bfa73ced5c6193f1baf1ffe91f7accaad55a749240db326cebb9323359
+
+post_install() {
+	vman docs/qodem.1
+	vlicense COPYING
+	vlicense CREDITS
+}

Re: [PR REVIEW] New package: qodem-1.0.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r996183887

Comment:
when I built it locally, it installed this file already

Re: [PR REVIEW] New package: qodem-1.0.1

[drichline]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by drichline on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r996185764

Comment:
In the future, I'll verify whether docs/licenses are installed by `configure` before doing it manually. Thank you again!!

Re: [PR PATCH] [Updated] New package: qodem-1.0.1

[drichline]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

There is an updated pull request by drichline against master on the void-packages repository

https://github.com/drichline/void-packages qodem-branch
https://github.com/void-linux/void-packages/pull/39922

New package: qodem-1.0.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
I apologize for the second pull-request; this is my first time contributing to Void

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/39922.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qodem-branch-39922.patch --]
[-- Type: text/x-diff, Size: 1078 bytes --]

From 4cbb2453e9605278eb4719630c86d91646f44a1e Mon Sep 17 00:00:00 2001
From: Dakota Richline <43507179+drichline@users.noreply.github.com>
Date: Wed, 12 Oct 2022 22:41:02 -0400
Subject: [PATCH] New package: qodem-1.0.1

---
 srcpkgs/qodem/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/qodem/template

diff --git a/srcpkgs/qodem/template b/srcpkgs/qodem/template
new file mode 100644
index 000000000000..d1b74cabc048
--- /dev/null
+++ b/srcpkgs/qodem/template
@@ -0,0 +1,17 @@
+# Template file for 'qodem'
+pkgname=qodem
+version=1.0.1
+revision=1
+build_style=gnu-configure
+makedepends="ncurses-devel gpm-devel miniupnpc-devel SDL-devel"
+short_desc="Re-implementation of the Qmodem serial communication package"
+maintainer="Dakota Richline <drichline@protonmail.com>"
+license="CC0-1.0"
+homepage=https://qodem.sourceforge.net/
+distfiles="${SOURCEFORGE_SITE}/qodem/qodem-${version}.tar.gz"
+checksum=dedc73bfa73ced5c6193f1baf1ffe91f7accaad55a749240db326cebb9323359
+
+post_install() {
+	vlicense COPYING
+	vlicense CREDITS
+}

Re: [PR REVIEW] New package: qodem-1.0.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39922#discussion_r996188581

Comment:
what I like to do is `xbps-src install pkgname` (which runs everything up to `post_install()`, then look at what's in `masterdir/destdir/pkgname-version/` (`tree` is useful for this), then `xbps-src pkg pkgname` to finish building

alternatively, there's `xls pkgname` from the `xtools` package if you want to list files from the finished result

Re: [PR PATCH] [Merged]: New package: qodem-1.0.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

There's a merged pull request on the void-packages repository

New package: qodem-1.0.1
https://github.com/void-linux/void-packages/pull/39922

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
I apologize for the second pull-request; this is my first time contributing to Void

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)