From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: Use unique names for bulk update commands
Date: Sat, 15 Oct 2022 15:56:27 +0200 [thread overview]
Message-ID: <20221015135627.hBX5ZX2FWNHS969Re87ezqHp4vyvrowU5UKsRhud-Fw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39969@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
There's a closed pull request on the void-packages repository
Use unique names for bulk update commands
https://github.com/void-linux/void-packages/pull/39969
Description:
A regression introduced in 4c43245e0b (#37700) is causing the `xbps-src update-sys` command to skip the final step of installing the updated packages.
This happens because the `cmd` variable name clashes with a loop variable used in common/environment/setup/install.sh script [line 16](/void-linux/void-packages/blob/4c43245e0b989fa85fe57090a1a584d6e6650546/common/environment/setup/install.sh#L16). Thus the `"$cmd" == installed` comparison ([common/xbps-src/shutils/bulk.sh line 122](/void-linux/void-packages/blob/4c43245e0b989fa85fe57090a1a584d6e6650546/common/xbps-src/shutils/bulk.sh#L122)) fails and the installation step is skipped.
Using unique variable names in `bulk.sh` avoids this problem.
#### Testing the changes
- I tested the changes in this PR: **YES**
next prev parent reply other threads:[~2022-10-15 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 13:45 [PR PATCH] " heindsight
2022-10-15 13:56 ` Duncaen [this message]
2022-10-15 13:57 ` Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221015135627.hBX5ZX2FWNHS969Re87ezqHp4vyvrowU5UKsRhud-Fw@z \
--to=duncaen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).