From: meator <meator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: New package: dry-0.11.1
Date: Sun, 16 Oct 2022 20:14:11 +0200 [thread overview]
Message-ID: <20221016181411.vpoxMmJ9FF9mkgBWoPKSkNjEnI2qq8FE_EyDWsn13Kw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38106@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
There's a closed pull request on the void-packages repository
New package: dry-0.11.1
https://github.com/void-linux/void-packages/pull/38106
Description:
I've included a flag in `go_ldflags` that sets the version, but `dry` also expects `github.com/moncho/dry/version.GITCOMMIT` to contain the git revision of `dry`. I haven't included it because using git to retreive it from the version tag or explicitly specifying the commit in a custom variable isn't worth it in my opinion. Because of this, `dry -v` now shows:
```
dry version 0.11.1, build
```
without a newline at the end.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
prev parent reply other threads:[~2022-10-16 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 12:36 [PR PATCH] " meator
2022-07-17 16:39 ` classabbyamp
2022-07-17 17:08 ` [PR PATCH] [Updated] " meator
2022-07-17 17:09 ` meator
2022-10-16 2:14 ` github-actions
2022-10-16 18:14 ` meator [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221016181411.vpoxMmJ9FF9mkgBWoPKSkNjEnI2qq8FE_EyDWsn13Kw@z \
--to=meator@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).