From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: looking-glass-5.0.1
Date: Wed, 19 Oct 2022 06:48:50 +0200 [thread overview]
Message-ID: <20221019044850.2nVneK1MFVjzZZDKQlyGP3N7XF3mnYxQb5r99MuWKuw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40031@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r998935955
Comment:
```
cmake make gcc
```
already included in the build chroot, don't specify them (gcc: by default; make: not needed, void's cmake defaults to ninja; cmake: already included by the build style)
---
```
pkg-config
```
should be in `hostmakedepends`
---
```
libglapi
```
covered by `MesaLib-devel`
---
```
libwaylandpp dejavu-fonts-ttf
```
are these actually needed at build time?
---
```
libglib-devel nettle-devel gmp-devel fontconfig-devel spice-devel ibX11-devel libXfixes-devel libXi-devel libXinerama-devel libXcursor-devel libXpresent-devel libxkbcommon-devel libwaylandpp-devel libXScrnSaver-devel MesaLib-devel
```
the rest are probably fine
next prev parent reply other threads:[~2022-10-19 4:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 3:50 [PR PATCH] " lay-by
2022-10-19 4:48 ` [PR REVIEW] " classabbyamp
2022-10-19 4:48 ` classabbyamp
2022-10-19 4:48 ` classabbyamp [this message]
2022-10-19 5:14 ` [PR PATCH] [Updated] " lay-by
2022-10-19 5:18 ` [PR REVIEW] " lay-by
2023-01-18 2:00 ` github-actions
2023-01-20 22:48 ` [PR REVIEW] " JamiKettunen
2023-01-20 22:48 ` JamiKettunen
2023-01-20 22:48 ` JamiKettunen
2023-01-20 22:48 ` JamiKettunen
2023-01-21 2:11 ` JamiKettunen
2023-01-21 2:12 ` JamiKettunen
2023-04-22 1:53 ` github-actions
2023-05-07 1:56 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019044850.2nVneK1MFVjzZZDKQlyGP3N7XF3mnYxQb5r99MuWKuw@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).