From: Phicem <Phicem@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [WIP] CalculiX-2.20
Date: Sun, 23 Oct 2022 21:56:45 +0200 [thread overview]
Message-ID: <20221023195645.WXC3eR_Q_FuXtJa9s7oOZHbR8x6M5MEahpVoAdTJiM8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39984@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
New review comment by Phicem on void-packages repository
https://github.com/void-linux/void-packages/pull/39984#discussion_r1002762706
Comment:
Hmm, I think I understand most of the suggested change here, but not all of it.
I understand that the `-02` flag is useless because it is already defined in `$XBPS_CFLAGS` and thus implicitely used.
I guess removing `-Wall` only suppresses warnings (which are not very useful in an automated build process), and can be safely removed, so I think I undestand this one as well. (I am correct?)
However I don't understand the removal of the `-Wno-narrowing` flag. I'm not very familiar with this flag but I thought it could remove errors (and not only warnings), and thus could change the build result. Why did you suggest removing this flag? Is it because it is considered that software should not be built when there are narrowing errors? Or is there another reason?
next prev parent reply other threads:[~2022-10-23 19:56 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 10:05 [PR PATCH] CalculiX-2.20 Phicem
2022-10-16 10:21 ` [PR REVIEW] CalculiX-2.20 classabbyamp
2022-10-16 10:21 ` classabbyamp
2022-10-16 11:22 ` Phicem
2022-10-16 11:23 ` paper42
2022-10-16 11:23 ` paper42
2022-10-16 11:37 ` Phicem
2022-10-16 11:46 ` Phicem
2022-10-16 18:27 ` [PR PATCH] [Updated] CalculiX-2.20 Phicem
2022-10-16 18:30 ` [PR REVIEW] CalculiX-2.20 Phicem
2022-10-16 18:33 ` CalculiX-2.20 Phicem
2022-10-16 19:38 ` [PR PATCH] [Updated] CalculiX-2.20 Phicem
2022-10-16 19:40 ` CalculiX-2.20 Phicem
2022-10-16 20:41 ` CalculiX-2.20 Phicem
2022-10-17 23:56 ` [PR REVIEW] CalculiX-2.20 classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-17 23:56 ` classabbyamp
2022-10-18 2:34 ` ahesford
2022-10-18 2:34 ` ahesford
2022-10-18 6:38 ` 0x5c
2022-10-18 6:42 ` classabbyamp
2022-10-22 7:49 ` CalculiX-2.20 Phicem
2022-10-22 8:07 ` [PR REVIEW] [WIP] CalculiX-2.20 Phicem
2022-10-22 8:10 ` Phicem
2022-10-22 8:48 ` Phicem
2022-10-22 8:50 ` [PR PATCH] [Updated] " Phicem
2022-10-22 9:03 ` [PR REVIEW] " Phicem
2022-10-22 11:55 ` 0x5c
2022-10-22 11:55 ` 0x5c
2022-10-22 19:17 ` Phicem
2022-10-23 7:11 ` 0x5c
2022-10-23 9:35 ` Phicem
2022-10-23 9:35 ` [PR PATCH] [Updated] " Phicem
2022-10-23 9:59 ` [PR REVIEW] " Phicem
2022-10-23 10:00 ` [PR PATCH] [Updated] " Phicem
2022-10-23 10:00 ` Phicem
2022-10-23 11:20 ` Phicem
2022-10-23 11:39 ` Phicem
2022-10-23 11:42 ` Phicem
2022-10-23 13:14 ` [PR REVIEW] " ahesford
2022-10-23 13:15 ` ahesford
2022-10-23 13:25 ` ahesford
2022-10-23 16:50 ` [PR PATCH] [Updated] " Phicem
2022-10-23 16:52 ` [PR REVIEW] " Phicem
2022-10-23 18:25 ` [PR PATCH] [Updated] " Phicem
2022-10-23 18:29 ` [PR REVIEW] " Phicem
2022-10-23 18:49 ` Phicem
2022-10-23 18:51 ` [PR PATCH] [Updated] " Phicem
2022-10-23 19:56 ` Phicem [this message]
2022-10-23 20:02 ` [PR REVIEW] " classabbyamp
2022-10-26 6:37 ` Phicem
2022-10-26 7:45 ` [PR PATCH] [Updated] " Phicem
2022-10-26 7:47 ` Phicem
2022-10-26 7:55 ` Phicem
2022-10-26 7:56 ` Phicem
2022-10-26 8:02 ` Phicem
2022-10-26 8:03 ` Phicem
2022-10-26 8:13 ` Phicem
2022-10-26 8:13 ` Phicem
2022-10-26 9:35 ` [PR REVIEW] " Phicem
2022-10-26 9:37 ` [PR PATCH] [Updated] " Phicem
2022-10-26 9:41 ` Phicem
2022-10-26 10:01 ` Phicem
2022-10-26 10:46 ` Phicem
2022-10-26 16:42 ` Phicem
2022-10-26 19:18 ` Phicem
2022-10-26 19:25 ` [PR REVIEW] " Phicem
2022-10-30 20:31 ` [PR PATCH] [Updated] " Phicem
2022-10-31 14:17 ` Phicem
2022-10-31 14:25 ` Phicem
2022-10-31 16:45 ` Phicem
2022-11-04 21:44 ` New package: CalculiX-2.20 classabbyamp
2022-11-04 21:44 ` classabbyamp
2022-11-05 15:38 ` Phicem
2022-11-05 15:38 ` [PR PATCH] [Updated] " Phicem
2022-11-05 17:48 ` Phicem
2023-02-04 1:58 ` github-actions
2023-02-05 18:21 ` [PR PATCH] [Updated] " Phicem
2023-05-08 1:52 ` github-actions
2023-05-22 1:57 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221023195645.WXC3eR_Q_FuXtJa9s7oOZHbR8x6M5MEahpVoAdTJiM8@z \
--to=phicem@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).