Github messages for voidlinux
 help / color / mirror / Atom feed
From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] webkit2gtk: remove webkit2gtk-common subpackage
Date: Wed, 26 Oct 2022 11:17:38 +0200	[thread overview]
Message-ID: <20221026091738.VJ4cryUzenLblKHDPDdVk0xDD73CzotO9akniG_IbxA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40103@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40103#discussion_r1005424844

Comment:
It grabbed the vlicense installed by webkit2gtk and moved it to webkit2gtk-common, which will conflict with webkit2gtk. Is that an issue?

(Even if it doesn't matter from a user perspective since, worst case senario, they just end up with a missing license file that shouldn't have been removed, I imagine it probably would matter in the CI when it checks for file conflicts)

  parent reply	other threads:[~2022-10-26  9:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22 12:02 [PR PATCH] webkit2gtk: remove common oreo639
2022-10-22 12:03 ` [PR PATCH] [Updated] " oreo639
2022-10-22 12:09 ` oreo639
2022-10-22 12:19 ` oreo639
2022-10-22 12:20 ` [PR REVIEW] " sgn
2022-10-22 12:25 ` [PR PATCH] [Updated] " oreo639
2022-10-22 12:35 ` oreo639
2022-10-22 20:20 ` oreo639
2022-10-22 20:25 ` oreo639
2022-10-22 20:27 ` oreo639
2022-10-22 20:27 ` oreo639
2022-10-22 20:52 ` [PR PATCH] [Updated] webkit2gtk: remove common subpkg oreo639
2022-10-22 20:52 ` oreo639
2022-10-22 20:56 ` [PR PATCH] [Updated] webkit2gtk: remove webkit2gtk-common subpackage oreo639
2022-10-22 20:57 ` oreo639
2022-10-22 23:21 ` oreo639
2022-10-23  3:11 ` oreo639
2022-10-26  8:47 ` [PR REVIEW] " paper42
2022-10-26  8:49 ` paper42
2022-10-26  9:12 ` oreo639
2022-10-26  9:12 ` oreo639
2022-10-26  9:14 ` [PR PATCH] [Updated] " oreo639
2022-10-26  9:17 ` [PR REVIEW] " oreo639
2022-10-26  9:17 ` oreo639 [this message]
2022-10-26  9:18 ` oreo639
2022-10-26 18:35 ` paper42
2022-10-26 18:41 ` oreo639
2022-10-26 18:42 ` [PR PATCH] [Updated] " oreo639
2022-10-26 18:58 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221026091738.VJ4cryUzenLblKHDPDdVk0xDD73CzotO9akniG_IbxA@z \
    --to=oreo639@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).