Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: didder-1.1.0
@ 2022-07-31  8:21 kotajacob
  2022-07-31  8:57 ` [PR REVIEW] " classabbyamp
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: kotajacob @ 2022-07-31  8:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

There is a new pull request by kotajacob against master on the void-packages repository

https://github.com/kotajacob/void-packages didder
https://github.com/void-linux/void-packages/pull/38387

New package: didder-1.1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

It's a nice little tool for generating dithered images. I use it on my website occasionally for an interesting look and bandwidth savings.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-libc


A patch file from https://github.com/void-linux/void-packages/pull/38387.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-didder-38387.patch --]
[-- Type: text/x-diff, Size: 1359 bytes --]

From a175dced79f2d5137b2f2bc59a75c592d4e87794 Mon Sep 17 00:00:00 2001
From: Dakota Walsh <kota@nilsu.org>
Date: Sun, 31 Jul 2022 20:17:35 +1200
Subject: [PATCH] New package: didder-1.1.0

---
 srcpkgs/didder/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/didder/template

diff --git a/srcpkgs/didder/template b/srcpkgs/didder/template
new file mode 100644
index 000000000000..35fce786c630
--- /dev/null
+++ b/srcpkgs/didder/template
@@ -0,0 +1,22 @@
+# Template file for 'didder'
+pkgname=didder
+version=1.1.0
+revision=1
+build_style=go
+go_import_path="github.com/makeworld-the-better-one/didder"
+go_ldflags="-s -w -X main.version=${version} -X main.builtBy=Void"
+hostmakedepends="pandoc"
+short_desc="Command-line image dithering tool"
+maintainer="Dakota Walsh <kota@nilsu.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/makeworld-the-better-one/didder"
+changelog="https://github.com/makeworld-the-better-one/didder/blob/main/CHANGELOG.md"
+distfiles="https://github.com/makeworld-the-better-one/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=a850ae54125ed2aa1be54b1cc11481c00094d346861bd59014d621dc48f9aed6
+
+post_install() {
+	pandoc didder.1.md -s -t man -o didder.1
+	sed -i 's/VERSION/$(VERSION)/g' didder.1
+	sed -i 's/DATE/$(DATE)/g' didder.1
+	vman didder.1
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
@ 2022-07-31  8:57 ` classabbyamp
  2022-07-31  8:57 ` classabbyamp
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2022-07-31  8:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#discussion_r933951340

Comment:
```suggestion
go_ldflags="-X main.version=${version} -X main.builtBy=Void"
```
xbps-src should strip binaries itself

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
                   ` (2 preceding siblings ...)
  2022-07-31  8:57 ` classabbyamp
@ 2022-07-31  8:57 ` classabbyamp
  2022-07-31  9:10 ` [PR PATCH] [Updated] " kotajacob
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2022-07-31  8:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#discussion_r933952241

Comment:
```roff
.TH "DIDDER" "1" "$(DATE)" "didder $(VERSION)" "User Manual"
```
this isn't doing what you think it is. those are `make` variable substitutions.

```suggestion
	sed -i "s/VERSION/${version}/g" didder.1
	_date="$(date --utc --date "@$SOURCE_DATE_EPOCH" "+%B %d, %Y")"
	sed -i "s/DATE/${_date}/g" didder.1
```
this should insert the actual date and version

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
  2022-07-31  8:57 ` [PR REVIEW] " classabbyamp
  2022-07-31  8:57 ` classabbyamp
@ 2022-07-31  8:57 ` classabbyamp
  2022-07-31  8:57 ` classabbyamp
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2022-07-31  8:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#discussion_r933951504

Comment:
```suggestion
distfiles="https://github.com/makeworld-the-better-one/didder/archive/refs/tags/v${version}.tar.gz"
```

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
  2022-07-31  8:57 ` [PR REVIEW] " classabbyamp
@ 2022-07-31  8:57 ` classabbyamp
  2022-07-31  8:57 ` classabbyamp
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2022-07-31  8:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#discussion_r933951419

Comment:
```suggestion
license="GPL-3.0-only"
```
does not mention the "or any later version" language in the repo

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
                   ` (3 preceding siblings ...)
  2022-07-31  8:57 ` classabbyamp
@ 2022-07-31  9:10 ` kotajacob
  2022-07-31  9:10 ` [PR REVIEW] " kotajacob
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kotajacob @ 2022-07-31  9:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

There is an updated pull request by kotajacob against master on the void-packages repository

https://github.com/kotajacob/void-packages didder
https://github.com/void-linux/void-packages/pull/38387

New package: didder-1.1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

It's a nice little tool for generating dithered images. I use it on my website occasionally for an interesting look and bandwidth savings.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-libc


A patch file from https://github.com/void-linux/void-packages/pull/38387.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-didder-38387.patch --]
[-- Type: text/x-diff, Size: 1413 bytes --]

From 414175ddeffcc8a87982f39e3b720c75a147ce7f Mon Sep 17 00:00:00 2001
From: Dakota Walsh <kota@nilsu.org>
Date: Sun, 31 Jul 2022 20:17:35 +1200
Subject: [PATCH] New package: didder-1.1.0

---
 srcpkgs/didder/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/didder/template

diff --git a/srcpkgs/didder/template b/srcpkgs/didder/template
new file mode 100644
index 000000000000..641dcc060917
--- /dev/null
+++ b/srcpkgs/didder/template
@@ -0,0 +1,23 @@
+# Template file for 'didder'
+pkgname=didder
+version=1.1.0
+revision=1
+build_style=go
+go_import_path="github.com/makeworld-the-better-one/didder"
+go_ldflags="-X main.version=${version} -X main.builtBy=Void"
+hostmakedepends="pandoc"
+short_desc="Command-line image dithering tool"
+maintainer="Dakota Walsh <kota@nilsu.org>"
+license="GPL-3.0-only"
+homepage="https://github.com/makeworld-the-better-one/didder"
+changelog="https://github.com/makeworld-the-better-one/didder/blob/main/CHANGELOG.md"
+distfiles="https://github.com/makeworld-the-better-one/didder/archive/refs/tags/v${version}.tar.gz"
+checksum=a850ae54125ed2aa1be54b1cc11481c00094d346861bd59014d621dc48f9aed6
+
+post_install() {
+	pandoc didder.1.md -s -t man -o didder.1
+	sed -i "s/VERSION/${version}/g" didder.1
+	_date="$(date --utc --date "@$SOURCE_DATE_EPOCH" "+%B %d, %Y")"
+	sed -i "s/DATE/${_date}/g" didder.1
+	vman didder.1
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
                   ` (4 preceding siblings ...)
  2022-07-31  9:10 ` [PR PATCH] [Updated] " kotajacob
@ 2022-07-31  9:10 ` kotajacob
  2022-07-31  9:12 ` kotajacob
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kotajacob @ 2022-07-31  9:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by kotajacob on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#discussion_r933954169

Comment:
Gotcha changed!

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
                   ` (5 preceding siblings ...)
  2022-07-31  9:10 ` [PR REVIEW] " kotajacob
@ 2022-07-31  9:12 ` kotajacob
  2022-07-31  9:13 ` kotajacob
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kotajacob @ 2022-07-31  9:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by kotajacob on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#discussion_r933954397

Comment:
Changed! I always thought maybe it was "or-later" unless specified otherwise...

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
                   ` (6 preceding siblings ...)
  2022-07-31  9:12 ` kotajacob
@ 2022-07-31  9:13 ` kotajacob
  2022-07-31  9:13 ` kotajacob
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kotajacob @ 2022-07-31  9:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New review comment by kotajacob on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#discussion_r933954463

Comment:
Changed!

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
                   ` (7 preceding siblings ...)
  2022-07-31  9:13 ` kotajacob
@ 2022-07-31  9:13 ` kotajacob
  2022-10-30  2:14 ` github-actions
  2022-11-13  8:50 ` [PR PATCH] [Closed]: " github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: kotajacob @ 2022-07-31  9:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by kotajacob on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#discussion_r933954547

Comment:
Thanks, didn't realize that wasn't even working!

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
                   ` (8 preceding siblings ...)
  2022-07-31  9:13 ` kotajacob
@ 2022-10-30  2:14 ` github-actions
  2022-11-13  8:50 ` [PR PATCH] [Closed]: " github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2022-10-30  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/38387#issuecomment-1296065913

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Closed]: New package: didder-1.1.0
  2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
                   ` (9 preceding siblings ...)
  2022-10-30  2:14 ` github-actions
@ 2022-11-13  8:50 ` github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2022-11-13  8:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

There's a closed pull request on the void-packages repository

New package: didder-1.1.0
https://github.com/void-linux/void-packages/pull/38387

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

It's a nice little tool for generating dithered images. I use it on my website occasionally for an interesting look and bandwidth savings.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-libc


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-11-13  8:50 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-31  8:21 [PR PATCH] New package: didder-1.1.0 kotajacob
2022-07-31  8:57 ` [PR REVIEW] " classabbyamp
2022-07-31  8:57 ` classabbyamp
2022-07-31  8:57 ` classabbyamp
2022-07-31  8:57 ` classabbyamp
2022-07-31  9:10 ` [PR PATCH] [Updated] " kotajacob
2022-07-31  9:10 ` [PR REVIEW] " kotajacob
2022-07-31  9:12 ` kotajacob
2022-07-31  9:13 ` kotajacob
2022-07-31  9:13 ` kotajacob
2022-10-30  2:14 ` github-actions
2022-11-13  8:50 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).