Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] brightnessctl: added elogind build option
@ 2022-07-28 16:11 epixtm
  2022-10-27  2:13 ` github-actions
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: epixtm @ 2022-07-28 16:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

There is a new pull request by epixtm against master on the void-packages repository

https://github.com/epixtm/void-packages brightnessctl
https://github.com/void-linux/void-packages/pull/38338

brightnessctl: added elogind build option
#### Testing the changes
- I tested the changes in this PR: **YES**

- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (amd64-glibc)

This option allows brightnessctl to access backlight devices using the `(e)logind` api. First PR, and I wasn't sure if a revbump was necessary. If I need to change anything lmk.

A patch file from https://github.com/void-linux/void-packages/pull/38338.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-brightnessctl-38338.patch --]
[-- Type: text/x-diff, Size: 1245 bytes --]

From be053e5b656ede54873630cf8de9165f7bed5830 Mon Sep 17 00:00:00 2001
From: Epix <epixtm@protonmail.com>
Date: Thu, 28 Jul 2022 11:03:45 -0500
Subject: [PATCH] brightnessctl: added elogind build option

---
 srcpkgs/brightnessctl/template | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/srcpkgs/brightnessctl/template b/srcpkgs/brightnessctl/template
index 99a6bce0f69d..f229e960756c 100644
--- a/srcpkgs/brightnessctl/template
+++ b/srcpkgs/brightnessctl/template
@@ -4,8 +4,11 @@ version=0.5.1
 revision=1
 build_style=gnu-makefile
 make_use_env=yes
+make_build_args="$(vopt_if elogind ENABLE_SYSTEMD=1)"
 make_install_args="UDEVDIR=/usr/lib/udev/rules.d"
 hostmakedepends="pkg-config"
+makedepends="$(vopt_if elogind elogind-devel)"
+depends="$(vopt_if elogind libelogind)"
 short_desc="Read and control device brightness"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
@@ -13,6 +16,9 @@ homepage="https://github.com/Hummer12007/brightnessctl"
 distfiles="https://github.com/Hummer12007/brightnessctl/archive/${version}.tar.gz"
 checksum=a68869e23f56ac4f2e28f1783002810ddbf10f95e1af9b48b2912fb169f46994
 
+build_options="elogind"
+desc_option_elogind="Enable logind support"
+
 post_install() {
 	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: brightnessctl: added elogind build option
  2022-07-28 16:11 [PR PATCH] brightnessctl: added elogind build option epixtm
@ 2022-10-27  2:13 ` github-actions
  2022-10-30 23:37 ` epixtm
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2022-10-27  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/38338#issuecomment-1292872328

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: brightnessctl: added elogind build option
  2022-07-28 16:11 [PR PATCH] brightnessctl: added elogind build option epixtm
  2022-10-27  2:13 ` github-actions
@ 2022-10-30 23:37 ` epixtm
  2023-01-30  1:57 ` github-actions
  2023-02-13  2:01 ` [PR PATCH] [Closed]: " github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: epixtm @ 2022-10-30 23:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by epixtm on void-packages repository

https://github.com/void-linux/void-packages/pull/38338#issuecomment-1296379674

Comment:
bump

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: brightnessctl: added elogind build option
  2022-07-28 16:11 [PR PATCH] brightnessctl: added elogind build option epixtm
  2022-10-27  2:13 ` github-actions
  2022-10-30 23:37 ` epixtm
@ 2023-01-30  1:57 ` github-actions
  2023-02-13  2:01 ` [PR PATCH] [Closed]: " github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2023-01-30  1:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/38338#issuecomment-1407873333

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: brightnessctl: added elogind build option
  2022-07-28 16:11 [PR PATCH] brightnessctl: added elogind build option epixtm
                   ` (2 preceding siblings ...)
  2023-01-30  1:57 ` github-actions
@ 2023-02-13  2:01 ` github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2023-02-13  2:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

There's a closed pull request on the void-packages repository

brightnessctl: added elogind build option
https://github.com/void-linux/void-packages/pull/38338

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (amd64-glibc)

This option allows brightnessctl to access backlight devices using the `(e)logind` api. First PR, and I wasn't sure if a revbump was necessary. If I need to change anything lmk.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-02-13  2:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 16:11 [PR PATCH] brightnessctl: added elogind build option epixtm
2022-10-27  2:13 ` github-actions
2022-10-30 23:37 ` epixtm
2023-01-30  1:57 ` github-actions
2023-02-13  2:01 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).