Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] libgdal: update to 3.5.2
Date: Tue, 01 Nov 2022 07:34:38 +0100	[thread overview]
Message-ID: <20221101063438.D0oGXA9snJ4miIdZufWEIxN2ylinpYwuALcvEzY0BYM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40225@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2404 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40225#discussion_r1010111716

Comment:
just for fun, I had a go at updating grass:

```patch
diff --git a/srcpkgs/grass/template b/srcpkgs/grass/template
index bccd691a81..98b733528b 100644
--- a/srcpkgs/grass/template
+++ b/srcpkgs/grass/template
@@ -1,30 +1,30 @@
 # Template file for 'grass'
 pkgname=grass
-version=7.6.1
-revision=4
+version=8.2.0
+revision=1
 _binver=${version//./}
 _binver=${_binver:0:2}
 build_style=gnu-configure
-configure_args="--prefix=\${DESTDIR}/usr/share --bindir=\${DESTDIR}/usr/bin
+configure_args="--prefix=/usr/share --bindir=/usr/bin
  --with-freetype-includes=${XBPS_CROSS_BASE}/usr/include/freetype2"
-hostmakedepends="flex libgdal-tools pkg-config python-numpy tar"
+hostmakedepends="flex libgdal-tools pkg-config python3-numpy tar"
 makedepends="proj-devel tiff-devel libgdal-devel sqlite-devel
- fftw-devel cairo-devel glu-devel wxPython-devel"
-depends="python-numpy wxPython"
+ fftw-devel cairo-devel glu-devel wxPython4 python3-six"
+depends="python3-numpy wxPython4 python3-six"
 short_desc="Geographic Resources Analysis Support System - GIS"
 maintainer="Alex Jarosch <research@alexj.at>"
 license="GPL-2.0-or-later"
 homepage="https://grass.osgeo.org/"
 distfiles="https://grass.osgeo.org/grass${_binver}/source/${pkgname}-${version}.tar.gz"
-checksum=9e25c99cafd16ed8f5e2dca75b5a10dc2af0568dbedf3fc39f1c5a0a9c840b0b
-python_version=2 #unverified
+checksum=621c3304a563be19c0220ae28f931a5e9ba74a53218c5556cd3f7fbfcca33a80
+python_version=3
 nocross="tries to execute target binaries"
 
 post_install() {
-	# move grass76 libraries from /usr/share to /usr/lib
+	# move grass libraries from /usr/share to /usr/lib
 	vmkdir usr/lib
-	mv ${DESTDIR}/usr/share/grass* ${DESTDIR}/usr/lib
+	mv ${DESTDIR}/usr/share/grass${_binver} ${DESTDIR}/usr/lib
 	# fixes a todo in GISBASE
-	sed -i ${DESTDIR}/usr/bin/grass${_binver} \
-		-e "105s;\(gisbase =\).*;\1 \"/usr/lib/grass-${version}\";"
+	sed -i ${DESTDIR}/usr/bin/grass \
+		-e "91s;\(GISBASE =\).*;\1 \'/usr/lib/grass${_binver}\';"
 }
```
seems to compile fine (there were some errors in the log but idk it still builds), **however** it does not run because we need at least wxPython4.1, it seems 🙃 (https://github.com/OSGeo/grass/issues/2019)

  parent reply	other threads:[~2022-11-01  6:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-30  5:27 [PR PATCH] " kruceter
2022-10-30  6:22 ` [PR PATCH] [Updated] " kruceter
2022-10-30  9:04 ` [PR REVIEW] " classabbyamp
2022-10-30  9:04 ` classabbyamp
2022-10-30 18:09 ` [PR PATCH] [Updated] " kruceter
2022-10-30 18:12 ` [PR REVIEW] " kruceter
2022-10-31  1:37 ` kruceter
2022-10-31  1:57 ` classabbyamp
2022-10-31 12:51 ` [PR PATCH] [Updated] " kruceter
2022-10-31 12:55 ` kruceter
2022-11-01  6:06 ` kruceter
2022-11-01  6:32 ` kruceter
2022-11-01  6:33 ` kruceter
2022-11-01  6:34 ` classabbyamp [this message]
2022-11-01  7:15 ` kruceter
2022-11-01 11:14 ` kruceter
2022-11-01 11:35 ` [PR PATCH] [Updated] " kruceter
2022-11-01 17:59 ` [PR PATCH] [Updated] libgdal: update to 3.5.3 kruceter
2022-11-02 13:29 ` kruceter
2022-11-03  7:11 ` kruceter
2022-11-03  8:01 ` kruceter
2022-11-03 20:34 ` [PR PATCH] [Updated] " kruceter
2022-11-03 20:40 ` kruceter
2022-11-03 22:51 ` kruceter
2022-11-03 23:05 ` kruceter
2022-11-04  9:05 ` kruceter
2022-11-04 12:36 ` kruceter
2022-11-05  3:23 ` the-maldridge
2022-11-05  3:27 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221101063438.D0oGXA9snJ4miIdZufWEIxN2ylinpYwuALcvEzY0BYM@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).