* [PR PATCH] New package: xremap-0.4.4
@ 2022-07-20 7:16 akhiljalagam
2022-07-20 7:28 ` [PR REVIEW] " meator
` (18 more replies)
0 siblings, 19 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-20 7:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
There is a new pull request by akhiljalagam against master on the void-packages repository
https://github.com/akhiljalagam/void-packages xremap
https://github.com/void-linux/void-packages/pull/38149
New package: xremap-0.4.4
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38149.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xremap-38149.patch --]
[-- Type: text/x-diff, Size: 1022 bytes --]
From 592e707d619cdccc754e313d0aaa7a19f94dd5c0 Mon Sep 17 00:00:00 2001
From: akhil <akhil.j@outlook.in>
Date: Wed, 20 Jul 2022 12:37:37 +0530
Subject: [PATCH] New package: xremap-0.4.4
---
srcpkgs/xremap/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/xremap/template
diff --git a/srcpkgs/xremap/template b/srcpkgs/xremap/template
new file mode 100644
index 000000000000..86bf51c4e841
--- /dev/null
+++ b/srcpkgs/xremap/template
@@ -0,0 +1,16 @@
+# Template file for 'xremap'
+pkgname=xremap
+version=0.4.4
+revision=1
+build_style=cargo
+short_desc="Dynamic key remapper for X11 and Wayland"
+maintainer="akhil <akhil.j@outlook.in>"
+license="MIT"
+homepage="https://github.com/k0kubun/xremap"
+changelog="https://raw.githubusercontent.com/k0kubun/xremap/master/CHANGELOG.md"
+distfiles="https://github.com/k0kubun/xremap/archive/refs/tags/v${version}.tar.gz"
+checksum=323cc9a900e7bc226008179619e49ee679caa6c9ade85e69bb5e710ffb0ed7ff
+
+vlicense() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
@ 2022-07-20 7:28 ` meator
2022-07-20 7:29 ` [PR PATCH] [Updated] " akhiljalagam
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: meator @ 2022-07-20 7:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
New review comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#discussion_r925266693
Comment:
`vlicense()` isn't a function recognized by `xbps-src`. If you would try to build this package yourself, you would see:
```
/home/coder/git/void-packages/srcpkgs/xremap/template: line 14: syntax error near unexpected token `('
/home/coder/git/void-packages/srcpkgs/xremap/template: line 14: `vlicense() {'
=> ERROR: xbps-src: failed to read /home/coder/git/void-packages/srcpkgs/xremap/template!
```
```suggestion
post_install() {
vlicense LICENSE
}
```
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
2022-07-20 7:28 ` [PR REVIEW] " meator
@ 2022-07-20 7:29 ` akhiljalagam
2022-07-20 7:30 ` akhiljalagam
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-20 7:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
There is an updated pull request by akhiljalagam against master on the void-packages repository
https://github.com/akhiljalagam/void-packages xremap
https://github.com/void-linux/void-packages/pull/38149
New package: xremap-0.4.4
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38149.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xremap-38149.patch --]
[-- Type: text/x-diff, Size: 1837 bytes --]
From 592e707d619cdccc754e313d0aaa7a19f94dd5c0 Mon Sep 17 00:00:00 2001
From: akhil <akhil.j@outlook.in>
Date: Wed, 20 Jul 2022 12:37:37 +0530
Subject: [PATCH 1/2] New package: xremap-0.4.4
---
srcpkgs/xremap/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/xremap/template
diff --git a/srcpkgs/xremap/template b/srcpkgs/xremap/template
new file mode 100644
index 000000000000..86bf51c4e841
--- /dev/null
+++ b/srcpkgs/xremap/template
@@ -0,0 +1,16 @@
+# Template file for 'xremap'
+pkgname=xremap
+version=0.4.4
+revision=1
+build_style=cargo
+short_desc="Dynamic key remapper for X11 and Wayland"
+maintainer="akhil <akhil.j@outlook.in>"
+license="MIT"
+homepage="https://github.com/k0kubun/xremap"
+changelog="https://raw.githubusercontent.com/k0kubun/xremap/master/CHANGELOG.md"
+distfiles="https://github.com/k0kubun/xremap/archive/refs/tags/v${version}.tar.gz"
+checksum=323cc9a900e7bc226008179619e49ee679caa6c9ade85e69bb5e710ffb0ed7ff
+
+vlicense() {
+ vlicense LICENSE
+}
From 1033e0e74f3e1e6a84849025ccf0960fa36c0ae7 Mon Sep 17 00:00:00 2001
From: Akhil Jalagam <akhil.j@outlook.in>
Date: Wed, 20 Jul 2022 12:59:20 +0530
Subject: [PATCH 2/2] Update srcpkgs/xremap/template
Co-authored-by: meator <meator.dev@gmail.com>
---
srcpkgs/xremap/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/xremap/template b/srcpkgs/xremap/template
index 86bf51c4e841..d74cbc18ed97 100644
--- a/srcpkgs/xremap/template
+++ b/srcpkgs/xremap/template
@@ -11,6 +11,6 @@ changelog="https://raw.githubusercontent.com/k0kubun/xremap/master/CHANGELOG.md"
distfiles="https://github.com/k0kubun/xremap/archive/refs/tags/v${version}.tar.gz"
checksum=323cc9a900e7bc226008179619e49ee679caa6c9ade85e69bb5e710ffb0ed7ff
-vlicense() {
+post_install() {
vlicense LICENSE
}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
2022-07-20 7:28 ` [PR REVIEW] " meator
2022-07-20 7:29 ` [PR PATCH] [Updated] " akhiljalagam
@ 2022-07-20 7:30 ` akhiljalagam
2022-07-20 13:22 ` tranzystorek-io
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-20 7:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
There is an updated pull request by akhiljalagam against master on the void-packages repository
https://github.com/akhiljalagam/void-packages xremap
https://github.com/void-linux/void-packages/pull/38149
New package: xremap-0.4.4
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38149.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xremap-38149.patch --]
[-- Type: text/x-diff, Size: 1104 bytes --]
From 0fd43d377a522be3bc19f4a532fa93f6cf92fe03 Mon Sep 17 00:00:00 2001
From: akhil <akhil.j@outlook.in>
Date: Wed, 20 Jul 2022 12:37:37 +0530
Subject: [PATCH] New package: xremap-0.4.4
Update srcpkgs/xremap/template
Co-authored-by: meator <meator.dev@gmail.com>
---
srcpkgs/xremap/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/xremap/template
diff --git a/srcpkgs/xremap/template b/srcpkgs/xremap/template
new file mode 100644
index 000000000000..d74cbc18ed97
--- /dev/null
+++ b/srcpkgs/xremap/template
@@ -0,0 +1,16 @@
+# Template file for 'xremap'
+pkgname=xremap
+version=0.4.4
+revision=1
+build_style=cargo
+short_desc="Dynamic key remapper for X11 and Wayland"
+maintainer="akhil <akhil.j@outlook.in>"
+license="MIT"
+homepage="https://github.com/k0kubun/xremap"
+changelog="https://raw.githubusercontent.com/k0kubun/xremap/master/CHANGELOG.md"
+distfiles="https://github.com/k0kubun/xremap/archive/refs/tags/v${version}.tar.gz"
+checksum=323cc9a900e7bc226008179619e49ee679caa6c9ade85e69bb5e710ffb0ed7ff
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (2 preceding siblings ...)
2022-07-20 7:30 ` akhiljalagam
@ 2022-07-20 13:22 ` tranzystorek-io
2022-07-20 15:15 ` meator
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tranzystorek-io @ 2022-07-20 13:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
New comment by tranzystorek-io on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#issuecomment-1190281673
Comment:
What about the crate features (`gnome`, `sway`, `x11`)?
Also, please generate and install shell completions
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (3 preceding siblings ...)
2022-07-20 13:22 ` tranzystorek-io
@ 2022-07-20 15:15 ` meator
2022-07-20 15:20 ` tranzystorek-io
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: meator @ 2022-07-20 15:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2957 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#issuecomment-1190414781
Comment:
> Also, please generate and install shell completions
This won't look pretty when you take cross compiling into consideration. I know, I have dealt with these issues before. There are four ways this can be solved (sorted by their usefulness):
1. Ask upstream to distribute completion scripts in their own files in the repo instead of embedding them into the program (it seems that they're using some automatic system that generates the completions but distributing the files separately is way more practical in my opinion). You could then simply `vcompletion` these files in `post_install()`.
2. Add `xremap` to `hostmakedepends` when `$CROSS_BUILD`ing. I know, this seems strange. `xremap` depending on `xremap`? This won't create an infinite loop because this dependency is active only if `$CROSS_BUILD` is defined. This dependency means that the cross compiled version (the version that's in `$XBPS_TARGET_MACHINE` and that `xbps-src` can't directly execute) depends on the natively compiled version (the `$XBPS_MACHINE` architecture which can be executed) of `xremap`. There are two things you can do with the native version of `xremap`:
1. Steal the completion from the native version.
You could generate the completions normally when you aren't cross compiling and then "steal" these completions from the native package when you are cross compiling (copy them from `/usr/share/<the three shell dependent completion directories>` which was populated by the native package into `$DESTDIR`). I do not know how would the Void maintainers think of this but this seems like the simplest solution. This would normally be unacceptable, but since shell completions aren't architecture dependent, this shouldn't matter.
2. Generate the completions with the native version.
You could run `xremap --completions <the shells>` with the **native** version and put the completions in the appropriate locations in `$DESTDIR` (this would probably require some temporary files if you would want to use `vcompletion`). This is a bit similar to 3a9aeacde03485588f78984c4baf040ab003dd32.
This solution is good because the completions would be automatically retrieved when an update changes them (which isn't true for the third solution).
3. Make a `srcpkgs/xremap/files` (i.e. `$FILESDIR`) directory, manually generate the files and put them there (and add them to this PR). Then `post_install()` would `vcompletion` these files.
I don't really like this solution because every time the completions would change, the files in `$FILESDIR` would have to be updated.
4. Do not include the completions in the package. You might not call this a "solution" but it is the simplest thing to do.
If you have any questions than please comment on this.
What do you think @tranzystorek-io?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (4 preceding siblings ...)
2022-07-20 15:15 ` meator
@ 2022-07-20 15:20 ` tranzystorek-io
2022-07-20 15:38 ` meator
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tranzystorek-io @ 2022-07-20 15:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
New comment by tranzystorek-io on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#issuecomment-1190420887
Comment:
I'm not sure I understand the problem. In these cases we just run `vtargetrun` with the built binary in `post_build` to generate the scripts, we do this already in many other packages.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (5 preceding siblings ...)
2022-07-20 15:20 ` tranzystorek-io
@ 2022-07-20 15:38 ` meator
2022-07-21 2:51 ` gbrlsnchs
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: meator @ 2022-07-20 15:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#issuecomment-1190441438
Comment:
_I didn't know that._ Well downloading 300MB of qemu just to get completions seems like a solution. My comment is pretty useless now. This is an interesting way to solve this.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (6 preceding siblings ...)
2022-07-20 15:38 ` meator
@ 2022-07-21 2:51 ` gbrlsnchs
2022-07-21 10:48 ` [PR PATCH] [Updated] " akhiljalagam
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: gbrlsnchs @ 2022-07-21 2:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
New comment by gbrlsnchs on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#issuecomment-1190978443
Comment:
> _I didn't know that._ Well downloading 300MB of qemu just to get completions seems like a solution. My comment is pretty useless now. This is an interesting way to solve this.
Just for reference, [here's an example](https://github.com/void-linux/void-packages/blob/c8aa5e65f18faaf1f3b3fcb7dc237cd5aa8d118f/srcpkgs/github-cli/template#L30) (GitHub CLI).
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (7 preceding siblings ...)
2022-07-21 2:51 ` gbrlsnchs
@ 2022-07-21 10:48 ` akhiljalagam
2022-07-21 10:48 ` akhiljalagam
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-21 10:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
There is an updated pull request by akhiljalagam against master on the void-packages repository
https://github.com/akhiljalagam/void-packages xremap
https://github.com/void-linux/void-packages/pull/38149
New package: xremap-0.4.4
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38149.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xremap-38149.patch --]
[-- Type: text/x-diff, Size: 2118 bytes --]
From 0fd43d377a522be3bc19f4a532fa93f6cf92fe03 Mon Sep 17 00:00:00 2001
From: akhil <akhil.j@outlook.in>
Date: Wed, 20 Jul 2022 12:37:37 +0530
Subject: [PATCH 1/2] New package: xremap-0.4.4
Update srcpkgs/xremap/template
Co-authored-by: meator <meator.dev@gmail.com>
---
srcpkgs/xremap/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/xremap/template
diff --git a/srcpkgs/xremap/template b/srcpkgs/xremap/template
new file mode 100644
index 000000000000..d74cbc18ed97
--- /dev/null
+++ b/srcpkgs/xremap/template
@@ -0,0 +1,16 @@
+# Template file for 'xremap'
+pkgname=xremap
+version=0.4.4
+revision=1
+build_style=cargo
+short_desc="Dynamic key remapper for X11 and Wayland"
+maintainer="akhil <akhil.j@outlook.in>"
+license="MIT"
+homepage="https://github.com/k0kubun/xremap"
+changelog="https://raw.githubusercontent.com/k0kubun/xremap/master/CHANGELOG.md"
+distfiles="https://github.com/k0kubun/xremap/archive/refs/tags/v${version}.tar.gz"
+checksum=323cc9a900e7bc226008179619e49ee679caa6c9ade85e69bb5e710ffb0ed7ff
+
+post_install() {
+ vlicense LICENSE
+}
From f196621c74f1f5cf48d4c1073c345338e641ae2a Mon Sep 17 00:00:00 2001
From: akhil <akhil.j@outlook.in>
Date: Thu, 21 Jul 2022 16:18:34 +0530
Subject: [PATCH 2/2] added shell completions
---
srcpkgs/xremap/template | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/srcpkgs/xremap/template b/srcpkgs/xremap/template
index d74cbc18ed97..fea044db3635 100644
--- a/srcpkgs/xremap/template
+++ b/srcpkgs/xremap/template
@@ -11,6 +11,17 @@ changelog="https://raw.githubusercontent.com/k0kubun/xremap/master/CHANGELOG.md"
distfiles="https://github.com/k0kubun/xremap/archive/refs/tags/v${version}.tar.gz"
checksum=323cc9a900e7bc226008179619e49ee679caa6c9ade85e69bb5e710ffb0ed7ff
+post_build() {
+ xremap=$(find $GOPATH/bin -name xremap)
+ for shell in bash elvish fish powershell zsh; do
+ vtargetrun $xremap --completions $shell > xremap.$shell
+ done
+}
+
post_install() {
vlicense LICENSE
+
+ for shell in bash elvish fish powershell zsh; do
+ vcompletion xremap.$shell $shell
+ done
}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (8 preceding siblings ...)
2022-07-21 10:48 ` [PR PATCH] [Updated] " akhiljalagam
@ 2022-07-21 10:48 ` akhiljalagam
2022-07-21 10:49 ` akhiljalagam
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-21 10:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
There is an updated pull request by akhiljalagam against master on the void-packages repository
https://github.com/akhiljalagam/void-packages xremap
https://github.com/void-linux/void-packages/pull/38149
New package: xremap-0.4.4
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38149.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xremap-38149.patch --]
[-- Type: text/x-diff, Size: 1416 bytes --]
From 8deb62331acd678f6d1fbdec51ba48883c12e000 Mon Sep 17 00:00:00 2001
From: akhil <akhil.j@outlook.in>
Date: Wed, 20 Jul 2022 12:37:37 +0530
Subject: [PATCH] New package: xremap-0.4.4
Update srcpkgs/xremap/template
Co-authored-by: meator <meator.dev@gmail.com>
added shell completions
---
srcpkgs/xremap/template | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 srcpkgs/xremap/template
diff --git a/srcpkgs/xremap/template b/srcpkgs/xremap/template
new file mode 100644
index 000000000000..fea044db3635
--- /dev/null
+++ b/srcpkgs/xremap/template
@@ -0,0 +1,27 @@
+# Template file for 'xremap'
+pkgname=xremap
+version=0.4.4
+revision=1
+build_style=cargo
+short_desc="Dynamic key remapper for X11 and Wayland"
+maintainer="akhil <akhil.j@outlook.in>"
+license="MIT"
+homepage="https://github.com/k0kubun/xremap"
+changelog="https://raw.githubusercontent.com/k0kubun/xremap/master/CHANGELOG.md"
+distfiles="https://github.com/k0kubun/xremap/archive/refs/tags/v${version}.tar.gz"
+checksum=323cc9a900e7bc226008179619e49ee679caa6c9ade85e69bb5e710ffb0ed7ff
+
+post_build() {
+ xremap=$(find $GOPATH/bin -name xremap)
+ for shell in bash elvish fish powershell zsh; do
+ vtargetrun $xremap --completions $shell > xremap.$shell
+ done
+}
+
+post_install() {
+ vlicense LICENSE
+
+ for shell in bash elvish fish powershell zsh; do
+ vcompletion xremap.$shell $shell
+ done
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (9 preceding siblings ...)
2022-07-21 10:48 ` akhiljalagam
@ 2022-07-21 10:49 ` akhiljalagam
2022-07-21 10:58 ` [PR REVIEW] " tranzystorek-io
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-21 10:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
New comment by akhiljalagam on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#issuecomment-1191336767
Comment:
> > _I didn't know that._ Well downloading 300MB of qemu just to get completions seems like a solution. My comment is pretty useless now. This is an interesting way to solve this.
>
> Just for reference, [here's an example](https://github.com/void-linux/void-packages/blob/c8aa5e65f18faaf1f3b3fcb7dc237cd5aa8d118f/srcpkgs/github-cli/template#L30) (GitHub CLI).
thanks. added shell completions.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (10 preceding siblings ...)
2022-07-21 10:49 ` akhiljalagam
@ 2022-07-21 10:58 ` tranzystorek-io
2022-07-21 11:02 ` akhiljalagam
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tranzystorek-io @ 2022-07-21 10:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
New review comment by tranzystorek-io on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#discussion_r926540684
Comment:
We can only really install bash, fish and zsh completions
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (11 preceding siblings ...)
2022-07-21 10:58 ` [PR REVIEW] " tranzystorek-io
@ 2022-07-21 11:02 ` akhiljalagam
2022-07-21 11:02 ` akhiljalagam
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-21 11:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
New review comment by akhiljalagam on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#discussion_r926543543
Comment:
why?
xremaps can generate all.
```
--completions <SHELL> Generate shell completions [possible values: bash, elvish, fish,
powershell, zsh]
```
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (12 preceding siblings ...)
2022-07-21 11:02 ` akhiljalagam
@ 2022-07-21 11:02 ` akhiljalagam
2022-07-21 11:03 ` tranzystorek-io
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-21 11:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
New review comment by akhiljalagam on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#discussion_r926543876
Comment:
oops. powershell is for windows. i got it.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (13 preceding siblings ...)
2022-07-21 11:02 ` akhiljalagam
@ 2022-07-21 11:03 ` tranzystorek-io
2022-07-21 11:04 ` [PR PATCH] [Updated] " akhiljalagam
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tranzystorek-io @ 2022-07-21 11:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
New review comment by tranzystorek-io on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#discussion_r926544613
Comment:
`vcompletion` only accepts those three, see in the manual
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (14 preceding siblings ...)
2022-07-21 11:03 ` tranzystorek-io
@ 2022-07-21 11:04 ` akhiljalagam
2022-07-21 11:14 ` meator
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: akhiljalagam @ 2022-07-21 11:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
There is an updated pull request by akhiljalagam against master on the void-packages repository
https://github.com/akhiljalagam/void-packages xremap
https://github.com/void-linux/void-packages/pull/38149
New package: xremap-0.4.4
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38149.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xremap-38149.patch --]
[-- Type: text/x-diff, Size: 1380 bytes --]
From 2def08ef4d6e2181251fe376f1416336fb877b00 Mon Sep 17 00:00:00 2001
From: akhil <akhil.j@outlook.in>
Date: Wed, 20 Jul 2022 12:37:37 +0530
Subject: [PATCH] New package: xremap-0.4.4
Update srcpkgs/xremap/template
Co-authored-by: meator <meator.dev@gmail.com>
added shell completions
---
srcpkgs/xremap/template | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 srcpkgs/xremap/template
diff --git a/srcpkgs/xremap/template b/srcpkgs/xremap/template
new file mode 100644
index 000000000000..3ac88abf2cd5
--- /dev/null
+++ b/srcpkgs/xremap/template
@@ -0,0 +1,27 @@
+# Template file for 'xremap'
+pkgname=xremap
+version=0.4.4
+revision=1
+build_style=cargo
+short_desc="Dynamic key remapper for X11 and Wayland"
+maintainer="akhil <akhil.j@outlook.in>"
+license="MIT"
+homepage="https://github.com/k0kubun/xremap"
+changelog="https://raw.githubusercontent.com/k0kubun/xremap/master/CHANGELOG.md"
+distfiles="https://github.com/k0kubun/xremap/archive/refs/tags/v${version}.tar.gz"
+checksum=323cc9a900e7bc226008179619e49ee679caa6c9ade85e69bb5e710ffb0ed7ff
+
+post_build() {
+ xremap=$(find $GOPATH/bin -name xremap)
+ for shell in bash fish zsh; do
+ vtargetrun $xremap --completions $shell > xremap.$shell
+ done
+}
+
+post_install() {
+ vlicense LICENSE
+
+ for shell in bash fish zsh; do
+ vcompletion xremap.$shell $shell
+ done
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (15 preceding siblings ...)
2022-07-21 11:04 ` [PR PATCH] [Updated] " akhiljalagam
@ 2022-07-21 11:14 ` meator
2022-10-20 2:14 ` github-actions
2022-11-04 2:13 ` [PR PATCH] [Closed]: " github-actions
18 siblings, 0 replies; 20+ messages in thread
From: meator @ 2022-07-21 11:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#issuecomment-1191357919
Comment:
You are missing `build_helper=qemu`. Please try to compile the programs yourself with `./xbps-src pkg <pkgname>` before posting them. It errors with:
```
=> xremap-0.4.4_1: running post_build ...
/void-packages/srcpkgs/xremap/template: line 17: vtargetrun: command not found
=> ERROR: xremap-0.4.4_1: post_build: 'vtargetrun $xremap --completions $shell > xremap.$shell' exited with 127
=> ERROR: in post_build() at srcpkgs/xremap/template:17
```
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (16 preceding siblings ...)
2022-07-21 11:14 ` meator
@ 2022-10-20 2:14 ` github-actions
2022-11-04 2:13 ` [PR PATCH] [Closed]: " github-actions
18 siblings, 0 replies; 20+ messages in thread
From: github-actions @ 2022-10-20 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/38149#issuecomment-1284813094
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Closed]: New package: xremap-0.4.4
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
` (17 preceding siblings ...)
2022-10-20 2:14 ` github-actions
@ 2022-11-04 2:13 ` github-actions
18 siblings, 0 replies; 20+ messages in thread
From: github-actions @ 2022-11-04 2:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
There's a closed pull request on the void-packages repository
New package: xremap-0.4.4
https://github.com/void-linux/void-packages/pull/38149
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2022-11-04 2:13 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 7:16 [PR PATCH] New package: xremap-0.4.4 akhiljalagam
2022-07-20 7:28 ` [PR REVIEW] " meator
2022-07-20 7:29 ` [PR PATCH] [Updated] " akhiljalagam
2022-07-20 7:30 ` akhiljalagam
2022-07-20 13:22 ` tranzystorek-io
2022-07-20 15:15 ` meator
2022-07-20 15:20 ` tranzystorek-io
2022-07-20 15:38 ` meator
2022-07-21 2:51 ` gbrlsnchs
2022-07-21 10:48 ` [PR PATCH] [Updated] " akhiljalagam
2022-07-21 10:48 ` akhiljalagam
2022-07-21 10:49 ` akhiljalagam
2022-07-21 10:58 ` [PR REVIEW] " tranzystorek-io
2022-07-21 11:02 ` akhiljalagam
2022-07-21 11:02 ` akhiljalagam
2022-07-21 11:03 ` tranzystorek-io
2022-07-21 11:04 ` [PR PATCH] [Updated] " akhiljalagam
2022-07-21 11:14 ` meator
2022-10-20 2:14 ` github-actions
2022-11-04 2:13 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).