From: eli-schwartz <eli-schwartz@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Abandon pip in python3-pep517 build style
Date: Wed, 09 Nov 2022 00:52:13 +0100 [thread overview]
Message-ID: <20221108235213.WxvSAhpukMdSawwfg0D9HBvw5OZziDW_FQ0J2G9TAXc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40385@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
New review comment by eli-schwartz on void-packages repository
https://github.com/void-linux/void-packages/pull/40385#discussion_r1017230252
Comment:
This one is great. `python -v -m build` attempts to run poetry's undocumented `build.py` plugin, you cannot even get https://github.com/pypa/build's --help text inside the pendulum repo.
I've always been pretty meh about the use of `python -m` anything unless the goal is very specifically to inject $PWD into the python module search path, which granted you may sometimes want to do (pytest, specifically).
`/usr/bin/pyproject-build` arguably works just as well.
next prev parent reply other threads:[~2022-11-08 23:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 17:38 [PR PATCH] [NOMERGE] " ahesford
2022-11-08 17:46 ` [PR PATCH] [Updated] " ahesford
2022-11-08 19:18 ` eli-schwartz
2022-11-08 19:37 ` ahesford
2022-11-08 19:57 ` eli-schwartz
2022-11-08 20:22 ` ahesford
2022-11-08 21:13 ` [PR PATCH] [Updated] " ahesford
2022-11-08 21:14 ` ahesford
2022-11-08 21:51 ` eli-schwartz
2022-11-08 23:06 ` [PR PATCH] [Updated] " ahesford
2022-11-08 23:08 ` ahesford
2022-11-08 23:09 ` ahesford
2022-11-08 23:44 ` [PR REVIEW] " eli-schwartz
2022-11-08 23:44 ` eli-schwartz
2022-11-08 23:52 ` eli-schwartz [this message]
2022-11-09 2:31 ` [PR PATCH] [Updated] " ahesford
2022-11-09 2:34 ` [PR REVIEW] " ahesford
2022-11-09 3:15 ` [PR PATCH] [Updated] " ahesford
2022-11-09 4:15 ` [PR REVIEW] " eli-schwartz
2022-11-10 2:24 ` [PR PATCH] [Merged]: " ahesford
2022-11-10 21:50 ` eli-schwartz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108235213.WxvSAhpukMdSawwfg0D9HBvw5OZziDW_FQ0J2G9TAXc@z \
--to=eli-schwartz@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).