Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] flowblade: updated dependencies
Date: Wed, 09 Nov 2022 18:16:15 +0100	[thread overview]
Message-ID: <20221109171615.1LGMnAm0608y0Z_1Ts8BReWhrykm-PteNhYLvNo_UY0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40415@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40415#discussion_r1018213572

Comment:
> > I don't see a reason for this, all of the added dependencies are already dependencies through a package that's already in $depends.
> 
> ok but flowblade was not launching and it was saying that module "mlt "was missing, then after installing mlt-python3 it also said that module "gi" was missing, which could be fixed by installing libgirepository

`mlt-python3` is already a dependency, I have no idea how you could install `flowblade` without `mlt-python3` getting installed as a dependency. `gi` missing means you were missing python3-gobject which is also already a dependency.


> also librsvg mlt-data and sox were also on the dependency page of flowblade so i added them as well while i was at it

All of these are already dependencies, just not directly.

> > commit message is wrong and $revision should be increased
> 
> my bad, im going to fix that quickly

Please read CONTRIBUTING.md, this PR should contain only one commit because it touches only one package.

  parent reply	other threads:[~2022-11-09 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 15:55 [PR PATCH] " Relected
2022-11-09 16:00 ` [PR REVIEW] " paper42
2022-11-09 16:07 ` Relected
2022-11-09 16:11 ` [PR PATCH] [Updated] " Relected
2022-11-09 17:16 ` paper42 [this message]
2022-12-16 15:45 ` Relected
2022-12-16 15:46 ` [PR PATCH] [Closed]: " Relected

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221109171615.1LGMnAm0608y0Z_1Ts8BReWhrykm-PteNhYLvNo_UY0@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).