Github messages for voidlinux
 help / color / mirror / Atom feed
From: dkwo <dkwo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] sioyek: add .desktop file, fix arch
Date: Fri, 11 Nov 2022 19:42:29 +0100	[thread overview]
Message-ID: <20221111184229.VjwW7tfDEes7_sqkZGApKuMQnAS-rKql6ohAaIeoxcw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40460@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages sioy
https://github.com/void-linux/void-packages/pull/40460

sioyek: add .desktop file, fix arch
#### Testing the changes
- I tested the changes in this PR: I'm still unable to select it e.g. in firefox.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/40460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sioy-40460.patch --]
[-- Type: text/x-diff, Size: 1897 bytes --]

From 58bf8c6e0b459f42c9fad0414458bc02a6f5cf13 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 10 Nov 2022 17:53:27 -0500
Subject: [PATCH] sioyek: add .desktop file, restore arch

---
 srcpkgs/sioyek/patches/desktop.patch | 22 ++++++++++++++++++++++
 srcpkgs/sioyek/template              |  4 +++-
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/sioyek/patches/desktop.patch

diff --git a/srcpkgs/sioyek/patches/desktop.patch b/srcpkgs/sioyek/patches/desktop.patch
new file mode 100644
index 000000000000..bf42608b3baa
--- /dev/null
+++ b/srcpkgs/sioyek/patches/desktop.patch
@@ -0,0 +1,22 @@
+diff --git a/resources/sioyek.desktop b/resources/sioyek.desktop
+index cf8b6b2..917fd62 100644
+--- a/resources/sioyek.desktop
++++ b/resources/sioyek.desktop
+@@ -1,8 +1,12 @@
+ [Desktop Entry]
+-Version=1.0
+-Type=Application
+-MimeType=application/pdf;
+ Name=Sioyek
+-Exec=sioyek
++Comment=PDF viewer for reading research papers and technical books
++Keywords=pdf;viewer;reader;research;
++TryExec=sioyek
++Exec=sioyek %U
++StartupNotify=true
++Terminal=false
++Type=Application
+ Icon=sioyek-icon-linux
+-Categories=Development;
++Categories=Development;Viewer;
++MimeType=application/pdf;
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index ef5c44f9096d..b3e6c65209b0 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,7 +1,8 @@
 # Template file for 'sioyek'
 pkgname=sioyek
 version=1.5.0
-revision=1
+revision=2
+archs="~aarch64* ~arm*"
 build_style=qmake
 hostmakedepends="qt5-qmake qt5-host-tools
  qt5-opengl qt5-gui qt5-widgets qt5-network"
@@ -30,5 +31,6 @@ do_install() {
 	vmkdir usr/share/sioyek/shaders
 	vcopy pdf_viewer/shaders/* usr/share/sioyek/shaders
 	vinstall tutorial.pdf 644 usr/share/sioyek
+	vinstall resources/sioyek.desktop 644 usr/share/sioyek
 	vman resources/sioyek.1
 }

  parent reply	other threads:[~2022-11-11 18:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 23:16 [PR PATCH] [draft] sioyek: add .desktop file dkwo
2022-11-11 15:24 ` Duncaen
2022-11-11 15:25 ` Duncaen
2022-11-11 15:39 ` dkwo
2022-11-11 15:48 ` dkwo
2022-11-11 16:30 ` [PR PATCH] [Updated] " dkwo
2022-11-11 16:30 ` dkwo
2022-11-11 17:20 ` sioyek: add .desktop file, fix arch q66
2022-11-11 17:21 ` q66
2022-11-11 18:40 ` dkwo
2022-11-11 18:42 ` dkwo [this message]
2022-11-11 18:47 ` paper42
2022-11-11 18:48 ` paper42
2022-11-11 18:50 ` dkwo
2022-11-11 18:55 ` paper42
2022-11-11 21:20 ` [PR PATCH] [Updated] " dkwo
2022-11-11 21:22 ` dkwo
2022-11-11 21:22 ` dkwo
2022-11-11 21:22 ` dkwo
2022-11-12  0:05 ` q66
2022-11-12 14:06 ` [PR PATCH] [Updated] " dkwo
2022-11-14 18:22 ` dkwo
2022-12-14 14:48 ` dkwo
2022-12-27 16:01 ` dkwo
2022-12-27 16:01 ` [PR PATCH] [Closed]: " dkwo
2023-01-27 18:34 ` dkwo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221111184229.VjwW7tfDEes7_sqkZGApKuMQnAS-rKql6ohAaIeoxcw@z \
    --to=dkwo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).