[PR PATCH] cryptsetup: update to 2.5.0.

[PR PATCH] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

There is a new pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1557 bytes --]

From 4be833058b27bc9875d8e2030948935a774115b9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..3c5195afb5fc 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
 make_check=extended
 subpackages="libcryptsetup cryptsetup-devel"
 

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1557 bytes --]

From fcc6d9d6e623656b36f7904ed9d72c135902a931 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..3c5195afb5fc 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
 make_check=extended
 subpackages="libcryptsetup cryptsetup-devel"
 

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1585 bytes --]

From 50d6c670be757485d0277b69923df87b0042b946 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..6cbeb2fdb0d5 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,8 +16,7 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
-make_check=extended
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
 subpackages="libcryptsetup cryptsetup-devel"
 
 build_options="pwquality"

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1557 bytes --]

From a9250da2b066627d4a6beb827c61243bf2b42052 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..3c5195afb5fc 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
 make_check=extended
 subpackages="libcryptsetup cryptsetup-devel"
 

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1666 bytes --]

From 68b0135bec6406668a2c9637269a51458cc222ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..a848a18423c9 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,8 +16,8 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
-make_check=extended
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
+make_check=extended # tests depend on acessing /dev/mapper/control fails on CI
 subpackages="libcryptsetup cryptsetup-devel"
 
 build_options="pwquality"

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1665 bytes --]

From 4c2ee1cf13e9d3cc73e1b3681891cbdfaef45e23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..f4ccb04a624b 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,8 +16,8 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
-make_check=extended
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
+make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI
 subpackages="libcryptsetup cryptsetup-devel"
 
 build_options="pwquality"

Re: [PR REVIEW] cryptsetup: update to 2.5.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#discussion_r997512153

Comment:
some tests fail in local builds too

Re: cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#issuecomment-1281545775

Comment:
Yeah with CI I meant the chroot ...

Not sure if the failure is the same reason, let me check 


On 22/10/17 02:08PM, Piraty wrote:
> @Piraty commented on this pull request.
> 
> 
> 
> > @@ -16,8 +16,8 @@ license="GPL-2.0-or-later"
>  homepage="https://gitlab.com/cryptsetup/cryptsetup"
>  changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
>  distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
> -checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
> -make_check=extended
> +checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
> +make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI
> 
> some tests fail in local builds too
> 
> -- 
> Reply to this email directly or view it on GitHub:
> https://github.com/void-linux/void-packages/pull/39446#pullrequestreview-1144813989
> You are receiving this because you authored the thread.
> 
> Message ID: ***@***.***>

Re: cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#issuecomment-1281545775

Comment:
Yeah with CI I meant the chroot ...

Not sure if the failure is the same reason, let me check 

Strike that, the tests that needs to be run as root locally are skipped at least on my x86_64-glibc.

=======================
All 9 tests passed
(22 tests were not run)
=======================

On 22/10/17 02:08PM, Piraty wrote:
> @Piraty commented on this pull request.
> 
> 
> 
> > @@ -16,8 +16,8 @@ license="GPL-2.0-or-later"
>  homepage="https://gitlab.com/cryptsetup/cryptsetup"
>  changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
>  distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
> -checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
> -make_check=extended
> +checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
> +make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI
> 
> some tests fail in local builds too
> 
> -- 
> Reply to this email directly or view it on GitHub:
> https://github.com/void-linux/void-packages/pull/39446#pullrequestreview-1144813989
> You are receiving this because you authored the thread.
> 
> Message ID: ***@***.***>

Re: [PR REVIEW] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#discussion_r997549993

Comment:
Replied below, but if you want I can add the make_check=no because they require root to run and are skipped locally.

=======================
All 9 tests passed
(22 tests were not run)
=======================

Re: [PR REVIEW] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#discussion_r997549993

Comment:
Replied below, but if you want I can add the make_check=no because they require root to run and are skipped locally.
  
```
=======================
All 9 tests passed
(22 tests were not run)
=======================
```

Re: [PR REVIEW] cryptsetup: update to 2.5.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#discussion_r1000013365

Comment:
```
$ grep CHECK etc/conf
XBPS_CHECK_PKGS=full

$ ./xbps-src binary-bootstrap x86_64-musl && ./xbps-src pkg cryptsetup
...
FAIL: luks2-reencryption-mangle-test
WARNING: You must be root to run this test, test skipped.
SKIP: verity-compat-test
WARNING: You must be root to run this test, test skipped.
SKIP: integrity-compat-test
WARNING: You must be root to run this test, test skipped.
SKIP: ssh-test-plugin
=======================
2 of 10 tests failed
(21 tests were not run)
=======================
make[2]: *** [Makefile:900: check-TESTS] Error 1
```

Re: [PR REVIEW] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#discussion_r1001684874

Comment:
Reported upstream (https://gitlab.com/cryptsetup/cryptsetup/-/issues/781)

Are you okay with adding make_check=no if libc is musl on the template ?

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1944 bytes --]

From 011d3fb1f4215be48e638008e251d00f36542750 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..1c41904624fe 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,10 +16,18 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
-make_check=extended
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
+make_check=ci-skip 
 subpackages="libcryptsetup cryptsetup-devel"
 
+if [ "$XBPS_LIBC" = "musl" ]
+then
+	make_check=no # Test fail on musl see upstream:
+	# https://gitlab.com/cryptsetup/cryptsetup/-/issues/781
+else
+	make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI
+fi
+
 build_options="pwquality"
 desc_option_pwquality="Enable support for checking password quality via libpwquality"
 

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1922 bytes --]

From 04f35b65209a2cbe9f479482c24175e27c877fa3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..9ebbdea0b34c 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,10 +16,17 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
-make_check=extended
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
 subpackages="libcryptsetup cryptsetup-devel"
 
+if [ "$XBPS_LIBC" = "musl" ]
+then
+	make_check=no # Test fail on musl see upstream:
+	# https://gitlab.com/cryptsetup/cryptsetup/-/issues/781
+else
+	make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI
+fi
+
 build_options="pwquality"
 desc_option_pwquality="Enable support for checking password quality via libpwquality"
 

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 2045 bytes --]

From f68c618b1d7ca7ea844c728e3579404cc9a7ab7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..d7595fc7c534 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,12 +1,12 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
  --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
  libargon2-devel libssh-devel $(vopt_if pwquality libpwquality-devel)"
 checkdepends="procps-ng which jq tar xz xxd"
@@ -16,13 +16,19 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
-make_check=extended
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
 subpackages="libcryptsetup cryptsetup-devel"
-
 build_options="pwquality"
 desc_option_pwquality="Enable support for checking password quality via libpwquality"
 
+if [ "$XBPS_LIBC" = "musl" ]
+then
+	make_check=no # Test fail on musl see upstream:
+	# https://gitlab.com/cryptsetup/cryptsetup/-/issues/781
+else
+	make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI
+fi
+
 post_patch() {
 	if [ "$XBPS_TARGET_LIBC" = musl ]; then
 		# Require losetup from util-linux, also failing when present

Re: cryptsetup: update to 2.5.0.

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#issuecomment-1316994188

Comment:
I'd prefer we use `--disable-asciidoc` and use the included man pages to not pull in even more deps to a quite core package.

Re: [PR PATCH] [Updated] cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages cryptsetup-2.5.0
https://github.com/void-linux/void-packages/pull/39446

cryptsetup: update to 2.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).

A patch file from https://github.com/void-linux/void-packages/pull/39446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cryptsetup-2.5.0-39446.patch --]
[-- Type: text/x-diff, Size: 1946 bytes --]

From 060c57c67d33a741163837b0dc878b56dc8d7e9f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 24 Sep 2022 13:04:50 +0100
Subject: [PATCH] cryptsetup: update to 2.5.0.

---
 srcpkgs/cryptsetup/template | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/cryptsetup/template b/srcpkgs/cryptsetup/template
index 40de06c9b1d3..89f75fedfc62 100644
--- a/srcpkgs/cryptsetup/template
+++ b/srcpkgs/cryptsetup/template
@@ -1,10 +1,10 @@
 # Template file for 'cryptsetup'
 pkgname=cryptsetup
-version=2.4.3
+version=2.5.0
 revision=1
 build_style=gnu-configure
 configure_args="--with-crypto_backend=openssl --enable-cryptsetup-reencrypt
- --enable-libargon2 $(vopt_enable pwquality)"
+ --disable-asciidoc --enable-libargon2 $(vopt_enable pwquality)"
 make_check_args="-C tests"
 hostmakedepends="pkg-config"
 makedepends="device-mapper-devel json-c-devel openssl-devel popt-devel
@@ -16,13 +16,19 @@ license="GPL-2.0-or-later"
 homepage="https://gitlab.com/cryptsetup/cryptsetup"
 changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
 distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
-make_check=extended
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
 subpackages="libcryptsetup cryptsetup-devel"
-
 build_options="pwquality"
 desc_option_pwquality="Enable support for checking password quality via libpwquality"
 
+if [ "$XBPS_LIBC" = "musl" ]
+then
+	make_check=no # Test fail on musl see upstream:
+	# https://gitlab.com/cryptsetup/cryptsetup/-/issues/781
+else
+	make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI
+fi
+
 post_patch() {
 	if [ "$XBPS_TARGET_LIBC" = musl ]; then
 		# Require losetup from util-linux, also failing when present

Re: cryptsetup: update to 2.5.0.

[motorto]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39446#issuecomment-1317528745

Comment:
Thanks, I am pretty sure that enabling `--disable-asciidoc` still copies the man pages ... Could you verify `xls` says so.

Re: [PR PATCH] [Merged]: cryptsetup: update to 2.5.0.

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

There's a merged pull request on the void-packages repository

cryptsetup: update to 2.5.0.
https://github.com/void-linux/void-packages/pull/39446

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**, using it on my full disk encrypted system boot included (x86_64-glibc), and its working fine. 

I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.

#### Local build testing
- I built this PR locally for my native architecture, x86_64-{musl,glibc}
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).