From: kruceter <kruceter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] glslViewer: update to 3.0.7.
Date: Sat, 19 Nov 2022 00:52:42 +0100 [thread overview]
Message-ID: <20221118235242.G1JZl7RLQfzZrRzxxdlVkyvJxMQPPoN5hcRFtRTVziw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40547@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]
New review comment by kruceter on void-packages repository
https://github.com/void-linux/void-packages/pull/40547#discussion_r1026972568
Comment:
libatomic is required always regardless of architecture.
grep show this:
```
.vscode/settings.json: "atomic": "cpp",
CMakeLists.txt: target_link_libraries(glslViewer PRIVATE atomic)
deps/liblo/configure: # or fails outright, so override atomically:
deps/liblo/configure: # or fails outright, so override atomically:
deps/liblo/lo/lo_types.h: * and preserve ordering and atomicity of messages in bundles.
deps/liblo/m4/libtool.m4: # or fails outright, so override atomically:
deps/thread_pool/thread_pool.hpp:#include <atomic>
deps/thread_pool/thread_pool.hpp: std::atomic<bool> terminate_;
src/main.cpp:#include <atomic>
src/main.cpp:std::atomic<bool> bKeepRunnig(true);
src/sandbox.h:#include <atomic>
src/sandbox.h: std::atomic<int> m_task_count {0};
src/sandbox.h: std::atomic<long long> m_max_mem_in_queue {0};
src/tools/job.h:#include <atomic>
src/tools/job.h: std::atomic<int>& _task_count, std::atomic<long long>& _max_mem_in_queue):
src/tools/job.h: std::atomic<int> * m_task_count;
src/tools/job.h: std::atomic<long long> * m_max_mem_in_queue;
src/tools/record.cpp:#include <atomic>
src/tools/record.cpp:std::atomic<bool> pipe_isRecording;
```
CMake requires libatomic this way:
```cmake
if (NOT APPLE)
target_link_libraries(glslViewer PRIVATE atomic)
install(FILES "${PROJECT_SOURCE_DIR}/assets/glslViewer.png" DESTINATION share/pixmaps)
install(FILES "${PROJECT_SOURCE_DIR}/assets/glslViewer.desktop" DESTINATION share/applications)
```
I suspect that this requirement may be wrong, but I will look into it.
next prev parent reply other threads:[~2022-11-18 23:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 23:34 [PR PATCH] " kruceter
2022-11-18 12:24 ` [PR REVIEW] " paper42
2022-11-18 12:24 ` paper42
2022-11-18 12:24 ` paper42
2022-11-18 23:30 ` kruceter
2022-11-18 23:34 ` kruceter
2022-11-18 23:52 ` kruceter [this message]
2022-11-18 23:52 ` kruceter
2022-11-19 0:47 ` kruceter
2022-11-19 0:59 ` [PR PATCH] [Updated] " kruceter
2022-11-19 1:00 ` [PR REVIEW] " kruceter
2022-11-19 1:02 ` [PR PATCH] [Updated] " kruceter
2022-11-19 1:18 ` [PR REVIEW] " kruceter
2022-11-19 1:45 ` [PR PATCH] [Updated] " kruceter
2022-11-19 2:29 ` kruceter
2022-11-19 2:32 ` [PR REVIEW] " kruceter
2022-11-19 2:32 ` kruceter
2022-11-19 2:33 ` kruceter
2022-11-19 2:42 ` [PR PATCH] [Updated] " kruceter
2022-11-19 2:47 ` kruceter
2022-11-19 4:22 ` kruceter
2022-11-19 4:26 ` [PR REVIEW] " kruceter
2022-11-19 4:43 ` [PR PATCH] [Updated] " kruceter
2022-11-19 4:46 ` kruceter
2022-11-19 4:52 ` kruceter
2022-11-19 4:58 ` [PR REVIEW] " kruceter
2022-11-19 13:15 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118235242.G1JZl7RLQfzZrRzxxdlVkyvJxMQPPoN5hcRFtRTVziw@z \
--to=kruceter@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).