From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-matrix-nio: adopt, update to 0.20.1, update deps
Date: Sat, 19 Nov 2022 12:06:41 +0100 [thread overview]
Message-ID: <20221119110641.QkhzLR7igzkg2dO4eUEtxraoe4uFANuXaGAJJmqTWo4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40596@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
New review comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/40596#discussion_r1027075542
Comment:
this is definitely better than what we had before, but tbh, these are two really important tests for this library. They test core functionality, and deselecting those doesn't feel quite right.
next prev parent reply other threads:[~2022-11-19 11:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 13:49 [PR PATCH] " jcgruenhage
2022-11-18 14:28 ` [PR PATCH] [Updated] " jcgruenhage
2022-11-18 16:56 ` jcgruenhage
2022-11-18 19:09 ` icp1994
2022-11-18 19:49 ` [PR REVIEW] " icp1994
2022-11-18 19:49 ` icp1994
2022-11-18 19:49 ` icp1994
2022-11-18 19:49 ` icp1994
2022-11-18 19:49 ` icp1994
2022-11-18 19:49 ` icp1994
2022-11-18 19:49 ` icp1994
2022-11-18 19:49 ` icp1994
2022-11-19 11:06 ` jcgruenhage [this message]
2022-11-19 11:16 ` jcgruenhage
2022-11-19 11:18 ` jcgruenhage
2022-11-19 11:19 ` [PR PATCH] [Updated] " jcgruenhage
2022-11-19 11:23 ` jcgruenhage
2022-11-19 12:35 ` [PR REVIEW] " icp1994
2022-11-19 13:00 ` icp1994
2022-11-19 13:25 ` jcgruenhage
2022-11-27 12:27 ` [PR PATCH] [Updated] " jcgruenhage
2022-11-27 12:28 ` [PR REVIEW] " jcgruenhage
2022-11-27 12:29 ` [PR PATCH] [Updated] " jcgruenhage
2022-11-27 12:54 ` jcgruenhage
2022-11-28 16:57 ` non-Jedi
2022-11-30 10:08 ` [PR PATCH] [Updated] " jcgruenhage
2022-12-02 0:18 ` [PR PATCH] [Closed]: " Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221119110641.QkhzLR7igzkg2dO4eUEtxraoe4uFANuXaGAJJmqTWo4@z \
--to=jcgruenhage@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).