Github messages for voidlinux
 help / color / mirror / Atom feed
From: eli-schwartz <eli-schwartz@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Python3 linkage
Date: Thu, 24 Nov 2022 16:45:10 +0100	[thread overview]
Message-ID: <20221124154510.-hnBwcAek5klCNSWKaq7ByA991scl0THNTtf0Hdhbqo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40665@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

New comment by eli-schwartz on void-packages repository

https://github.com/void-linux/void-packages/pull/40665#issuecomment-1326611779

Comment:
Fixing mod_wsgi to link to libpython is correct, because upstream's configure script does so already. It was just an oversight that had it use python-config without `--embed`.

Generally linking to libpython for extension modules is probably wrong -- upstream Python specifically moved to requiring --embed for this, because anything that runs inside the python interpreter is expected to load whichever library the interpreter provides.

      parent reply	other threads:[~2022-11-24 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 14:49 [PR PATCH] " sgn
2022-11-21 15:28 ` [PR REVIEW] " ahesford
2022-11-24 15:35 ` sgn
2022-11-24 15:35 ` [PR PATCH] [Closed]: " sgn
2022-11-24 15:45 ` eli-schwartz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221124154510.-hnBwcAek5klCNSWKaq7ByA991scl0THNTtf0Hdhbqo@z \
    --to=eli-schwartz@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).