Re: [PR PATCH] [Updated] New package: xplr-0.20.0

[devraza <devraza@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There is an updated pull request by devraza against master on the void-packages repository

https://github.com/devraza/void-packages xplr
https://github.com/void-linux/void-packages/pull/40704

New package: xplr-0.20.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40704.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xplr-40704.patch --]
[-- Type: text/x-diff, Size: 4263 bytes --]

From 353d9178c587e43717f8068993cd351517566052 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Tue, 22 Nov 2022 21:58:00 +0000
Subject: [PATCH 1/4] New package: xplr-0.20.0

---
 srcpkgs/xplr/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..4f56ae05852f
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,20 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.20.0
+revision=1
+build_style=cargo
+short_desc="Hackable, minimal, fast TUI file explorer"
+maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
+license="MIT"
+homepage="https://github.com/sayanarjit/xplr"
+distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
+checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
+
+do_install() {
+	     vlicense LICENSE
+	     vdoc README.md
+	     vmkdir usr/share/doc/xplr/
+	     vcopy docs/en/src usr/share/doc/xplr/
+	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
+	     vbin ${_bin_path}/xplr
+}

From 59eb32876abea4c15c3f679ef21783519f9adab7 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:10:59 +0000
Subject: [PATCH 2/4] xplr: use post_install() instead of do_install()

This removes the need to specify the binary to install. Additionally, the 'usr/share/doc/xplr' is automatically created by xbps, so it does need to be manually created.
---
 srcpkgs/xplr/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 4f56ae05852f..0f57bd0da232 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -10,11 +10,8 @@ homepage="https://github.com/sayanarjit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 
-do_install() {
+post_install() {
 	     vlicense LICENSE
 	     vdoc README.md
-	     vmkdir usr/share/doc/xplr/
 	     vcopy docs/en/src usr/share/doc/xplr/
-	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
-	     vbin ${_bin_path}/xplr
 }

From b073b7a4901daa5e9f56f3e8c8b5447d26674ad7 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:11:44 +0000
Subject: [PATCH 3/4] xplr: typo in homepage

---
 srcpkgs/xplr/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 0f57bd0da232..7550706957d8 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -6,7 +6,7 @@ build_style=cargo
 short_desc="Hackable, minimal, fast TUI file explorer"
 maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
 license="MIT"
-homepage="https://github.com/sayanarjit/xplr"
+homepage="https://github.com/sayanarijit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 

From e34dd28abf08d4bb87f44da19c17f640ac956009 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Thu, 24 Nov 2022 19:01:11 +0000
Subject: [PATCH 4/4] xplr: documentation directory itself being copied

Instead, everything inside of the documentation directory should be
copied to '/usr/share/doc/xplr'. Mistake was made as the manual stated
that the 'vcopy' function copies everything inside of the pattern, and
not the pattern itself by default. Instead, the 'vcopy' function is
able to do this, but requires a '/*' following the directory which
needs it's contents being copied.
---
 srcpkgs/xplr/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 7550706957d8..f2948233261b 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -13,5 +13,5 @@ checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 post_install() {
 	     vlicense LICENSE
 	     vdoc README.md
-	     vcopy docs/en/src usr/share/doc/xplr/
+	     vcopy docs/en/src/* usr/share/doc/xplr/
 }