From: JamiKettunen <JamiKettunen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Vulkan 1.3.231
Date: Fri, 25 Nov 2022 01:56:26 +0100 [thread overview]
Message-ID: <20221125005626.UgNi74jd8Owkrn4JHqhBB_tuh5ncc2i1Lwnvot8agwQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40747@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2583 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40747#issuecomment-1326922601
Comment:
I tested locally and the [`vkcube` cross-build patch applies fine against `Vulkan-Tools` here](https://github.com/KhronosGroup/Vulkan-Tools/commit/e8234991418c5b0536e342bc849d5f8ed9eb6d6f) with `vkcube` and friend appearing in the package, would you mind including it already? Would be great to have this on non-x86 arches :)
Additionally building of `vkcube` has to be enabled for all arches with the following diff:
```diff
diff --git a/srcpkgs/Vulkan-Tools/template b/srcpkgs/Vulkan-Tools/template
index 4c59112cc1..c2a46ca477 100644
--- a/srcpkgs/Vulkan-Tools/template
+++ b/srcpkgs/Vulkan-Tools/template
@@ -3,9 +3,10 @@ pkgname=Vulkan-Tools
version=1.3.231.1
revision=1
build_style=cmake
-configure_args="-DGLSLANG_INSTALL_DIR=/usr -DBUILD_CUBE=$(vopt_if cube ON OFF)
+build_helper="qemu"
+configure_args="-DGLSLANG_INSTALL_DIR=/usr
-DVULKAN_HEADERS_INSTALL_DIR=${XBPS_CROSS_BASE}/usr -Wno-dev"
-hostmakedepends="python3 pkg-config $(vopt_if cube glslang)"
+hostmakedepends="python3 pkg-config glslang"
makedepends="Vulkan-Headers vulkan-loader libxcb-devel libxkbcommon-devel
wayland-devel wayland-protocols libXrandr-devel"
short_desc="Official Vulkan tools and utilities"
@@ -14,10 +15,3 @@ license="Apache-2.0"
homepage="https://www.khronos.org/vulkan/"
distfiles="https://github.com/KhronosGroup/Vulkan-Tools/archive/sdk-${version}.tar.gz"
checksum=0388207fdc0986ed8e03092a16d76913c7189d87a0d71eff4a914942b16b552a
-
-build_options="cube"
-desc_option_cube="Build cube vulkan demo"
-
-if [ -z "$CROSS_BUILD" ]; then
- build_options_default="cube"
-fi
```
QEMU build helper is here to "fix":
```
[1/19] Generating xdg-shell protocol header
FAILED: cube/xdg-shell-client-header.h /builddir/Vulkan-Tools-1.3.231.1/build/cube/xdg-shell-client-header.h
cd /builddir/Vulkan-Tools-1.3.231.1/build/cube && /usr/aarch64-linux-musl/usr/bin/wayland-scanner client-header /usr/aarch64-linux-musl/usr/share/wayland-protocols/stable/xdg-shell/xdg-shell.xml /builddir/Vulkan-Tools-1.3.231.1/build/cube/xdg-shell-client-header.h
qemu-aarch64-static: Could not open '/lib/ld-musl-aarch64.so.1': No such file or directory
...
```
`wayland-scaller` (from `wayland-devel`, adding it to `hostmakedepends` doesn't change anything) could probably be used from host instead of target right? so patching it and upstreaming the fix shouldn't be too bad (probably), didn't look into it though.
next prev parent reply other threads:[~2022-11-25 0:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 0:14 [PR PATCH] " tibequadorian
2022-11-25 0:41 ` [PR PATCH] [Updated] " tibequadorian
2022-11-25 0:56 ` JamiKettunen [this message]
2022-11-25 0:56 ` JamiKettunen
2022-11-25 0:58 ` JamiKettunen
2022-11-25 1:53 ` [PR PATCH] [Updated] " tibequadorian
2022-11-25 1:55 ` JamiKettunen
2022-11-25 1:56 ` [PR PATCH] [Updated] " tibequadorian
2022-11-25 2:12 ` tibequadorian
2022-11-25 10:09 ` JamiKettunen
2022-11-29 2:19 ` JamiKettunen
2022-12-03 18:38 ` [PR REVIEW] " JamiKettunen
2022-12-03 23:28 ` [PR PATCH] [Updated] " tibequadorian
2022-12-03 23:36 ` [PR REVIEW] " tibequadorian
2022-12-12 8:31 ` [PR PATCH] [Merged]: " classabbyamp
2022-12-12 9:13 ` tibequadorian
2022-12-12 15:52 ` paper42
2022-12-12 17:16 ` tibequadorian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125005626.UgNi74jd8Owkrn4JHqhBB_tuh5ncc2i1Lwnvot8agwQ@z \
--to=jamikettunen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).