Github messages for voidlinux
 help / color / mirror / Atom feed
From: kruceter <kruceter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] tracebox: fix build with glibc 2.36
Date: Fri, 25 Nov 2022 16:04:08 +0100	[thread overview]
Message-ID: <20221125150408.elF3BOhgxHxc-NjIDGkQd0Xt1G07QVSTvpxWBGp-oSc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40759@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

There is an updated pull request by kruceter against master on the void-packages repository

https://github.com/kruceter/void-packages tracebox_cxx14
https://github.com/void-linux/void-packages/pull/40759

tracebox: fix build with glibc 2.36
Credits go to Duncan Overbruck for suggesting to use -std=c++14 (see #40751).

[tracebox.txt](https://github.com/void-linux/void-packages/files/10093587/tracebox.txt)

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/40759.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tracebox_cxx14-40759.patch --]
[-- Type: text/x-diff, Size: 778 bytes --]

From 272e30ae2bac9c97bfbd8d1dffa9168b9ba340b0 Mon Sep 17 00:00:00 2001
From: Krul Ceter <kruceter@proton.me>
Date: Fri, 25 Nov 2022 17:27:37 +0300
Subject: [PATCH] tracebox: fix build with glibc 2.36

Credits go to Duncan Overbruck for suggesting to use -std=c++14.
---
 srcpkgs/tracebox/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/tracebox/template b/srcpkgs/tracebox/template
index ca5713072262..7537feae01f2 100644
--- a/srcpkgs/tracebox/template
+++ b/srcpkgs/tracebox/template
@@ -24,7 +24,7 @@ checksum="
  d3a182a06b86a0bff7f9f5792876f8da9db9dd7936f36ef1b40770c400f43b97"
 nocross=yes
 
-CXXFLAGS="-DHAVE_LUA_PUSHGLOBALTABLE=1"
+CXXFLAGS="-std=c++14 -DHAVE_LUA_PUSHGLOBALTABLE=1"
 
 pre_configure() {
 	mv tracebox-${version}/* .

  reply	other threads:[~2022-11-25 15:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25 14:53 [PR PATCH] " kruceter
2022-11-25 15:04 ` kruceter [this message]
2022-11-25 16:51 ` [PR PATCH] [Updated] " kruceter
2022-11-25 17:22 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221125150408.elF3BOhgxHxc-NjIDGkQd0Xt1G07QVSTvpxWBGp-oSc@z \
    --to=kruceter@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).