Re: [PR PATCH] [Updated] NetworkManager-openvpn : update to 1.8.18 + gtk4 support

[hsnfirdaus <hsnfirdaus@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

There is an updated pull request by hsnfirdaus against master on the void-packages repository

https://github.com/hsnfirdaus/void-packages nm-openvpn
https://github.com/void-linux/void-packages/pull/38942

NetworkManager-openvpn :  update to 1.8.18 + gtk4 support
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/38942.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nm-openvpn-38942.patch --]
[-- Type: text/x-diff, Size: 2382 bytes --]

From 9d45c420aab57be0f174d5f09a84cf20c1d4bbdc Mon Sep 17 00:00:00 2001
From: Muhammad Hasan Firdaus <hasanteam008@gmail.com>
Date: Sat, 27 Aug 2022 18:41:47 +0700
Subject: [PATCH 1/2] NetworkManager-openvpn :  update to 1.8.18 + gtk4 support

---
 srcpkgs/NetworkManager-openvpn/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/NetworkManager-openvpn/template b/srcpkgs/NetworkManager-openvpn/template
index c5f431c1c26c..1f5bcfa3268f 100644
--- a/srcpkgs/NetworkManager-openvpn/template
+++ b/srcpkgs/NetworkManager-openvpn/template
@@ -1,18 +1,18 @@
 # Template file for 'NetworkManager-openvpn'
 pkgname=NetworkManager-openvpn
-version=1.8.16
+version=1.8.18
 revision=1
 build_style=gnu-configure
-configure_args="--disable-static"
+configure_args="--disable-static --with-gtk4"
 hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
-makedepends="gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+makedepends="gtk+3-devel libglib-devel libnma-devel libsecret-devel gtk4-devel"
 depends="openvpn"
 short_desc="NetworkManager VPN plugin for OpenVPN"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://wiki.gnome.org/Projects/NetworkManager"
 distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=8920de09c7ae5f1f520c83f844455db8faec31427350268fe2dd95b860f91fb5
+checksum=53dfb0acf64478adc728074f162f62e60bff62a605bd897eb88b267e7057927a
 system_accounts="_nm_openvpn"
 lib32disabled=yes
 _nm_openvpn_homedir="/var/empty"

From e91c45f75f4e6b967166f5dd78ca76c4c436858d Mon Sep 17 00:00:00 2001
From: Muhammad Hasan Firdaus <hasanteam008@gmail.com>
Date: Mon, 28 Nov 2022 19:07:24 +0700
Subject: [PATCH 2/2] adjust vseed

---
 srcpkgs/NetworkManager-openvpn/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/NetworkManager-openvpn/template b/srcpkgs/NetworkManager-openvpn/template
index 1f5bcfa3268f..67db80103dfa 100644
--- a/srcpkgs/NetworkManager-openvpn/template
+++ b/srcpkgs/NetworkManager-openvpn/template
@@ -18,7 +18,7 @@ lib32disabled=yes
 _nm_openvpn_homedir="/var/empty"
 
 post_extract() {
-	sed -i 's/\(#define NM_OPENVPN_\(USER\|GROUP\)\).*/\1 "_nm_openvpn"/' \
+	vsed -i 's/\(#define NM_OPENVPN_\(USER\|GROUP\)\).*/\1 "_nm_openvpn"/' \
 		shared/nm-service-defines.h
 }