From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] rdma-core: update to 43.0.
Date: Fri, 02 Dec 2022 20:26:43 +0100 [thread overview]
Message-ID: <20221202192643.iUaAg1ljazcti4trYPgk_TZwDrMd0EeRnDxW2j9qioM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40866@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/40866#discussion_r1038460505
Comment:
Don't abuse `post_patch` for dynamic patching that doesn't need to be dynamic, especially not with `sed` which will happily and silently do nothing when your patterns cease to apply. Make a proper patch.
next prev parent reply other threads:[~2022-12-02 19:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 1:49 [PR PATCH] " kruceter
2022-12-02 3:57 ` classabbyamp
2022-12-02 19:26 ` ahesford [this message]
2022-12-02 19:29 ` [PR REVIEW] " ahesford
2022-12-02 19:35 ` [PR PATCH] [Updated] " kruceter
2022-12-02 19:38 ` kruceter
2022-12-02 19:51 ` kruceter
2022-12-02 19:51 ` [PR REVIEW] " kruceter
2022-12-02 19:52 ` kruceter
2022-12-05 14:55 ` [PR PATCH] [Updated] " kruceter
2022-12-21 19:32 ` kruceter
2022-12-26 3:22 ` kruceter
2023-01-02 3:19 ` kruceter
2023-01-06 12:29 ` [PR PATCH] [Closed]: rdma-core: update to 44.0 kruceter
2023-01-10 14:03 ` [PR PATCH] [Updated] " kruceter
2023-01-10 14:12 ` kruceter
2023-01-10 14:13 ` kruceter
2023-01-10 14:16 ` [PR PATCH] [Updated] " kruceter
2023-01-10 14:30 ` kruceter
2023-01-10 14:36 ` [PR PATCH] [Closed]: " ahesford
2023-01-10 14:43 ` kruceter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202192643.iUaAg1ljazcti4trYPgk_TZwDrMd0EeRnDxW2j9qioM@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).