From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: stepmania: fix build with gcc 12, ship ffmpeg 2.1.3 with distfiles
Date: Sat, 03 Dec 2022 20:03:12 +0100 [thread overview]
Message-ID: <20221203190312._f7ZEM4kZG6hmygCUNWKxXuurzrkwrrRjTA5ORQxpts@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40783@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
There's a merged pull request on the void-packages repository
stepmania: fix build with gcc 12, ship ffmpeg 2.1.3 with distfiles
https://github.com/void-linux/void-packages/pull/40783
Description:
If ffmpeg with specific version is not present in the work source directory, cmake attempts to clone its repository with git and check out version 2.1.3. This approach presents two issues:
1. It can no longer be cloned using git:// for github (see https://github.com/stepmania/stepmania/pull/2200) which results in connection timeout and build failure as the result.
2. Downloaded tarball is erased after successful build since it is considered to be part of the source code.
Its retrieval and storage for future use should be done by xbps-src.
cc: @the-maldridge as the current maintainer of the package.
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
prev parent reply other threads:[~2022-12-03 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 17:07 [PR PATCH] " kruceter
2022-12-03 13:01 ` [PR REVIEW] " paper42
2022-12-03 13:01 ` paper42
2022-12-03 13:01 ` paper42
2022-12-03 13:01 ` paper42
2022-12-03 13:01 ` paper42
2022-12-03 13:01 ` paper42
2022-12-03 14:15 ` [PR PATCH] [Updated] " kruceter
2022-12-03 14:21 ` kruceter
2022-12-03 19:03 ` paper42 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221203190312._f7ZEM4kZG6hmygCUNWKxXuurzrkwrrRjTA5ORQxpts@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).