From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: vosk-api-0.3.43
Date: Sun, 04 Dec 2022 13:46:00 +0100 [thread overview]
Message-ID: <20221204124600.c8Pm7OO1S2H9eSlb7NNJz-Nf_xKCLUcvmqP0oZF2jIw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39015@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39015#discussion_r1038962902
Comment:
This can be replaced by `patch_args="-Np1 -d ${pkgname}-${version}"` and `patches/kaldi-*.patch.args` files containing `-Np1 -d kaldi`. The kaldi directory currently contains version in its name like I suggest in a comment in `post_extract`. Then patches/series can be removed.
Not overriding do_patch is more consistent with other packages and gets rid of one unnecessary step when adding a patch.
Also a nitpick that's not important if we modify it this way, we usually try to follow keep the order of build steps in sync with order of functions, patch runs after extract, so do_patch should be after do_extract.
next prev parent reply other threads:[~2022-12-04 12:46 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 21:38 [PR PATCH] New package: libvosk-0.3.43 JohnGebbie
2022-09-02 7:33 ` JohnGebbie
2022-09-02 9:01 ` JohnGebbie
2022-09-02 18:59 ` JohnGebbie
2022-09-03 12:04 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-03 12:11 ` New package: vosk-api-0.3.43 JohnGebbie
2022-09-03 14:11 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-03 14:12 ` JohnGebbie
2022-09-03 14:13 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-03 14:14 ` JohnGebbie
2022-09-03 14:14 ` JohnGebbie
2022-09-03 20:52 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-04 8:26 ` JohnGebbie
2022-09-17 13:05 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-17 13:09 ` JohnGebbie
2022-09-18 11:00 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-21 15:53 ` JohnGebbie
2022-09-22 8:53 ` JohnGebbie
2022-09-22 9:26 ` [PR REVIEW] " paper42
2022-09-22 9:26 ` paper42
2022-09-22 14:39 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-22 14:43 ` JohnGebbie
2022-09-22 15:19 ` [PR REVIEW] " JohnGebbie
2022-09-22 18:16 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-22 19:32 ` JohnGebbie
2022-09-22 19:38 ` JohnGebbie
2022-09-22 20:31 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-22 20:33 ` JohnGebbie
2022-09-22 20:50 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-22 20:50 ` JohnGebbie
2022-09-23 8:55 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-23 9:14 ` JohnGebbie
2022-09-23 11:30 ` JohnGebbie
2022-09-23 17:21 ` JohnGebbie
2022-09-23 18:23 ` JohnGebbie
2022-09-26 22:16 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-26 22:18 ` JohnGebbie
2022-09-28 15:44 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-28 15:44 ` JohnGebbie
2022-09-28 15:53 ` JohnGebbie
2022-09-29 20:24 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-29 20:30 ` JohnGebbie
2022-09-30 9:15 ` JohnGebbie
2022-09-30 14:27 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-30 14:27 ` JohnGebbie
2022-09-30 14:30 ` JohnGebbie
2022-09-30 19:14 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-30 19:21 ` JohnGebbie
2022-09-30 19:47 ` JohnGebbie
2022-09-30 19:54 ` [PR PATCH] [Updated] " JohnGebbie
2022-09-30 21:15 ` JohnGebbie
2022-10-01 10:26 ` JohnGebbie
2022-10-02 16:27 ` JohnGebbie
2022-10-03 11:19 ` [PR PATCH] [Updated] " JohnGebbie
2022-10-03 11:21 ` JohnGebbie
2022-10-03 12:39 ` JohnGebbie
2022-10-04 19:17 ` JohnGebbie
2022-10-08 12:13 ` [PR PATCH] [Updated] " JohnGebbie
2022-10-08 12:15 ` JohnGebbie
2022-10-08 12:21 ` JohnGebbie
2022-10-08 14:32 ` [PR PATCH] [Updated] " JohnGebbie
2022-10-08 15:52 ` JohnGebbie
2022-10-08 16:24 ` [PR PATCH] [Updated] " JohnGebbie
2022-10-08 16:25 ` JohnGebbie
2022-10-08 16:33 ` JohnGebbie
2022-10-09 10:37 ` [PR PATCH] [Updated] " JohnGebbie
2022-10-09 10:38 ` JohnGebbie
2022-10-09 10:46 ` JohnGebbie
2022-10-26 15:57 ` JohnGebbie
2022-10-26 15:57 ` JohnGebbie
2022-10-26 15:57 ` JohnGebbie
2022-10-26 15:58 ` JohnGebbie
2022-10-26 15:58 ` JohnGebbie
2022-10-26 15:58 ` JohnGebbie
2022-10-26 15:59 ` JohnGebbie
2022-10-26 15:59 ` JohnGebbie
2022-10-26 15:59 ` JohnGebbie
2022-10-26 16:00 ` JohnGebbie
2022-10-26 16:00 ` JohnGebbie
2022-10-26 16:00 ` JohnGebbie
2022-10-26 16:01 ` JohnGebbie
2022-10-27 9:59 ` [PR PATCH] [Updated] " JohnGebbie
2022-10-27 10:18 ` JohnGebbie
2022-10-27 21:37 ` JohnGebbie
2022-10-28 8:33 ` JohnGebbie
2022-10-28 9:43 ` JohnGebbie
2022-10-28 17:01 ` [PR PATCH] [Updated] " JohnGebbie
2022-10-28 18:49 ` JohnGebbie
2022-10-28 20:15 ` JohnGebbie
2022-10-28 20:45 ` JohnGebbie
2022-10-28 21:42 ` JohnGebbie
2022-10-29 8:41 ` JohnGebbie
2022-10-29 11:45 ` JohnGebbie
2022-10-29 12:07 ` JohnGebbie
2022-10-29 14:09 ` JohnGebbie
2022-11-09 17:33 ` JohnGebbie
2022-11-14 22:54 ` [PR REVIEW] " paper42
2022-11-14 22:54 ` paper42
2022-11-14 22:54 ` paper42
2022-11-14 22:54 ` paper42
2022-11-14 22:54 ` paper42
2022-11-14 22:54 ` paper42
2022-11-14 22:54 ` paper42
2022-11-15 11:04 ` JohnGebbie
2022-11-15 13:38 ` [PR PATCH] [Updated] " JohnGebbie
2022-11-15 14:23 ` [PR REVIEW] " JohnGebbie
2022-11-15 14:24 ` JohnGebbie
2022-11-15 14:44 ` [PR PATCH] [Updated] " JohnGebbie
2022-11-15 14:54 ` [PR REVIEW] " JohnGebbie
2022-12-03 18:32 ` [PR PATCH] [Updated] " JohnGebbie
2022-12-03 18:37 ` JohnGebbie
2022-12-03 18:38 ` [PR REVIEW] " JohnGebbie
2022-12-03 18:43 ` JohnGebbie
2022-12-03 18:44 ` JohnGebbie
2022-12-03 18:47 ` JohnGebbie
2022-12-03 18:48 ` JohnGebbie
2022-12-03 20:52 ` JohnGebbie
2022-12-03 21:22 ` [PR PATCH] [Updated] " JohnGebbie
2022-12-03 21:26 ` JohnGebbie
2022-12-04 8:19 ` [PR PATCH] [Updated] " JohnGebbie
2022-12-04 8:21 ` JohnGebbie
2022-12-04 10:25 ` JohnGebbie
2022-12-04 12:46 ` [PR REVIEW] " paper42
2022-12-04 12:46 ` paper42
2022-12-04 12:46 ` paper42
2022-12-04 12:46 ` paper42 [this message]
2022-12-04 12:46 ` paper42
2022-12-04 13:52 ` [PR PATCH] [Updated] " JohnGebbie
2022-12-04 13:55 ` [PR REVIEW] " JohnGebbie
2022-12-04 14:04 ` paper42
2022-12-04 14:33 ` [PR PATCH] [Updated] " JohnGebbie
2022-12-04 16:09 ` JohnGebbie
2022-12-04 16:10 ` [PR PATCH] [Merged]: " paper42
2022-12-04 16:11 ` JohnGebbie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221204124600.c8Pm7OO1S2H9eSlb7NNJz-Nf_xKCLUcvmqP0oZF2jIw@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).