Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: common/xbps-src/shutils/update_check.sh: tweak url and rx for git.sr.ht
Date: Mon, 05 Dec 2022 03:37:32 +0100	[thread overview]
Message-ID: <20221205023732.un05NyI6I1c_8aGHYqfNivhPEKFROGftzd8vaBTzYEQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40372@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

There's a merged pull request on the void-packages repository

common/xbps-src/shutils/update_check.sh: tweak url and rx for git.sr.ht
https://github.com/void-linux/void-packages/pull/40372

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
- `grep -lr --include template git.sr.ht srcpkgs/ | cut -d/ -f2 | xargs -n1 ./xbps-src update-check`

A few packages with `git.sr.ht` upstream, such as [imv](https://git.sr.ht/~exec64/imv/refs), uses commit hash to name their release tarballs instead of a version string. These packages (imv, mymcplus, pc & dotool) all report `NO VERSION` to the update checker in current master.

With this change, the custom update file of `clickclack` breaks as it mitigated the issue mentioned above in a different way. But it's now redundant and reports updates correctly without a separate update file. `wlopm` (maintained by me) also had a redundant update file so I removed it too.

      parent reply	other threads:[~2022-12-05  2:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07  7:02 [PR PATCH] " icp1994
2022-11-09 14:30 ` JamiKettunen
2022-12-05  2:37 ` classabbyamp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205023732.un05NyI6I1c_8aGHYqfNivhPEKFROGftzd8vaBTzYEQ@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).