[PR PATCH] New package: omegat-4.3.3

[PR PATCH] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

There is a new pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages omegat
https://github.com/void-linux/void-packages/pull/40500

New package: omegat-4.3.3
Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - x86_64-musl
  - armv6l-glibc
  - armv6l-musl
  - i686-glibc


A patch file from https://github.com/void-linux/void-packages/pull/40500.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-omegat-40500.patch --]
[-- Type: text/x-diff, Size: 2397 bytes --]

From 7cbd42c009e05807f84c283bb964074832400783 Mon Sep 17 00:00:00 2001
From: Jorge Santiago <jsantiago12tone@gmail.com>
Date: Sun, 13 Nov 2022 04:08:30 -0300
Subject: [PATCH] New package: omegat-4.3.3

---
 srcpkgs/omegat/files/omegat.desktop |  9 +++++++++
 srcpkgs/omegat/files/omegat.sh      |  3 +++
 srcpkgs/omegat/template             | 26 ++++++++++++++++++++++++++
 3 files changed, 38 insertions(+)
 create mode 100644 srcpkgs/omegat/files/omegat.desktop
 create mode 100644 srcpkgs/omegat/files/omegat.sh
 create mode 100644 srcpkgs/omegat/template

diff --git a/srcpkgs/omegat/files/omegat.desktop b/srcpkgs/omegat/files/omegat.desktop
new file mode 100644
index 000000000000..430e4a206a11
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=OmegaT
+GenericName=OmegaT
+Exec=omegat
+Type=Application
+Comment=Multiplatform CAT tool application, written in Java
+Terminal=false
+Categories=Development;Translation;Java;
+Icon=omegat
diff --git a/srcpkgs/omegat/files/omegat.sh b/srcpkgs/omegat/files/omegat.sh
new file mode 100644
index 000000000000..37d066721357
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+cd /usr/share/java/omegat/ || exit 1
+java -jar -Xmx1024M OmegaT.jar "$@"
diff --git a/srcpkgs/omegat/template b/srcpkgs/omegat/template
new file mode 100644
index 000000000000..4f470817f546
--- /dev/null
+++ b/srcpkgs/omegat/template
@@ -0,0 +1,26 @@
+# Template file for 'omegat'
+pkgname=omegat
+version=4.3.3
+revision=1
+depends="openjdk-jre"
+short_desc="Multiplatform CAT tool application, written in Java"
+maintainer="Jorge Santiago <jsantiago12tone@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://omegat.org/"
+distfiles="${SOURCEFORGE_SITE}/omegat/OmegaT_${version}_Without_JRE.zip"
+checksum=60b3fde6d175e8c5b14631af6740fa28c94a1da7800515e74066f8b2918fe090
+nostrip=yes
+
+do_install() {
+	vdoc readme.txt
+	vdoc changes.txt
+	vdoc contributors.txt
+	vmkdir "usr/share/java/${pkgname}"
+	vcopy * "usr/share/java/${pkgname}"
+	vmkdir usr/share/applications
+	vinstall "${FILESDIR}/${pkgname}.desktop" 0644 "usr/share/applications/${pkgname}.desktop"
+	vmkdir usr/share/pixmaps
+	vinstall images/OmegaT.svg 0644 "usr/share/pixmaps/${pkgname}.svg"
+	vbin "${FILESDIR}/${pkgname}.sh" "${pkgname}"
+	rm -rf "usr/share/java/${pkgname}/{*.{zip,desktop,sh,kaptn},OmegaT,OmegaT.bat}"
+}

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859761

Comment:
the source code is available, we should use that instead

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859270

Comment:
this should be either `virtual?java-runtime` or a specific openjdk#-jre version, not this metapackage

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859440

Comment:
```suggestion
	vinstall images/OmegaT.svg 0644 usr/share/pixmaps/
```

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859568

Comment:
not necessary
```suggestion
```

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859418

Comment:
don't use `$pkgname` in this function, it's longer than the value of it

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859469

Comment:
```suggestion
	vinstall "${FILESDIR}/${pkgname}.desktop" 0644 usr/share/applications/
```

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859604

Comment:
```suggestion
```
also not necessary

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859860

Comment:
this will only rm things in $wrksrc, which does nothing to the output package

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1020859998

Comment:
```suggestion
short_desc="Multiplatform CAT tool application"
```

Re: [PR PATCH] [Updated] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages omegat
https://github.com/void-linux/void-packages/pull/40500

New package: omegat-4.3.3
Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - x86_64-musl
  - armv6l-glibc
  - armv6l-musl
  - i686-glibc


A patch file from https://github.com/void-linux/void-packages/pull/40500.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-omegat-40500.patch --]
[-- Type: text/x-diff, Size: 2390 bytes --]

From 6e1babfab179911809264022f700335b3b3bae35 Mon Sep 17 00:00:00 2001
From: Jorge Santiago <jsantiago12tone@gmail.com>
Date: Sun, 13 Nov 2022 04:08:30 -0300
Subject: [PATCH] New package: omegat-4.3.3

---
 srcpkgs/omegat/files/omegat.desktop |  9 +++++++++
 srcpkgs/omegat/files/omegat.sh      |  3 +++
 srcpkgs/omegat/template             | 27 +++++++++++++++++++++++++++
 3 files changed, 39 insertions(+)
 create mode 100644 srcpkgs/omegat/files/omegat.desktop
 create mode 100644 srcpkgs/omegat/files/omegat.sh
 create mode 100644 srcpkgs/omegat/template

diff --git a/srcpkgs/omegat/files/omegat.desktop b/srcpkgs/omegat/files/omegat.desktop
new file mode 100644
index 000000000000..430e4a206a11
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=OmegaT
+GenericName=OmegaT
+Exec=omegat
+Type=Application
+Comment=Multiplatform CAT tool application, written in Java
+Terminal=false
+Categories=Development;Translation;Java;
+Icon=omegat
diff --git a/srcpkgs/omegat/files/omegat.sh b/srcpkgs/omegat/files/omegat.sh
new file mode 100644
index 000000000000..37d066721357
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+cd /usr/share/java/omegat/ || exit 1
+java -jar -Xmx1024M OmegaT.jar "$@"
diff --git a/srcpkgs/omegat/template b/srcpkgs/omegat/template
new file mode 100644
index 000000000000..061a84acec93
--- /dev/null
+++ b/srcpkgs/omegat/template
@@ -0,0 +1,27 @@
+# Template file for 'omegat'
+pkgname=omegat
+version=4.3.3
+revision=1
+hostmakedepends="openjdk8"
+depends="virtual?java-runtime"
+short_desc="Multiplatform CAT tool application"
+maintainer="Jorge Santiago <jsantiago12tone@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://omegat.org/"
+distfiles="https://sourceforge.net/projects/omegat/files/OmegaT%20-%20Standard/OmegaT%20${version}/OmegaT_${version}_Source.zip"
+checksum=3cb39c9357aefe6efb274e1ee56f1ece57141b73a40a2416a7b405a6c8123184
+
+do_build() {
+	JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk ./gradlew -x test installDist
+}
+
+do_install() {
+	cd build/install/OmegaT
+	vmkdir usr/share/doc/omegat
+	vcopy docs usr/share/doc/omegat
+	vmkdir usr/share/java/omegat
+	vcopy "*" usr/share/java/omegat
+	vinstall "${FILESDIR}/omegat.desktop" 0644 usr/share/applications/
+	vinstall images/OmegaT.svg 0644 usr/share/pixmaps/omegat.svg
+	vbin "${FILESDIR}/omegat.sh" omegat
+}

Re: New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#issuecomment-1312807866

Comment:
Just committed those changes, also changing the docs that are copied and making the necessary changes to build the package.
I did not use the SOURCEFORGE_SITE variable in distfiles because it was defaulting to downloading the Nightly build.

Re: [PR PATCH] [Updated] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages omegat
https://github.com/void-linux/void-packages/pull/40500

New package: omegat-4.3.3
Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - x86_64-musl
  - armv6l-glibc
  - armv6l-musl
  - i686-glibc


A patch file from https://github.com/void-linux/void-packages/pull/40500.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-omegat-40500.patch --]
[-- Type: text/x-diff, Size: 2438 bytes --]

From fff5f8ffd95932efc0c6a8866e1edcb4138a1f27 Mon Sep 17 00:00:00 2001
From: Jorge Santiago <jsantiago12tone@gmail.com>
Date: Sun, 13 Nov 2022 04:08:30 -0300
Subject: [PATCH] New package: omegat-4.3.3

---
 srcpkgs/omegat/files/omegat.desktop |  9 +++++++++
 srcpkgs/omegat/files/omegat.sh      |  3 +++
 srcpkgs/omegat/template             | 30 +++++++++++++++++++++++++++++
 3 files changed, 42 insertions(+)
 create mode 100644 srcpkgs/omegat/files/omegat.desktop
 create mode 100644 srcpkgs/omegat/files/omegat.sh
 create mode 100644 srcpkgs/omegat/template

diff --git a/srcpkgs/omegat/files/omegat.desktop b/srcpkgs/omegat/files/omegat.desktop
new file mode 100644
index 000000000000..430e4a206a11
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=OmegaT
+GenericName=OmegaT
+Exec=omegat
+Type=Application
+Comment=Multiplatform CAT tool application, written in Java
+Terminal=false
+Categories=Development;Translation;Java;
+Icon=omegat
diff --git a/srcpkgs/omegat/files/omegat.sh b/srcpkgs/omegat/files/omegat.sh
new file mode 100644
index 000000000000..37d066721357
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+cd /usr/share/java/omegat/ || exit 1
+java -jar -Xmx1024M OmegaT.jar "$@"
diff --git a/srcpkgs/omegat/template b/srcpkgs/omegat/template
new file mode 100644
index 000000000000..74e48b109764
--- /dev/null
+++ b/srcpkgs/omegat/template
@@ -0,0 +1,30 @@
+# Template file for 'omegat'
+pkgname=omegat
+version=4.3.3
+revision=1
+hostmakedepends="openjdk8"
+depends="virtual?java-runtime"
+short_desc="Multiplatform CAT tool application"
+maintainer="Jorge Santiago <jsantiago12tone@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://omegat.org/"
+distfiles="https://sourceforge.net/projects/omegat/files/OmegaT%20-%20Standard/OmegaT%20${version}/OmegaT_${version}_Source.zip"
+checksum=3cb39c9357aefe6efb274e1ee56f1ece57141b73a40a2416a7b405a6c8123184
+
+do_build() {
+	JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk ./gradlew -x test installDist
+}
+
+do_install() {
+	cd build/install/OmegaT
+	vmkdir usr/share/java/omegat
+	vcopy "*" usr/share/java/omegat
+	vinstall "${FILESDIR}/omegat.desktop" 644 usr/share/applications/
+	vinstall images/OmegaT.svg 644 usr/share/pixmaps/omegat.svg
+	vbin "${FILESDIR}/omegat.sh" omegat
+}
+
+post_install() {
+	vmkdir usr/share/doc/omegat
+	vcopy "build/install/OmegaT/docs/*" usr/share/doc/omegat
+}

Re: New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#issuecomment-1313090033

Comment:
Put the stuff related to documentation in post_install, also made it so that it only copies the doc files and directories themselves instead of the parent directory.

btw I don't know why the CI test failed in the "fix-permissions" step previously, I ran `./xbps-src -Q pkg omegat` locally and everything went smoothly.

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1022042650

Comment:
```suggestion
distfiles="${SOURCEFORGE_SITE}/omegat/OmegaT%20-%20Standard/OmegaT%20${version}/OmegaT_${version}_Source.zip"
```
this version of the url should work, i think

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1022120572

Comment:
```suggestion
	vcopy "build/install/OmegaT/docs/*" usr/share/doc/omegat
	chmod -R 644 ${DESTDIR}/usr/share/doc/omegat
```
this should fix the build error

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1022119893

Comment:
```suggestion
```
no need to split this up when overriding do_install

Re: [PR REVIEW] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1022207997

Comment:
Had tried it, it expands to https://master.dl.sourceforge.net/project/omegat/Nightly/OmegaT_4.3.3_Source.zip?viasf=1l, downloading the nightly version.

Re: [PR REVIEW] New package: omegat-4.3.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1022208604

Comment:
is the zip file the same though? see if it has the same shasum

Re: [PR PATCH] [Updated] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages omegat
https://github.com/void-linux/void-packages/pull/40500

New package: omegat-4.3.3
Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - x86_64-musl
  - armv6l-glibc
  - armv6l-musl
  - i686-glibc


A patch file from https://github.com/void-linux/void-packages/pull/40500.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-omegat-40500.patch --]
[-- Type: text/x-diff, Size: 2624 bytes --]

From 027036a6c7864bf5076d2dbdaf86b303836139cd Mon Sep 17 00:00:00 2001
From: Jorge Santiago <jsantiago12tone@gmail.com>
Date: Sun, 13 Nov 2022 04:08:30 -0300
Subject: [PATCH] New package: omegat-4.3.3

---
 srcpkgs/omegat/files/omegat.desktop |  9 +++++++
 srcpkgs/omegat/files/omegat.sh      |  3 +++
 srcpkgs/omegat/template             | 42 +++++++++++++++++++++++++++++
 3 files changed, 54 insertions(+)
 create mode 100644 srcpkgs/omegat/files/omegat.desktop
 create mode 100644 srcpkgs/omegat/files/omegat.sh
 create mode 100644 srcpkgs/omegat/template

diff --git a/srcpkgs/omegat/files/omegat.desktop b/srcpkgs/omegat/files/omegat.desktop
new file mode 100644
index 000000000000..f163f9623886
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=OmegaT
+GenericName=OmegaT
+Exec=omegat
+Type=Application
+Comment=Multiplatform CAT tool
+Terminal=false
+Categories=Development;Translation;Java;
+Icon=omegat
diff --git a/srcpkgs/omegat/files/omegat.sh b/srcpkgs/omegat/files/omegat.sh
new file mode 100644
index 000000000000..37d066721357
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+cd /usr/share/java/omegat/ || exit 1
+java -jar -Xmx1024M OmegaT.jar "$@"
diff --git a/srcpkgs/omegat/template b/srcpkgs/omegat/template
new file mode 100644
index 000000000000..fc5a8a731acc
--- /dev/null
+++ b/srcpkgs/omegat/template
@@ -0,0 +1,42 @@
+# Template file for 'omegat'
+pkgname=omegat
+version=4.3.3
+revision=1
+hostmakedepends="openjdk8"
+depends="virtual?java-runtime"
+short_desc="Multiplatform CAT tool application"
+maintainer="Jorge Santiago <jsantiago12tone@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://omegat.org/"
+distfiles="https://sourceforge.net/projects/omegat/files/OmegaT%20-%20Standard/OmegaT%20${version}/OmegaT_${version}_Source.zip"
+checksum=3cb39c9357aefe6efb274e1ee56f1ece57141b73a40a2416a7b405a6c8123184
+
+do_build() {
+	JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk ./gradlew -x test installDist
+}
+
+post_build() {
+	cd build
+	rm -rf classes generated libs resources tmp
+}
+
+do_install() {
+	OMEGATDIR=usr/share/java/omegat
+	cd build/install/OmegaT
+	for file in *.txt; do
+		if [[ $file == *"license"* ]]; then
+			continue
+		fi
+		vdoc "$file"
+	done
+
+	vmkdir "${OMEGATDIR}"
+	vcopy images "$OMEGATDIR"
+	vcopy lib "$OMEGATDIR"
+	vcopy plugins "$OMEGATDIR"
+	vcopy scripts "$OMEGATDIR"
+	vinstall images/OmegaT.svg 644 usr/share/pixmaps/omegat.svg
+	vinstall "${FILESDIR}/omegat.desktop" 644 usr/share/applications
+	vinstall OmegaT.jar 644 "${OMEGATDIR}"
+	vbin "${FILESDIR}/omegat.sh" omegat
+}

Re: [PR REVIEW] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1022299855

Comment:
It wasn't, had checked it.

Re: [PR REVIEW] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1022300547

Comment:
Instead of using vcopy to copy the entire directory, I'm now using vdoc on the actual documentation files that come specifically with the local build. Should fix it, indeed.

Re: [PR REVIEW] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1022300547

Comment:
Instead of using vcopy to copy the entire directory, I'm now using vdoc on the actual documentation files that come specifically with the local build. Should fix it, indeed.
That is, of course, if the vcopy on the other directories don't create a new problem :p

Re: [PR REVIEW] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#discussion_r1023105070

Comment:
Copying the directories with vcopy also result in the permission build error, and when trying to `chmod -R 644`, it gives me `chmod: cannot access '{path to file}': Permission denied`.

Re: [PR PATCH] [Updated] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages omegat
https://github.com/void-linux/void-packages/pull/40500

New package: omegat-4.3.3
Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - x86_64-musl
  - armv6l-glibc
  - armv6l-musl
  - i686-glibc


A patch file from https://github.com/void-linux/void-packages/pull/40500.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-omegat-40500.patch --]
[-- Type: text/x-diff, Size: 2540 bytes --]

From d0ea83f3395bbde4a2874c4ae8e3176a5057f462 Mon Sep 17 00:00:00 2001
From: Jorge Santiago <jsantiago12tone@gmail.com>
Date: Sun, 13 Nov 2022 04:08:30 -0300
Subject: [PATCH] New package: omegat-4.3.3

---
 srcpkgs/omegat/files/omegat.desktop |  9 +++++++
 srcpkgs/omegat/files/omegat.sh      |  3 +++
 srcpkgs/omegat/template             | 40 +++++++++++++++++++++++++++++
 3 files changed, 52 insertions(+)
 create mode 100644 srcpkgs/omegat/files/omegat.desktop
 create mode 100644 srcpkgs/omegat/files/omegat.sh
 create mode 100644 srcpkgs/omegat/template

diff --git a/srcpkgs/omegat/files/omegat.desktop b/srcpkgs/omegat/files/omegat.desktop
new file mode 100644
index 000000000000..dba53a01fbfb
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=OmegaT
+GenericName=OmegaT
+Exec=omegat
+Type=Application
+Comment=Multiplatform CAT application
+Terminal=false
+Categories=Development;Translation;Java;
+Icon=omegat
diff --git a/srcpkgs/omegat/files/omegat.sh b/srcpkgs/omegat/files/omegat.sh
new file mode 100644
index 000000000000..8e1080fa8e4f
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+cd /opt/omegat/ || exit 1
+java -jar -Xmx1024M OmegaT.jar "$@"
diff --git a/srcpkgs/omegat/template b/srcpkgs/omegat/template
new file mode 100644
index 000000000000..12f21a20d110
--- /dev/null
+++ b/srcpkgs/omegat/template
@@ -0,0 +1,40 @@
+# Template file for 'omegat'
+pkgname=omegat
+version=4.3.3
+revision=1
+hostmakedepends="openjdk8"
+depends="virtual?java-runtime"
+short_desc="Multiplatform CAT application"
+maintainer="Jorge Santiago <jsantiago12tone@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://omegat.org/"
+distfiles="https://sourceforge.net/projects/omegat/files/OmegaT%20-%20Standard/OmegaT%20${version}/OmegaT_${version}_Source.zip"
+checksum=3cb39c9357aefe6efb274e1ee56f1ece57141b73a40a2416a7b405a6c8123184
+
+do_build() {
+	JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk ./gradlew -x test installDist
+}
+
+do_install() {
+	OMEGATDIR=opt/omegat
+
+	cd build/install/OmegaT
+	vmkdir "${OMEGATDIR}"
+
+	vcopy images "${OMEGATDIR}"
+	vcopy lib "${OMEGATDIR}"
+	vcopy plugins "${OMEGATDIR}"
+	vcopy scripts "${OMEGATDIR}"
+
+	vinstall OmegaT.jar 644 "${OMEGATDIR}"
+	vbin "${FILESDIR}/omegat.sh" omegat
+	vinstall images/OmegaT.svg 644 usr/share/pixmaps omegat.svg
+	vinstall "${FILESDIR}/omegat.desktop" 644 usr/share/applications
+
+	for file in *.txt; do
+		if [[ $file == *"license"* ]]; then
+			continue
+		fi
+		vdoc "$file"
+	done
+}

Re: [PR PATCH] [Updated] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages omegat
https://github.com/void-linux/void-packages/pull/40500

New package: omegat-4.3.3
Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - x86_64-musl
  - armv6l-glibc
  - armv6l-musl
  - i686-glibc


A patch file from https://github.com/void-linux/void-packages/pull/40500.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-omegat-40500.patch --]
[-- Type: text/x-diff, Size: 2540 bytes --]

From d0ea83f3395bbde4a2874c4ae8e3176a5057f462 Mon Sep 17 00:00:00 2001
From: Jorge Santiago <jsantiago12tone@gmail.com>
Date: Sun, 13 Nov 2022 04:08:30 -0300
Subject: [PATCH] New package: omegat-4.3.3

---
 srcpkgs/omegat/files/omegat.desktop |  9 +++++++
 srcpkgs/omegat/files/omegat.sh      |  3 +++
 srcpkgs/omegat/template             | 40 +++++++++++++++++++++++++++++
 3 files changed, 52 insertions(+)
 create mode 100644 srcpkgs/omegat/files/omegat.desktop
 create mode 100644 srcpkgs/omegat/files/omegat.sh
 create mode 100644 srcpkgs/omegat/template

diff --git a/srcpkgs/omegat/files/omegat.desktop b/srcpkgs/omegat/files/omegat.desktop
new file mode 100644
index 000000000000..dba53a01fbfb
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=OmegaT
+GenericName=OmegaT
+Exec=omegat
+Type=Application
+Comment=Multiplatform CAT application
+Terminal=false
+Categories=Development;Translation;Java;
+Icon=omegat
diff --git a/srcpkgs/omegat/files/omegat.sh b/srcpkgs/omegat/files/omegat.sh
new file mode 100644
index 000000000000..8e1080fa8e4f
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+cd /opt/omegat/ || exit 1
+java -jar -Xmx1024M OmegaT.jar "$@"
diff --git a/srcpkgs/omegat/template b/srcpkgs/omegat/template
new file mode 100644
index 000000000000..12f21a20d110
--- /dev/null
+++ b/srcpkgs/omegat/template
@@ -0,0 +1,40 @@
+# Template file for 'omegat'
+pkgname=omegat
+version=4.3.3
+revision=1
+hostmakedepends="openjdk8"
+depends="virtual?java-runtime"
+short_desc="Multiplatform CAT application"
+maintainer="Jorge Santiago <jsantiago12tone@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://omegat.org/"
+distfiles="https://sourceforge.net/projects/omegat/files/OmegaT%20-%20Standard/OmegaT%20${version}/OmegaT_${version}_Source.zip"
+checksum=3cb39c9357aefe6efb274e1ee56f1ece57141b73a40a2416a7b405a6c8123184
+
+do_build() {
+	JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk ./gradlew -x test installDist
+}
+
+do_install() {
+	OMEGATDIR=opt/omegat
+
+	cd build/install/OmegaT
+	vmkdir "${OMEGATDIR}"
+
+	vcopy images "${OMEGATDIR}"
+	vcopy lib "${OMEGATDIR}"
+	vcopy plugins "${OMEGATDIR}"
+	vcopy scripts "${OMEGATDIR}"
+
+	vinstall OmegaT.jar 644 "${OMEGATDIR}"
+	vbin "${FILESDIR}/omegat.sh" omegat
+	vinstall images/OmegaT.svg 644 usr/share/pixmaps omegat.svg
+	vinstall "${FILESDIR}/omegat.desktop" 644 usr/share/applications
+
+	for file in *.txt; do
+		if [[ $file == *"license"* ]]; then
+			continue
+		fi
+		vdoc "$file"
+	done
+}

Re: [PR PATCH] [Updated] New package: omegat-4.3.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages omegat
https://github.com/void-linux/void-packages/pull/40500

New package: omegat-4.3.3
Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - x86_64-musl
  - armv6l-glibc
  - armv6l-musl
  - i686-glibc


A patch file from https://github.com/void-linux/void-packages/pull/40500.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-omegat-40500.patch --]
[-- Type: text/x-diff, Size: 2540 bytes --]

From d0ea83f3395bbde4a2874c4ae8e3176a5057f462 Mon Sep 17 00:00:00 2001
From: Jorge Santiago <jsantiago12tone@gmail.com>
Date: Sun, 13 Nov 2022 04:08:30 -0300
Subject: [PATCH] New package: omegat-4.3.3

---
 srcpkgs/omegat/files/omegat.desktop |  9 +++++++
 srcpkgs/omegat/files/omegat.sh      |  3 +++
 srcpkgs/omegat/template             | 40 +++++++++++++++++++++++++++++
 3 files changed, 52 insertions(+)
 create mode 100644 srcpkgs/omegat/files/omegat.desktop
 create mode 100644 srcpkgs/omegat/files/omegat.sh
 create mode 100644 srcpkgs/omegat/template

diff --git a/srcpkgs/omegat/files/omegat.desktop b/srcpkgs/omegat/files/omegat.desktop
new file mode 100644
index 000000000000..dba53a01fbfb
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=OmegaT
+GenericName=OmegaT
+Exec=omegat
+Type=Application
+Comment=Multiplatform CAT application
+Terminal=false
+Categories=Development;Translation;Java;
+Icon=omegat
diff --git a/srcpkgs/omegat/files/omegat.sh b/srcpkgs/omegat/files/omegat.sh
new file mode 100644
index 000000000000..8e1080fa8e4f
--- /dev/null
+++ b/srcpkgs/omegat/files/omegat.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+cd /opt/omegat/ || exit 1
+java -jar -Xmx1024M OmegaT.jar "$@"
diff --git a/srcpkgs/omegat/template b/srcpkgs/omegat/template
new file mode 100644
index 000000000000..12f21a20d110
--- /dev/null
+++ b/srcpkgs/omegat/template
@@ -0,0 +1,40 @@
+# Template file for 'omegat'
+pkgname=omegat
+version=4.3.3
+revision=1
+hostmakedepends="openjdk8"
+depends="virtual?java-runtime"
+short_desc="Multiplatform CAT application"
+maintainer="Jorge Santiago <jsantiago12tone@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://omegat.org/"
+distfiles="https://sourceforge.net/projects/omegat/files/OmegaT%20-%20Standard/OmegaT%20${version}/OmegaT_${version}_Source.zip"
+checksum=3cb39c9357aefe6efb274e1ee56f1ece57141b73a40a2416a7b405a6c8123184
+
+do_build() {
+	JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk ./gradlew -x test installDist
+}
+
+do_install() {
+	OMEGATDIR=opt/omegat
+
+	cd build/install/OmegaT
+	vmkdir "${OMEGATDIR}"
+
+	vcopy images "${OMEGATDIR}"
+	vcopy lib "${OMEGATDIR}"
+	vcopy plugins "${OMEGATDIR}"
+	vcopy scripts "${OMEGATDIR}"
+
+	vinstall OmegaT.jar 644 "${OMEGATDIR}"
+	vbin "${FILESDIR}/omegat.sh" omegat
+	vinstall images/OmegaT.svg 644 usr/share/pixmaps omegat.svg
+	vinstall "${FILESDIR}/omegat.desktop" 644 usr/share/applications
+
+	for file in *.txt; do
+		if [[ $file == *"license"* ]]; then
+			continue
+		fi
+		vdoc "$file"
+	done
+}

Re: New package: omegat-4.3.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/40500#issuecomment-1457385964

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: omegat-4.3.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

There's a closed pull request on the void-packages repository

New package: omegat-4.3.3
https://github.com/void-linux/void-packages/pull/40500

Description:
Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - x86_64-musl
  - armv6l-glibc
  - armv6l-musl
  - i686-glibc