Github messages for voidlinux
 help / color / mirror / Atom feed
From: hervyqa <hervyqa@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] inkscape: update to 1.2.2
Date: Wed, 07 Dec 2022 07:12:55 +0100	[thread overview]
Message-ID: <20221207061255.EhcYxTVcnCDjGTGQ_UOEdArFGRwXk2Na4dl6P6PZgs8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35454@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is an updated pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages inkscape
https://github.com/void-linux/void-packages/pull/35454

inkscape: update to 1.2.2
add `python3-cssselect` to open "Manage Extensions" dialog.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64, x86_64-musl)

#### 1.1.2 (x86_64)

![image](https://user-images.githubusercontent.com/45872139/152723191-4f9a8384-fedb-48e5-8989-fc0a52eda812.png)

### Update:
#### 1.2.1 (x86_64)

![Screenshot_20220518_144113](https://user-images.githubusercontent.com/45872139/168985134-2279a126-8c42-4fcc-8d33-21bef08be529.png)

#### 1.2.1 (x86_64-musl)

![Screenshot_20220518_090746](https://user-images.githubusercontent.com/45872139/169003017-2cfe0bbc-d002-4390-9316-f7eb816e4a20.png)

A patch file from https://github.com/void-linux/void-packages/pull/35454.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-inkscape-35454.patch --]
[-- Type: text/x-diff, Size: 11946 bytes --]

From b2c0961c3bd6a365a058cf4f2b534a51f53b26d1 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@proton.me>
Date: Sun, 4 Dec 2022 09:48:49 +0700
Subject: [PATCH] inkscape: update to 1.2.2

---
 ...ibility-with-Poppler-22.03-and-later.patch |  50 ------
 .../Fix-build-with-poppler-21.11.0.patch      |  29 ----
 .../Fix-build-with-poppler-22.04.patch        | 143 ------------------
 srcpkgs/inkscape/template                     |  10 +-
 4 files changed, 5 insertions(+), 227 deletions(-)
 delete mode 100644 srcpkgs/inkscape/patches/Ensure-compatibility-with-Poppler-22.03-and-later.patch
 delete mode 100644 srcpkgs/inkscape/patches/Fix-build-with-poppler-21.11.0.patch
 delete mode 100644 srcpkgs/inkscape/patches/Fix-build-with-poppler-22.04.patch

diff --git a/srcpkgs/inkscape/patches/Ensure-compatibility-with-Poppler-22.03-and-later.patch b/srcpkgs/inkscape/patches/Ensure-compatibility-with-Poppler-22.03-and-later.patch
deleted file mode 100644
index 297ef677665e..000000000000
--- a/srcpkgs/inkscape/patches/Ensure-compatibility-with-Poppler-22.03-and-later.patch
+++ /dev/null
@@ -1,50 +0,0 @@
-From a18c57ffff313fd08bc8a44f6b6bf0b01d7e9b75 Mon Sep 17 00:00:00 2001
-From: Evangelos Foutras <evangelos@foutrelis.com>
-Date: Sun, 20 Mar 2022 22:41:51 -0300
-Subject: [PATCH] Ensure compatibility with Poppler 22.03 and later
-
-This change ensures that Inkscape will build against Poppler 22.03 after
-the changes that were made to the constructor of `PDFDoc`.
-
-See: https://gitlab.freedesktop.org/poppler/poppler/-/commit/4f2abd3ef
-
-Co-authored-by: Rafael Siejakowski <rs@rs-math.net>
----
- src/extension/internal/pdfinput/pdf-input.cpp            | 3 +--
- src/extension/internal/pdfinput/poppler-transition-api.h | 6 ++++++
- 2 files changed, 7 insertions(+), 2 deletions(-)
-
-diff --git a/src/extension/internal/pdfinput/pdf-input.cpp b/src/extension/internal/pdfinput/pdf-input.cpp
-index 3dabc94ba2..079b0dc713 100644
---- a/src/extension/internal/pdfinput/pdf-input.cpp
-+++ b/src/extension/internal/pdfinput/pdf-input.cpp
-@@ -688,8 +688,7 @@ PdfInput::open(::Inkscape::Extension::Input * /*mod*/, const gchar * uri) {
- 
-     // poppler does not use glib g_open. So on win32 we must use unicode call. code was copied from
-     // glib gstdio.c
--    GooString *filename_goo = new GooString(uri);
--    pdf_doc = std::make_shared<PDFDoc>(filename_goo, nullptr, nullptr, nullptr);   // TODO: Could ask for password
-+    pdf_doc = _POPPLER_MAKE_SHARED_PDFDOC(uri); // TODO: Could ask for password
- 
-     if (!pdf_doc->isOk()) {
-         int error = pdf_doc->getErrorCode();
-diff --git a/src/extension/internal/pdfinput/poppler-transition-api.h b/src/extension/internal/pdfinput/poppler-transition-api.h
-index 87a19d4c42..50b617c25c 100644
---- a/src/extension/internal/pdfinput/poppler-transition-api.h
-+++ b/src/extension/internal/pdfinput/poppler-transition-api.h
-@@ -14,6 +14,12 @@
- 
- #include <glib/poppler-features.h>
- 
-+#if POPPLER_CHECK_VERSION(22, 3, 0)
-+#define _POPPLER_MAKE_SHARED_PDFDOC(uri) std::make_shared<PDFDoc>(std::make_unique<GooString>(uri))
-+#else
-+#define _POPPLER_MAKE_SHARED_PDFDOC(uri) std::make_shared<PDFDoc>(new GooString(uri), nullptr, nullptr, nullptr)
-+#endif
-+
- #if POPPLER_CHECK_VERSION(0, 83, 0)
- #define _POPPLER_CONST_83 const
- #else
--- 
-GitLab
-
diff --git a/srcpkgs/inkscape/patches/Fix-build-with-poppler-21.11.0.patch b/srcpkgs/inkscape/patches/Fix-build-with-poppler-21.11.0.patch
deleted file mode 100644
index 5d7f4801273d..000000000000
--- a/srcpkgs/inkscape/patches/Fix-build-with-poppler-21.11.0.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-From 5724c21b9cb7b6176a7b36ca24068b148c817e82 Mon Sep 17 00:00:00 2001
-From: Evangelos Foutras <evangelos@foutrelis.com>
-Date: Mon, 1 Nov 2021 21:45:38 +0200
-Subject: [PATCH] Fix build with poppler 21.11.0
-
-GfxFont::tag is now of type std::string instead of GooString *.
----
- src/extension/internal/pdfinput/pdf-parser.cpp | 4 ++++
- 1 file changed, 4 insertions(+)
-
-diff --git a/src/extension/internal/pdfinput/pdf-parser.cpp b/src/extension/internal/pdfinput/pdf-parser.cpp
-index e3d04d544b..feecefa043 100644
---- a/src/extension/internal/pdfinput/pdf-parser.cpp
-+++ b/src/extension/internal/pdfinput/pdf-parser.cpp
-@@ -2169,7 +2169,11 @@ void PdfParser::opSetFont(Object args[], int /*numArgs*/)
-   }
-   if (printCommands) {
-     printf("  font: tag=%s name='%s' %g\n",
-+#if POPPLER_CHECK_VERSION(21,11,0)
-+	   font->getTag().c_str(),
-+#else
- 	   font->getTag()->getCString(),
-+#endif
- 	   font->getName() ? font->getName()->getCString() : "???",
- 	   args[1].getNum());
-     fflush(stdout);
--- 
-GitLab
-
diff --git a/srcpkgs/inkscape/patches/Fix-build-with-poppler-22.04.patch b/srcpkgs/inkscape/patches/Fix-build-with-poppler-22.04.patch
deleted file mode 100644
index f12054268a3c..000000000000
--- a/srcpkgs/inkscape/patches/Fix-build-with-poppler-22.04.patch
+++ /dev/null
@@ -1,143 +0,0 @@
-From d989cdf1059c78bc3bb6414330242073768d640b Mon Sep 17 00:00:00 2001
-From: Rafael Siejakowski <rs@rs-math.net>
-Date: Mon, 4 Apr 2022 22:09:39 -0300
-Subject: [PATCH] Compatibility with Poppler 22.04
-
-Replace vanilla pointers with std::shared_ptr for pointers to fonts;
-eliminate manual ref-counting.
-
-Fixes https://gitlab.com/inkscape/inkscape/-/issues/3387
----
- src/extension/internal/pdfinput/pdf-parser.cpp     | 14 ++++++++------
- .../internal/pdfinput/poppler-transition-api.h     |  6 ++++++
- src/extension/internal/pdfinput/svg-builder.cpp    |  7 +------
- src/extension/internal/pdfinput/svg-builder.h      |  1 -
- 4 files changed, 15 insertions(+), 13 deletions(-)
-
-diff --git a/src/extension/internal/pdfinput/pdf-parser.cpp b/src/extension/internal/pdfinput/pdf-parser.cpp
-index feecefa043..d6e2ede4f3 100644
---- a/src/extension/internal/pdfinput/pdf-parser.cpp
-+++ b/src/extension/internal/pdfinput/pdf-parser.cpp
-@@ -30,6 +30,7 @@
- #include "Gfx.h"
- #include "pdf-parser.h"
- #include "util/units.h"
-+#include "poppler-transition-api.h"
- 
- #include "glib/poppler-features.h"
- #include "goo/gmem.h"
-@@ -2158,7 +2159,7 @@ void PdfParser::opSetCharSpacing(Object args[], int /*numArgs*/)
- // TODO not good that numArgs is ignored but args[] is used:
- void PdfParser::opSetFont(Object args[], int /*numArgs*/)
- {
--  GfxFont *font = res->lookupFont(args[0].getName());
-+  auto font = res->lookupFont(args[0].getName());
- 
-   if (!font) {
-     // unsetting the font (drawing no text) is better than using the
-@@ -2179,7 +2180,9 @@ void PdfParser::opSetFont(Object args[], int /*numArgs*/)
-     fflush(stdout);
-   }
- 
-+#if !POPPLER_CHECK_VERSION(22, 4, 0)
-   font->incRefCnt();
-+#endif
-   state->setFont(font, args[1].getNum());
-   fontChanged = gTrue;
- }
-@@ -2373,7 +2376,6 @@ void PdfParser::doShowText(const GooString *s) {
- #else
- void PdfParser::doShowText(GooString *s) {
- #endif
--  GfxFont *font;
-   int wMode;
-   double riseX, riseY;
-   CharCode code;
-@@ -2392,7 +2394,7 @@ void PdfParser::doShowText(GooString *s) {
- #endif
-   int len, n, uLen;
- 
--  font = state->getFont();
-+  auto font = state->getFont();
-   wMode = font->getWMode();
- 
-   builder->beginString(state);
-@@ -2445,10 +2447,10 @@ void PdfParser::doShowText(GooString *s) {
-       //out->updateCTM(state, 1, 0, 0, 1, 0, 0);
-       if (false){ /*!out->beginType3Char(state, curX + riseX, curY + riseY, tdx, tdy,
- 			       code, u, uLen)) {*/
--        _POPPLER_CALL_ARGS(charProc, ((Gfx8BitFont *)font)->getCharProc, code);
--	if ((resDict = ((Gfx8BitFont *)font)->getResources())) {
-+        _POPPLER_CALL_ARGS(charProc, _POPPLER_FONTPTR_TO_GFX8(font)->getCharProc, code);
-+    if (resDict = _POPPLER_FONTPTR_TO_GFX8(font)->getResources()) {
- 	  pushResources(resDict);
--	}
-+    }
- 	if (charProc.isStream()) {
- 	  //parse(&charProc, gFalse); // TODO: parse into SVG font
- 	} else {
-diff --git a/src/extension/internal/pdfinput/poppler-transition-api.h b/src/extension/internal/pdfinput/poppler-transition-api.h
-index 50b617c25c..dc9e47e45b 100644
---- a/src/extension/internal/pdfinput/poppler-transition-api.h
-+++ b/src/extension/internal/pdfinput/poppler-transition-api.h
-@@ -14,6 +14,12 @@
- 
- #include <glib/poppler-features.h>
- 
-+#if POPPLER_CHECK_VERSION(22, 4, 0)
-+#define _POPPLER_FONTPTR_TO_GFX8(font_ptr) ((Gfx8BitFont *)font_ptr.get())
-+#else
-+#define _POPPLER_FONTPTR_TO_GFX8(font_ptr) ((Gfx8BitFont *)font_ptr)
-+#endif
-+
- #if POPPLER_CHECK_VERSION(22, 3, 0)
- #define _POPPLER_MAKE_SHARED_PDFDOC(uri) std::make_shared<PDFDoc>(std::make_unique<GooString>(uri))
- #else
-diff --git a/src/extension/internal/pdfinput/svg-builder.cpp b/src/extension/internal/pdfinput/svg-builder.cpp
-index eede668893..901cc8cddb 100644
---- a/src/extension/internal/pdfinput/svg-builder.cpp
-+++ b/src/extension/internal/pdfinput/svg-builder.cpp
-@@ -108,7 +108,6 @@ SvgBuilder::~SvgBuilder() = default;
- 
- void SvgBuilder::_init() {
-     _font_style = nullptr;
--    _current_font = nullptr;
-     _font_specification = nullptr;
-     _font_scaling = 1;
-     _need_font_update = true;
-@@ -1064,11 +1063,8 @@ void SvgBuilder::updateFont(GfxState *state) {
-     _need_font_update = false;
-     updateTextMatrix(state);    // Ensure that we have a text matrix built
- 
--    if (_font_style) {
--        //sp_repr_css_attr_unref(_font_style);
--    }
-     _font_style = sp_repr_css_attr_new();
--    GfxFont *font = state->getFont();
-+    auto font = state->getFont();
-     // Store original name
-     if (font->getName()) {
-         _font_specification = font->getName()->getCString();
-@@ -1213,7 +1209,6 @@ void SvgBuilder::updateFont(GfxState *state) {
-         sp_repr_css_set_property(_font_style, "writing-mode", "tb");
-     }
- 
--    _current_font = font;
-     _invalidated_style = true;
- }
- 
-diff --git a/src/extension/internal/pdfinput/svg-builder.h b/src/extension/internal/pdfinput/svg-builder.h
-index fb4e64fa19..e91febd717 100644
---- a/src/extension/internal/pdfinput/svg-builder.h
-+++ b/src/extension/internal/pdfinput/svg-builder.h
-@@ -204,7 +204,6 @@ private:
-     std::vector<SvgGraphicsState> _state_stack;
- 
-     SPCSSAttr *_font_style;          // Current font style
--    GfxFont *_current_font;
-     const char *_font_specification;
-     double _font_scaling;
-     bool _need_font_update;
--- 
-GitLab
-
diff --git a/srcpkgs/inkscape/template b/srcpkgs/inkscape/template
index 003d2170baf3..43edd634ed12 100644
--- a/srcpkgs/inkscape/template
+++ b/srcpkgs/inkscape/template
@@ -1,7 +1,7 @@
 # Template file for 'inkscape'
 pkgname=inkscape
-version=1.1.1
-revision=5
+version=1.2.2
+revision=1
 build_style=cmake
 # builds executables then runs checks
 # some tests still fail on musl: https://gitlab.com/inkscape/inkscape/-/issues/2241
@@ -12,15 +12,15 @@ makedepends="harfbuzz-devel libsoup-devel gsl-devel pango-devel libatomic_ops-de
  double-conversion-devel gc-devel libwpd-devel libcdr-devel libvisio-devel
  poppler-devel libwpd-devel potrace-devel gtkmm-devel gdl-devel gtkspell3-devel
  aspell-devel libxslt-devel libgomp-devel libwpg-devel poppler-glib-devel"
-depends="desktop-file-utils hicolor-icon-theme python3-appdirs python3-lxml python3-numpy
- python3-scour python3-Pillow"
+depends="desktop-file-utils hicolor-icon-theme python3-appdirs python3-cssselect
+ python3-lxml python3-numpy python3-scour python3-Pillow"
 checkdepends="$depends gtest-devel ImageMagick cantarell-fonts"
 short_desc="Vector-based drawing program"
 maintainer="Alex Lohr <alex.lohr@logmein.com>"
 license="GPL-2.0-only, LGPL-2.1-or-later"
 homepage="http://inkscape.org/"
 distfiles="https://media.inkscape.org/dl/resources/file/inkscape-${version}.tar.xz"
-checksum=aeca0b9d33b5b1cfa9aa70433bdee6a8c3d020ffafc2e6f0c9a60eed7a7978af
+checksum=a0c7fd0d03c0a21535e648ef301dcf80dd7cfc1f3545e51065fbf1ba3ee8a5c4
 python_version=3
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then

  parent reply	other threads:[~2022-12-07  6:12 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  4:11 [PR PATCH] inkscape: update to 1.1.2 hervyqa
2022-02-07  5:15 ` hervyqa
2022-02-23 16:11 ` tibequadorian
2022-02-23 23:32 ` hervyqa
2022-02-23 23:33 ` hervyqa
2022-02-23 23:38 ` hervyqa
2022-05-18  3:41 ` [PR PATCH] [Updated] " hervyqa
2022-05-18  3:59 ` [PR PATCH] [Updated] inkscape: update to 1.2 hervyqa
2022-05-18  4:12 ` hervyqa
2022-05-18  5:05 ` hervyqa
2022-05-18  5:38 ` hervyqa
2022-05-18  8:52 ` [PR PATCH] [Updated] " hervyqa
2022-05-19 14:50 ` ericonr
2022-05-20  4:34 ` hervyqa
2022-05-21 15:54 ` ericonr
2022-05-21 15:55 ` ericonr
2022-05-21 23:05 ` hervyqa
2022-05-21 23:11 ` [PR PATCH] [Updated] " hervyqa
2022-05-21 23:19 ` hervyqa
2022-05-22  1:59 ` ericonr
2022-05-23 14:10 ` hervyqa
2022-05-23 14:12 ` hervyqa
2022-05-25  1:46 ` ericonr
2022-05-27 15:33 ` hsnfirdaus
2022-05-27 18:52 ` hervyqa
2022-05-31 23:36 ` hervyqa
2022-05-31 23:36 ` hervyqa
2022-06-23 10:13 ` [PR PATCH] [Updated] " hervyqa
2022-06-23 11:24 ` hervyqa
2022-06-23 11:44 ` hervyqa
2022-06-23 11:59 ` hervyqa
2022-06-30 18:53 ` [PR REVIEW] " ericonr
2022-06-30 20:05 ` hervyqa
2022-06-30 20:17 ` [PR PATCH] [Updated] " hervyqa
2022-06-30 20:27 ` hervyqa
2022-07-07  6:25 ` hervyqa
2022-07-09 13:09 ` hervyqa
2022-07-09 13:11 ` hervyqa
2022-07-09 19:00 ` oreo639
2022-07-09 19:01 ` oreo639
2022-07-09 19:09 ` oreo639
2022-07-10  0:01 ` [PR PATCH] [Updated] " hervyqa
2022-07-15  1:43 ` hervyqa
2022-07-15  2:24 ` inkscape: update to 1.2.1 hervyqa
2022-07-16  7:24 ` paper42
2022-07-16  8:50 ` [PR PATCH] [Updated] " hervyqa
2022-07-16  8:55 ` hervyqa
2022-07-17 20:15 ` [PR PATCH] [Updated] " hervyqa
2022-09-25  0:16 ` dmarto
2022-09-25  7:59 ` [PR PATCH] [Updated] " hervyqa
2022-09-25  8:40 ` hervyqa
2022-12-07  5:43 ` [PR PATCH] [Updated] " hervyqa
2022-12-07  6:12 ` hervyqa [this message]
2023-01-08 22:16 ` inkscape: update to 1.2.2 manfredu
2023-01-08 22:17 ` manfredu
2023-01-08 22:27 ` paper42
2023-01-08 22:43 ` manfredu
2023-02-14 15:46 ` [PR PATCH] [Updated] " hervyqa
2023-02-14 15:49 ` hervyqa
2023-04-08 12:23 ` 1is7ac3
2023-04-28 15:42 ` [PR PATCH] [Updated] " hervyqa
2023-06-16  2:44 ` hervyqa
2023-06-26  0:42 ` [PR PATCH] [Closed]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221207061255.EhcYxTVcnCDjGTGQ_UOEdArFGRwXk2Na4dl6P6PZgs8@z \
    --to=hervyqa@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).