From: crtxcr <crtxcr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] spotify: Fix missing icon in KDE task manager
Date: Thu, 08 Dec 2022 14:29:39 +0100 [thread overview]
Message-ID: <20221208132939.7QPKewL9XH73gldjDLzbjO7_PsiEanp_NNyOfUd8dbY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40897@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]
There is an updated pull request by crtxcr against master on the void-packages repository
https://github.com/crtxcr/void-packages fix_spotify_icon
https://github.com/void-linux/void-packages/pull/40897
spotify: Fix missing icon in KDE task manager
Spotify onlys get a generic "X11" icon in the task manager. No window title is shown either.
The template moves the "icons" folder provided by spotify to /usr/share/spotify. However, it appears that spotify searches for the icons in /usr/libexec/spotify.
Create a symlink to /usr/share/spotify/icons so spotify finds the icons again.
This makes the spotify icon appear in the KDE taskbar. It also sets the title of the spotify window.
Fixes: #36615
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: YES
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/40897.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix_spotify_icon-40897.patch --]
[-- Type: text/x-diff, Size: 1348 bytes --]
From ea8d50e1706cc763b0d205108c5d412645384b6b Mon Sep 17 00:00:00 2001
From: Albert Schwarzkopf <dev-voidlinux@quitesimple.org>
Date: Sat, 3 Dec 2022 21:20:03 +0100
Subject: [PATCH] spotify: Fix missing icon in KDE task manager
Spotify onlys get a generic "X11" icon in the task manager. No window title is
shown either.
Previously, the template moved the icons. Symlink /usr/share/spotify/icons
to /usr/libexec/spotify/icons so spotify finds the icons again.
This makes the spotify icon appear in the KDE taskbar. It also sets the
title of the spotify window.
Fixes: #36615
---
srcpkgs/spotify/template | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index 50c28fc7672f..843c95dd8b0a 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -1,7 +1,7 @@
# Template file for 'spotify'
pkgname=spotify
version=1.1.84
-revision=3
+revision=4
archs="x86_64"
create_wrksrc=yes
hostmakedepends="curl w3m libcurl"
@@ -36,8 +36,7 @@ do_install() {
vmkdir usr/libexec/
vcopy usr/share/spotify usr/libexec/
- # move icons to /usr/share
- mv "${DESTDIR}/usr/libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
+ ln -s "../../libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
# install icons
for _s in 16 22 24 32 48 64 128 256 512; do
next prev parent reply other threads:[~2022-12-08 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 20:35 [PR PATCH] " crtxcr
2022-12-03 20:37 ` [PR PATCH] [Updated] " crtxcr
2022-12-07 1:32 ` [PR REVIEW] " sgn
2022-12-08 13:29 ` crtxcr [this message]
2022-12-08 13:35 ` crtxcr
2022-12-12 7:40 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208132939.7QPKewL9XH73gldjDLzbjO7_PsiEanp_NNyOfUd8dbY@z \
--to=crtxcr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).