Github messages for voidlinux
 help / color / mirror / Atom feed
From: crtxcr <crtxcr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Update nss to 3.86
Date: Fri, 09 Dec 2022 23:42:04 +0100	[thread overview]
Message-ID: <20221209224204.g5W7DJ4ll3XQqASTHKeHyYxTb2aILUgM92x-jtfFv_w@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40989@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

New comment by crtxcr on void-packages repository

https://github.com/void-linux/void-packages/pull/40989#issuecomment-1344856621

Comment:
>Did you run the full test-suite before submitting? Just asking since those commit was made 20 minutes ago!

I admit I didn't run the tests. I must have missed it in the contributions guidelines (where I see now it says it's encouraged, not required), But anyway, as I plan to contribute in the future, I have now set it to XBPS_CHECK_PKGS=yes. Which  isn't =full, but for this template would not make a difference aiui.

I am just new to void trying to help out here and there. So thanks for making me aware of that!

Now, what it do though is perform a basic runtime check with Firefox, Thunderbird simply by using TLS connections.

For what's it worth, I did run the tests now. All of them have have passed. I see they have failed in the CI for x86_64, but that seems normal for NSS juding from prior PRs.

```
Tests summary:
--------------
Passed:             81692
Failed:             0
Failed with core:   0
ASan failures:      0
Unknown status:     2
TinderboxPrint:Unknown: 2
```

>FWIW, I have nss update in my backlog already.

Good to know. I figured this PR could't hurt as nss was 3 versions behind and because this one blacklists a CA. 



  parent reply	other threads:[~2022-12-09 22:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09 19:50 [PR PATCH] " crtxcr
2022-12-09 20:00 ` sgn
2022-12-09 20:15 ` sgn
2022-12-09 22:42 ` crtxcr [this message]
2022-12-10  3:04 ` sgn
2022-12-10 10:02 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221209224204.g5W7DJ4ll3XQqASTHKeHyYxTb2aILUgM92x-jtfFv_w@z \
    --to=crtxcr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).