Github messages for voidlinux
 help / color / mirror / Atom feed
From: r-ricci <r-ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: go: update to 1.19.4.
Date: Thu, 15 Dec 2022 02:15:29 +0100	[thread overview]
Message-ID: <20221215011529.VDc87w-j6Vq9TGMP0roDvKHHO8JGRq1SRrdGZFuJhxU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41027@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/41027#issuecomment-1352432381

Comment:
> ```
> %: git submodule update --init --recursive
> git: 'submodule' is not a git command. See 'git --help'.
> ```
> 
> It seems like it's trying to use git from chroot-git which doesn't have the submodule subcommand, so I think adding git to checkdepends would help. The checks pass locally for me in both master and this branch. Can you reproduce this issue locally?

You are right.
Tests failed locally for me, but for another reason. There is a known failure on ZFS and the template removes this test if ZFS is detected, but I used -t, so the filesystem was reported as "overlay". Besides this, tests pass.
On CI, adding git to checkdepends would fix the failure, but I think it's better to understand why it wants to use `git submodule` and fix that instead, so I added `make_check=ci-skip` for now.

  parent reply	other threads:[~2022-12-15  1:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11 21:50 [PR PATCH] " r-ricci
2022-12-12 16:00 ` r-ricci
2022-12-13 19:52 ` paper42
2022-12-15  0:53 ` [PR PATCH] [Updated] " r-ricci
2022-12-15  1:15 ` r-ricci [this message]
2022-12-17 17:44 ` r-ricci
2022-12-18 11:01 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221215011529.VDc87w-j6Vq9TGMP0roDvKHHO8JGRq1SRrdGZFuJhxU@z \
    --to=r-ricci@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).